ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-27 17:23:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add setting for enabling using new markdown renderer (#16864)

Browse Source 
* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false
This commit is contained in:
Charles Gagnon
2021-08-25 12:43:32 -07:00
committed by GitHub
parent 78f1b3b768
commit fe1f8fb2f3
5 changed files with 39 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/workbench/contrib/notebook/test/browser/notebookMarkdown.test.ts
View File

@@ -7,9 +7,10 @@ import * as assert from 'assert';
import * as marked from 'vs/base/common/marked/marked';
import { NotebookMarkdownRenderer } from '../../browser/outputs/notebookMarkdown';
import { URI } from 'vs/base/common/uri';
import { TestConfigurationService } from 'sql/platform/connection/test/common/testConfigurationService';
suite('NotebookMarkdownRenderer', () => {
let notebookMarkdownRenderer = new NotebookMarkdownRenderer();
let notebookMarkdownRenderer = new NotebookMarkdownRenderer(new TestConfigurationService({ user: { 'notebook': { 'useNewMarkdownRenderer': false } } }));
test('image rendering conforms to default', () => {
const markdown = { value: `![image](someimageurl 'caption')` };
const result: HTMLElement = notebookMarkdownRenderer.renderMarkdown(markdown);

4
src/sql/workbench/contrib/notebook/test/electron-browser/notebookFindModel.test.ts
View File

@@ -31,7 +31,7 @@ import { NotebookRange } from 'sql/workbench/services/notebook/browser/notebookS
import { NotebookMarkdownRenderer } from 'sql/workbench/contrib/notebook/browser/outputs/notebookMarkdown';
import { NullAdsTelemetryService } from 'sql/platform/telemetry/common/adsTelemetryService';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService';
import { TestConfigurationService } from 'sql/platform/connection/test/common/testConfigurationService';
let expectedNotebookContent: nb.INotebookContents = {
cells: [{
@@ -74,7 +74,7 @@ suite('Notebook Find Model', function (): void {
let defaultModelOptions: INotebookModelOptions;
const logService = new NullLogService();
let model: NotebookModel;
let markdownRenderer: NotebookMarkdownRenderer = new NotebookMarkdownRenderer();
let markdownRenderer: NotebookMarkdownRenderer = new NotebookMarkdownRenderer(new TestConfigurationService());
let configurationService: IConfigurationService;
setup(async () => {