Merge from vscode 3c6f6af7347d38e87bc6406024e8dcf9e9bce229 (#8962)

* Merge from vscode 3c6f6af7347d38e87bc6406024e8dcf9e9bce229

* skip failing tests

* update mac build image
This commit is contained in:
Anthony Dresser
2020-01-27 15:28:17 -08:00
committed by Karl Burtram
parent 0eaee18dc4
commit fefe1454de
481 changed files with 12764 additions and 7836 deletions

View File

@@ -142,10 +142,10 @@ export class SuggestModel implements IDisposable {
}));
let editorIsComposing = false;
this._toDispose.add(this._editor.onCompositionStart(() => {
this._toDispose.add(this._editor.onDidCompositionStart(() => {
editorIsComposing = true;
}));
this._toDispose.add(this._editor.onCompositionEnd(() => {
this._toDispose.add(this._editor.onDidCompositionEnd(() => {
// refilter when composition ends
editorIsComposing = false;
this._refilterCompletionItems();
@@ -233,7 +233,7 @@ export class SuggestModel implements IDisposable {
};
this._triggerCharacterListener.add(this._editor.onDidType(checkTriggerCharacter));
this._triggerCharacterListener.add(this._editor.onCompositionEnd(checkTriggerCharacter));
this._triggerCharacterListener.add(this._editor.onDidCompositionEnd(checkTriggerCharacter));
}
// --- trigger/retrigger/cancel suggest
@@ -286,9 +286,7 @@ export class SuggestModel implements IDisposable {
) {
// Early exit if nothing needs to be done!
// Leave some form of early exit check here if you wish to continue being a cursor position change listener ;)
if (this._state !== State.Idle) {
this.cancel();
}
this.cancel();
return;
}