ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

handle table designer errors (#22527)

Browse Source 
* handle table designer error

* log to console
This commit is contained in:
Alan Ren
2023-03-29 16:37:15 -07:00
committed by GitHub
parent 4458a5bd57
commit ff603fa911
1 changed files with 54 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
extensions/mssql/src/tableDesigner/tableDesigner.ts
View File

@@ -11,16 +11,21 @@ import { generateUuid } from 'vscode-languageclient/lib/utils/uuid';
import { fillServerInfo } from '../telemetry'; import { fillServerInfo } from '../telemetry';
import * as telemetry from '@microsoft/ads-extension-telemetry'; import * as telemetry from '@microsoft/ads-extension-telemetry';
import * as nls from 'vscode-nls'; import * as nls from 'vscode-nls';
import { getConfigPreloadDatabaseModel, setConfigPreloadDatabaseModel } from '../utils'; import { getConfigPreloadDatabaseModel, getErrorMessage, setConfigPreloadDatabaseModel } from '../utils';
const localize = nls.loadMessageBundle(); const localize = nls.loadMessageBundle();
const NewTableText = localize('tableDesigner.NewTable', "New Table"); const NewTableText = localize('tableDesigner.NewTable', "New Table");
const DidInformUserKey: string = 'tableDesigner.DidInformUser'; const DidInformUserKey: string = 'tableDesigner.DidInformUser';
const FailedToGetConnectionStringError = localize('tableDesigner.FailedToGetConnectionStringError', "Failed to get connection string for the table. Please reconnect to the server and try again.");
export function registerTableDesignerCommands(appContext: AppContext) { export function registerTableDesignerCommands(appContext: AppContext) {
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.newTable', async (context: azdata.ObjectExplorerContext) => { appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.newTable', async (context: azdata.ObjectExplorerContext) => {
try {
void showPreloadDbModelSettingPrompt(appContext); void showPreloadDbModelSettingPrompt(appContext);
const connectionString = await azdata.connection.getConnectionString(context.connectionProfile!.id, true); const connectionString = await azdata.connection.getConnectionString(context.connectionProfile!.id, true);
if (!connectionString) {
throw new Error(FailedToGetConnectionStringError);
}
const tableIcon = context.nodeInfo!.nodeSubType as azdata.designers.TableIcon; const tableIcon = context.nodeInfo!.nodeSubType as azdata.designers.TableIcon;
const telemetryInfo = await getTelemetryInfo(context, tableIcon); const telemetryInfo = await getTelemetryInfo(context, tableIcon);
await azdata.designers.openTableDesigner(sqlProviderName, { await azdata.designers.openTableDesigner(sqlProviderName, {
@@ -34,15 +39,23 @@ export function registerTableDesignerCommands(appContext: AppContext) {
accessToken: context.connectionProfile!.options.azureAccountToken, accessToken: context.connectionProfile!.options.azureAccountToken,
tableIcon: tableIcon tableIcon: tableIcon
}, telemetryInfo); }, telemetryInfo);
} catch (error) {
console.error(error);
await vscode.window.showErrorMessage(getErrorMessage(error), { modal: true });
}
})); }));
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.designTable', async (context: azdata.ObjectExplorerContext) => { appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.designTable', async (context: azdata.ObjectExplorerContext) => {
try {
void showPreloadDbModelSettingPrompt(appContext); void showPreloadDbModelSettingPrompt(appContext);
const server = context.connectionProfile!.serverName; const server = context.connectionProfile!.serverName;
const database = context.connectionProfile!.databaseName; const database = context.connectionProfile!.databaseName;
const schema = context.nodeInfo!.metadata!.schema; const schema = context.nodeInfo!.metadata!.schema;
const name = context.nodeInfo!.metadata!.name; const name = context.nodeInfo!.metadata!.name;
const connectionString = await azdata.connection.getConnectionString(context.connectionProfile!.id, true); const connectionString = await azdata.connection.getConnectionString(context.connectionProfile!.id, true);
if (connectionString) {
throw new Error(FailedToGetConnectionStringError);
}
const tableIcon = context.nodeInfo!.nodeSubType as azdata.designers.TableIcon; const tableIcon = context.nodeInfo!.nodeSubType as azdata.designers.TableIcon;
const telemetryInfo = await getTelemetryInfo(context, tableIcon); const telemetryInfo = await getTelemetryInfo(context, tableIcon);
await azdata.designers.openTableDesigner(sqlProviderName, { await azdata.designers.openTableDesigner(sqlProviderName, {
@@ -58,6 +71,10 @@ export function registerTableDesignerCommands(appContext: AppContext) {
accessToken: context.connectionProfile!.options.azureAccountToken, accessToken: context.connectionProfile!.options.azureAccountToken,
tableIcon: tableIcon tableIcon: tableIcon
}, telemetryInfo); }, telemetryInfo);
} catch (error) {
console.error(error);
await vscode.window.showErrorMessage(getErrorMessage(error), { modal: true });
}
})); }));
} }