ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Skip adding empty list of items (#14084)

Browse Source
This commit is contained in:
Charles Gagnon
2021-01-28 09:08:40 -08:00
committed by GitHub
parent 8677ffc68c
commit ff6f30505c
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/workbench/browser/modelComponents/viewBase.ts
View File

@@ -103,6 +103,11 @@ export abstract class ViewBase extends AngularDisposable implements IModelView {
} }
addToContainer(containerId: string, items: { itemConfig: IItemConfig, index?: number }[], initial?: boolean): void { addToContainer(containerId: string, items: { itemConfig: IItemConfig, index?: number }[], initial?: boolean): void {
if (items.length === 0) {
// If we don't have any items save ourselves the time and just exit early. This can happen when
// an item is defined since we may have components definitions which have empty itemConfigs
return;
}
const itemNames = items.map(item => item.itemConfig.componentShape.id).join(','); const itemNames = items.map(item => item.itemConfig.componentShape.id).join(',');
this.logService.debug(`Queueing action to add components ${itemNames} to container ${containerId}`); this.logService.debug(`Queueing action to add components ${itemNames} to container ${containerId}`);
// Do not return the promise as this should be non-blocking // Do not return the promise as this should be non-blocking