ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Security: Added warning for all vsix extensions (#2406)

Browse Source 
* added warning for all vsix extensions

* added sql carbon tag

* added dont show warning for extensions
This commit is contained in:
Aditya Bist
2018-09-07 16:25:19 -07:00
committed by Karl Burtram
parent 16bc218ea7
commit ff8698f619
1 changed files with 54 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
src/vs/workbench/parts/extensions/electron-browser/extensionsActions.ts
View File

@@ -52,6 +52,8 @@ import { IEditorGroupsService } from 'vs/workbench/services/group/common/editorG
import { ExtensionsInput } from 'vs/workbench/parts/extensions/common/extensionsInput'; import { ExtensionsInput } from 'vs/workbench/parts/extensions/common/extensionsInput';
import product from 'vs/platform/node/product'; import product from 'vs/platform/node/product';
import { ContextSubMenu } from 'vs/base/browser/contextmenu'; import { ContextSubMenu } from 'vs/base/browser/contextmenu';
// {{SQL CARBON EDIT}}
import { IStorageService } from 'vs/platform/storage/common/storage';
const promptDownloadManually = (extension: IGalleryExtension, message: string, instantiationService: IInstantiationService, notificationService: INotificationService, openerService: IOpenerService) => { const promptDownloadManually = (extension: IGalleryExtension, message: string, instantiationService: IInstantiationService, notificationService: INotificationService, openerService: IOpenerService) => {
const downloadUrl = `${product.extensionsGallery.serviceUrl}/publishers/${extension.publisher}/vsextensions/${extension.name}/${extension.version}/vspackage`; const downloadUrl = `${product.extensionsGallery.serviceUrl}/publishers/${extension.publisher}/vsextensions/${extension.name}/${extension.version}/vspackage`;
@@ -2656,7 +2658,9 @@ export class InstallVSIXAction extends Action {
label = InstallVSIXAction.LABEL, label = InstallVSIXAction.LABEL,
@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService, @IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
@INotificationService private notificationService: INotificationService, @INotificationService private notificationService: INotificationService,
@IWindowService private windowService: IWindowService @IWindowService private windowService: IWindowService,
// {{SQL CARBON EDIT}}
@IStorageService private storageService: IStorageService
) { ) {
super(id, label, 'extension-action install-vsix', true); super(id, label, 'extension-action install-vsix', true);
} }
@@ -2671,8 +2675,17 @@ export class InstallVSIXAction extends Action {
if (!result) { if (!result) {
return TPromise.as(null); return TPromise.as(null);
} }
return TPromise.join(result.map(vsix => {
return TPromise.join(result.map(vsix => this.extensionsWorkbenchService.install(vsix))).then(() => { // {{SQL CARBON EDIT}}
if (!this.storageService.getBoolean(vsix)) {
this.notificationService.prompt(
Severity.Warning,
localize('thirdPartyExtension.vsix', 'This is a third party extension and might involve security risks. Are you sure you want to install this extension?'),
[
{
label: localize('thirdPartExt.yes', 'Yes'),
run: () => {
this.extensionsWorkbenchService.install(vsix).then(() => {
this.notificationService.prompt( this.notificationService.prompt(
Severity.Info, Severity.Info,
localize('InstallVSIXAction.success', "Successfully installed the extension. Reload to enable it."), localize('InstallVSIXAction.success', "Successfully installed the extension. Reload to enable it."),
@@ -2682,6 +2695,36 @@ export class InstallVSIXAction extends Action {
}] }]
); );
}); });
}
},
{
label: localize('thirdPartyExt.no', 'No'),
run: () => { return TPromise.as(null); }
},
{
label: localize('thirdPartyExt.dontShowAgain', 'Don\'t Show Again'),
isSecondary: true,
run: () => {
this.storageService.store(vsix, true);
return TPromise.as(null);
}
}
]
);
} else {
this.extensionsWorkbenchService.install(vsix).then(() => {
this.notificationService.prompt(
Severity.Info,
localize('InstallVSIXAction.success', "Successfully installed the extension. Reload to enable it."),
[{
label: localize('InstallVSIXAction.reloadNow', "Reload Now"),
run: () => this.windowService.reloadWindow()
}]
);
});
}
}));
}); });
} }
} }