Cheena Malhotra
9847d9dbc1
Support advanced options in command line arguments ( #23104 )
2023-05-12 12:24:34 -07:00
Alex Ma
142a3aaf7c
Added back fix for duplicate edits ( #23003 )
2023-05-11 17:56:42 -07:00
Cheena Malhotra
c292c1e7ce
Support migrating credentials to new format ( #23088 )
2023-05-10 20:53:14 -07:00
Cheena Malhotra
77c8b3bda1
Validate MSAL library is enabled ( #23000 )
2023-05-05 16:44:04 -07:00
Alex Ma
898bb73a34
Revert new connection string format ( #22997 )
2023-05-05 13:41:40 -07:00
Cheena Malhotra
ea6bb41f45
Allow 'ApplicationName' to be specified for MSSQL connections ( #22890 )
2023-05-01 10:55:05 -07:00
Charles Gagnon
64dd4f0904
Fix IConnectionProfile to have same options key when generated from ConnectionProfile ( #22840 )
2023-04-25 09:52:51 -07:00
Cheena Malhotra
2247d5de88
Prevent reconnects for mssql provider ( #22825 )
2023-04-21 16:56:40 -07:00
Karl Burtram
e7d3d047ec
Merge from vscode merge-base ( #22780 )
...
* Revert "Revert "Merge from vscode merge-base (#22769 )" (#22779 )"
This reverts commit 47a1745180 .
* Fix notebook download task
* Remove done call from extensions-ci
2023-04-19 21:48:46 -07:00
Cheena Malhotra
ba694a0558
Register mysql, pgsql with mssql as default 'sql' kernel providers ( #22729 )
2023-04-18 22:07:02 -07:00
Karl Burtram
47a1745180
Revert "Merge from vscode merge-base ( #22769 )" ( #22779 )
...
This reverts commit 6bd0a17d3c .
2023-04-18 21:44:05 -07:00
Lewis Sanchez
6bd0a17d3c
Merge from vscode merge-base ( #22769 )
...
* Merge from vscode merge-base
* Turn off basic checks
* Enable compilation, unit, and integration tests
2023-04-18 18:28:58 -07:00
Alex Ma
b69e87df15
Connection URI with complete options (finalized) ( #22735 )
...
* Connection URI made to include every option available instead of basic details (#22045 )
* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"
This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.
* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""
This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.
* Added changes and fixes for feat connectionuri (#22706 )
* add title generation at start
* added await to refreshConnectionTreeTitles
2023-04-18 11:08:48 -07:00
Aasim Khan
b7d24dcecd
Cleaning up some code in Async Server Tree. ( #22732 )
2023-04-17 23:23:41 -07:00
Charles Gagnon
df88d881c5
Remove disposable from connection ( #22687 )
...
* Remove disposable from connection
* Remove from group
2023-04-11 15:27:01 -07:00
Aasim Khan
5ae0e3a503
Removed parent override ( #22648 )
2023-04-06 15:26:50 -07:00
Aasim Khan
2a9705c495
Fixing async server tree ( #22511 )
...
* Changing look of new OE
* Fixing styling
* Fixing moving of connected profile
* Fixing drag and drop where treenodes delete connection nodes
* Fixing Deleting and disconnecting in AsyncServerTree
* Adding constant for OE timeout
* Updated interfaces
* Removing test compilation errors
* Fixing most events in async server tree
* Fixing connection pane styling
* Fixing find node function
* Fixing some more operations
* Fixing some ops
* All operations done
* Fixed active connections
* Fixed data source
* Adding support for setting parents
* code cleanup
* Fixing icon styling issues
* Fix errors
* Fixing comment
* Fixing spacing
* Adding explanation to OE service.
* Reverting server delegate changes
* Reverting styling
* reverting more styling change
* reverting more styling
* Fixing has children
* Fixing drag and drop to tree nodes
* fixing drag and drop
* reverting timing
* fixing drag and drop
* cleaning some code
* Fixed server and group moving
* spell check
* consolidating some logic
* Fixed whitespace
* fixing moving to root group
2023-03-29 13:59:35 -07:00
Charles Gagnon
ed37ad315f
Clean up buildConnectionInfo ( #22407 )
...
* Clean up buildConnectionInfo
* Add test and cleanup
2023-03-22 12:54:29 -07:00
Cheena Malhotra
aa350f7e49
Enable SQL Auth Provider support ( #21903 )
2023-03-03 12:49:01 -08:00
Aasim Khan
555f8fbb1e
Adding null checks to prevent runtime exceptions ( #22054 )
2023-02-27 23:46:14 -08:00
Cheena Malhotra
3fb8d57d25
Add support for Encrypt=Strict for TDS 8.0 connections with SQL Server 2022 ( #21256 )
2023-02-10 10:34:36 -08:00
Cheena Malhotra
66410edf02
Migrate cert validation error handling to mssql extension ( #21829 )
2023-02-07 09:21:35 -08:00
Alex Ma
a911044745
Removed deepcopy and remove credentials functions from utils ( #21808 )
2023-02-01 14:20:25 -08:00
Alex Ma
298402647d
Added error handling service for providers ( #21627 )
...
* added prototype errorHandlerService
* added initial contracts
* Added WIP client sent request function
* added WIP signature for handleOtherError to resourceProviderService
* made some small fixes
* removed unnecessary resourceProviderId
* added updates to contracts and resourceProvider
* moved error codes to azdata proposed
* added connection type instead of profile
* added WIP handleOtherError code
* added fix for send
* added WIP change password function in resource provider
* added work in progress error handling thread
* added errorHandler interface
* added result error check
* renamed errorHandling namespace to diagnostics
* WIP rename of errorhandler
* light cleanup
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/machine-learning (#21514 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Stops second invocation of createNewSession while expanding OE tree items on disconnected servers (#21437 )
* Debounces second invocation while expanding OE tree items
* Minor clean up
* Adjusts debounce time
* Adding temp trace comments
* Adds missing semicolon
* Removes debouncer to stop 2nd newSession calls
* Removes temp trace comments
* Updates comment
Co-authored-by: Alan Ren <alanren@microsoft.com >
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/admin-tool-ext-win (#21546 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix resource endpoints to end with slash (#21540 )
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/azcli (#21543 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/arc (#21544 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renamed diagnostics service slightly
* registered service
* added work in progress diagnostics implementation
* small changes
* added new diagnostics exe
* Changes for Diagnostics Service (#21583 )
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
* WIP provider changes
* added changes for errorDiagnosticsService
* removed stuff from mssql.
* made fix to connectionManagementService
* added error catch
* added small changes
* more small changes made
* added small changes to handleOtherError
* moved changePassword to CMS
* added testErrorDiagnosticsService
* Added provider-based handling for change password/generic error handling. (#21662 )
* WIP rework for error connection change
* added connectionProfileDuringError
* added working password reset
* added comments
* consolidated connection profile conversion
* added additionalObjects parameter.
* removed unnecessary error profile grab
* added comments
* added changes to parameters and comments
* added changes and params
* added handleConnectionErrorParam
* added more changes
* added async
* added params and more
* added many fixes
* added updated documentation
* added WIP password change dialog with await
* added error handling
* added comment
* added options as parameters
* cleaned up parameters
* added async
* added check fixes
* Added username to title
* added server name to dialog
* Added dialog changes
* Revert "Added dialog changes"
This reverts commit c2bdcd16f4a0dffdc643ef9cae1c1a20642ac512.
* Revert "added server name to dialog"
This reverts commit dbd22e80461b5a068643f0c2d6728adce4010978.
* Revert "Added username to title"
This reverts commit 6d936b4d5f97f9345f8ec2fdbbcf6b52df18820a.
* Revert "added check fixes"
This reverts commit f58081a5af3276766e2042b4d671455b18add9a7.
* Revert "added async"
This reverts commit dd1198e26ec7542ec51add0628f588361d674299.
* Revert "cleaned up parameters"
This reverts commit 51135c9f9db452104697483779d8df15b6430717.
* Revert "added options as parameters"
This reverts commit b167804a2410558bbe60042e017ae2c77af7697f.
* Revert "added comment"
This reverts commit 0ad37326a3e025e88f715e3f2547be6825597a8d.
* Revert "added error handling"
This reverts commit 69340980d2c84056a2bcf126ea77f4b5ed4cddf3.
* Revert "added WIP password change dialog with await"
This reverts commit 9e43113e07b10421b39575f6c7dd14287662b90d.
* added a fix to check
* added fixes
* added back in change password changes
* added in comment
* added suggested changes
* removed param colons
* Update extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* fixed conversion and provider dialog
* altered comments
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* renamed Id
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Improvements for Change password dialog + logs added (#21794 )
* Improvements for Change password dialog + logs added
* Include server
* fixed tab space
* added comment
---------
Co-authored-by: Alex Ma <alma1@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* added fix to id to extHostErrorDiagnostics
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com >
Co-authored-by: Alan Ren <alanren@microsoft.com >
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com >
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-01-31 14:31:12 -08:00
Cheena Malhotra
fd2ced449b
Skip fetching access token when opening context menu in OE ( #21557 )
2023-01-09 21:22:02 -08:00
Alex Ma
cffba368a9
Added reset password dialog upon SQL Server expired password error ( #21295 )
...
* Added initial password connection dialog box
* made small changes
* more preliminary work
* more WIP changes
* more cleanup done
* added dialog instantiation
* added placeholder dialog window
* added changePasswordController
* made some changes to changePasswordController
* some changes made
* added more changes
* more changes made to dialogue
* added password confirm box
* added WIP change password function
* small changes made to API
* small changes for test
* added uri
* added valid password
* added TODO comments
* added small change to connectionManagementService
* added connectionManagementService password change
* added comment on what to do next
* made some simplification of change password
* added response callback
* added fixes to protocol
* added throw error for passwordChangeResult
* WIP added call to self after password change
* WIP changes to implementing new password change dialog
* added changes to passwordChangeDialog
* added launchChangePasswordDialog
* remove erroneous css
* added working dialog
* removed old password change dialog
* fixed space
* added checkbox option to passwordChangeDialog
* added test signatures
* added error handling
* added some changes
* added changes to HTML for passwordChangeDialog
* added CSS to passwordChangeDialog
* added display none for matching passwords
* added documentation changes
* small cleanup
* added working error catch and retry
* added await
* added recovery instructions
* Added ok button hide for button click.
* added loading spinner
* fixed for semicolon
* added updated message
* Added message change
* added minor fixes
* added small fixes
* made more changes
* renamed messages to errorDetails
* added styling to passwordChangeDialog
* simplified error message
* changed comment
* modified azdata to be consistent
* small changes
* change to azdata for consistency
* added clarification for provider
* removed additional instructions
* Added new dialog title
* addressed feedback
* added comments
* added changes
2022-12-07 14:27:01 -08:00
Cheena Malhotra
3b6ce47acc
Fix access token refresh design (ADS only) ( #21206 )
2022-11-21 19:35:00 -08:00
Cheena Malhotra
f5a3a9ad8c
Update error dialog to include instructions text for SSL cert validation failure ( #21036 )
2022-11-01 09:59:50 -07:00
Cheena Malhotra
bb24eb29c5
Fix issue with SQL Database Projects unable to connect due to default encryption ( #21010 )
2022-11-01 09:26:37 -07:00
Charles Gagnon
39e9018b7c
Add/update providerConnectionInfo.getOptionsKey tests ( #21001 )
2022-10-26 22:45:40 -07:00
Cheena Malhotra
4b4c5d8ffe
Change back to existing identity design ( #20991 )
2022-10-26 16:44:29 -07:00
Cheena Malhotra
987aed3b92
Add custom option support on Connection dialog + move Encrypt to connection dialog ( #20959 )
2022-10-25 12:19:40 -07:00
Cheena Malhotra
0abb8da026
Fix Edit Connection behavior that affects multiple areas working with edited connection ( #20907 )
2022-10-21 11:03:10 -07:00
Karl Burtram
8a3d08f0de
Merge vscode 1.67 ( #20883 )
...
* Fix initial build breaks from 1.67 merge (#2514 )
* Update yarn lock files
* Update build scripts
* Fix tsconfig
* Build breaks
* WIP
* Update yarn lock files
* Misc breaks
* Updates to package.json
* Breaks
* Update yarn
* Fix breaks
* Breaks
* Build breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Missing file
* Breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Fix several runtime breaks (#2515 )
* Missing files
* Runtime breaks
* Fix proxy ordering issue
* Remove commented code
* Fix breaks with opening query editor
* Fix post merge break
* Updates related to setup build and other breaks (#2516 )
* Fix bundle build issues
* Update distro
* Fix distro merge and update build JS files
* Disable pipeline steps
* Remove stats call
* Update license name
* Make new RPM dependencies a warning
* Fix extension manager version checks
* Update JS file
* Fix a few runtime breaks
* Fixes
* Fix runtime issues
* Fix build breaks
* Update notebook tests (part 1)
* Fix broken tests
* Linting errors
* Fix hygiene
* Disable lint rules
* Bump distro
* Turn off smoke tests
* Disable integration tests
* Remove failing "activate" test
* Remove failed test assertion
* Disable other broken test
* Disable query history tests
* Disable extension unit tests
* Disable failing tasks
2022-10-19 19:13:18 -07:00
Charles Gagnon
93008b51c4
Directly install missing provider extensions ( #20771 )
...
* Directly install missing provider extensions
* Update interface
2022-10-10 13:04:07 -07:00
Charles Gagnon
85dc506a3c
Add AuthenticationType enum to typings ( #20699 )
...
* Add AuthenticationType enum to typings
* fix
* const
* Add comments
* fix comment
* remove unused
2022-09-30 16:49:36 -07:00
Charles Gagnon
603ae9b94c
Fix queryDocument.connect ( #20682 )
...
* Fix queryEditor.connect
* Remove decorator
* undo
* fix test
* Use connectionProfile for comparison
* remove unused
* Remove helper method
2022-09-28 11:28:58 -07:00
Alan Ren
6015c8e2f4
handle unsupported connections in OE/Recent connections view ( #20588 )
...
* handle unknown provider in OE
* more update
* add comment
* test
2022-09-12 11:48:08 -07:00
Alan Ren
be8bf7fcdc
handle unsupported connection provider ( #20577 )
...
* handle unknown connection provider
* fix error
2022-09-09 14:14:33 -07:00
Alan Ren
1f6482490c
handle default auth type ( #20572 )
...
* handle default auth type
* comments
2022-09-09 08:59:53 -07:00
Hai Cao
d6c114c32a
Fix connection sorting by name in OE ( #19991 )
...
* use localeCompare & sort by title instead of name
* fix tests
2022-07-11 15:35:08 -07:00
Charles Gagnon
41a3c8661c
Fix GetConnection ( #19579 )
2022-05-31 21:32:44 -07:00
Charles Gagnon
8da49ff14e
Remove connection error popup notification ( #18476 )
...
* Remove connection error popup notification
* Fix compile
2022-02-18 09:04:13 -08:00
Alan Ren
57d5d94c46
fix connection error scenario ( #18335 )
...
* fix connection error scenario
* pr comments
2022-02-11 18:49:29 -08:00
Charles Gagnon
1c9ba64ee0
check-param-names ( #18189 )
2022-01-31 12:39:22 -08:00
Alan Ren
d8467f2c1a
null check before calling isDisposable ( #17959 )
2021-12-17 09:56:04 -08:00
Alan Ren
970fe12e70
fix listener leaks ( #17913 )
...
* fix listener leaks
* add null check
* simplify
* pr comments
2021-12-14 13:35:00 -08:00
Alan Ren
a9a8fec98a
open database dashboard ( #17871 )
2021-12-08 14:52:50 -08:00
Alan Ren
b48f392ab2
optional database name option ( #17538 )
...
* optional database name option
* object explorer connection title
* revert unexpected change
* bug fixes
2021-10-29 16:37:35 -07:00
nasc17
75d6847a65
Set original database for connection done through connection dialog ( #17266 )
...
* check if database connection
* Change name of isMaster and remove import
* Set to false
* take out connecttodatabase
* remove connecttodatabase
* Original database
* remove empty string check
* clean
* set original database for when saving connection
* pass unit test
* map -> find
* PR changes
* Comments for original database
2021-10-08 13:10:28 -07:00