Commit Graph

1122 Commits

Author SHA1 Message Date
Lewis Sanchez
00ff3ac50f Add functionality to expand and collapse all property rows. (#20746)
* Adds ability to expand and collapse all property rows

* Removes duplicate collapse/expand all logic

* Code review changes

* Removes unnecessary enum

* Updates comment

* Code review changes

* Code review changes

* Minor clean up

* Renames expand/collapse method

* Corrects collapse all action IDs and labels
2022-10-06 20:47:20 -07:00
Lewis Sanchez
f046129515 Adds not equal operator and expands unequal collapsed header rows (#20737)
* Adds not equal operator and expands unequal collapsed prop rows

* Minor clean up.
2022-10-06 13:45:04 -07:00
Lewis Sanchez
65a3bd7491 Shows not equal operator when comparing non-null props to null props (#20740) 2022-10-05 18:49:06 -07:00
Lewis Sanchez
6ea75bb538 Removes summary section from plan comparison properties view (#20735) 2022-10-05 18:48:53 -07:00
Benjamin Russell
29daa72ef1 Give saveAsExcel its own config options (#20647)
Co-authored-by: Ben Russell <russellben@microsoft.com>
2022-10-05 09:40:00 -07:00
Alan Ren
2df3f1a161 Remove preview flag for table designer (#20720)
* remove the preview flag for table designer feature

* sqlproj
2022-10-04 10:58:44 -07:00
Lewis Sanchez
5e48cb99e1 Fixes bug around sorting equal and unequal properties (#20702)
* Fixes bug around sorting equal and unequal properties

* Uses deepClone to deepCopy objects

* Code review changes

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-10-03 23:10:45 -07:00
Lewis Sanchez
f521d7cc63 Query Execution Plan Expensive Operator Highlighting (#20579)
* Boilerplate for new context menu options

* Enables checkmarks for expensive operator context menu actions

* Updates azdataGraph version to 0.0.44

* Adds clearing logic to actions and retrieves additional info from nodes

* Removes unnecessary actions that aren't supported by other providers

* Finishes setting up the rest of the context menu actions

* Corrects context menu action label

* Defines new widget type for finding expensive operations

* Adds TODO for class icon name

* Creates action to open the expensive operation widget

* Adds escape and enter key shortcuts to findExpensiveOperation widget

* Styles find expensive operation widget

* Corrects class name for finding expensive operator action

* Corrects import statement.

* Code clean up

* Bumps azdataGraph version to 0.0.45

* Adds an info box for when a metric doesn't find any nodes

* Adds label to find expensive operator widget

* Invokes dispose when widget controller removes widget

* Implements disposable in all execution plan widgets.

* Adds off action to clear highlighting

* Adds a default setting and default prompt for highlighting metric

* Fixes not all code paths return error

* Removes shortcut key from text for widget actions

* Adds enum description

* Removes added dictionary type, and renames class name

* Removes unnecessary null checks

* Removes cost metric dictionary and adds corresponding properties

* Code review changes

* Removes incorrectly implemented key down event for widget.

* Renames widget and action class names for highlighting expensive ops

* File rename

* Cleans up labels to better reflect highlight action

* Removes hardcoded button width style and sets it to auto

* More clean up

* Clean up import statement

* Code review changes

* Drop down list only shows available metrics

* Updates highlight expensive operation icon

* Update STS version
2022-10-03 12:32:39 -07:00
Charles Gagnon
85dc506a3c Add AuthenticationType enum to typings (#20699)
* Add AuthenticationType enum to typings

* fix

* const

* Add comments

* fix comment

* remove unused
2022-09-30 16:49:36 -07:00
Aasim Khan
2a9c0a6935 Fixing filter stylings (#20685) 2022-09-30 10:00:13 -07:00
Lewis Sanchez
7c83739c25 Reorganized Execution Plan Comparison Properties View (#20673)
* Adds summary view to comparison properties view

* Equal rows are collapsed at the bottom of the properties view window

* Variable rename

* Variable rename

* Adds row header for equal properties.

* Adds middle column with diff icon to comparison properties table

* Resolves hygiene issue

* Code review changes

* Fixes undefined error bug

* Adds styles to less than and greater than codicon's

* Changes equivalent properties collapsed header

* Removes unnecessary check

* Integrates alphabetical and importance sorting to equivalency sorting
2022-09-29 13:53:10 -07:00
Aasim Khan
fd8993134f Execution Plan Filtering and UI improvements (#20631)
* Fixing execution plan stuff

* Adding filter to top operations

* Flipped custom zoom icon

* changing keys

* Moving constants to a file

* Search properties

* Making logic concise
2022-09-23 12:57:30 -07:00
Lewis Sanchez
12c5aa0f80 Fixes incorrect operation label when plans are oriented vertically and node selection changes. (#20630)
* Fixes incorrect label when plans are vertical

* Code review changes.

* Adds helper methods to get localized strings

* Helper functions moved to module level

* Renames fields from top and bottom to primary and secondary
2022-09-21 10:40:09 -07:00
Charles Gagnon
509e4b0509 Move legacy tree from vs to sql (#20622)
* Move legacy tree from vs to sql

* fix tests

* exemption

* Fix lint
2022-09-19 15:19:40 -07:00
Alan Ren
b25b591994 dashboard refresh fix (#20596) 2022-09-12 20:34:02 -07:00
Aasim Khan
3f6f6ed07b Changing property header row styling for execution plan properties (#20594) 2022-09-12 17:20:16 -07:00
Alan Ren
6015c8e2f4 handle unsupported connections in OE/Recent connections view (#20588)
* handle unknown provider in OE

* more update

* add comment

* test
2022-09-12 11:48:08 -07:00
Alan Ren
be8bf7fcdc handle unsupported connection provider (#20577)
* handle unknown connection provider

* fix error
2022-09-09 14:14:33 -07:00
Jordan Hays
982c242301 Remove irrelevant context menu options from ledger objects in OE (#20571)
* fixing icons for new ledger object SubTypes

* removing irrelevant context menu options from ledger objects in OE

* aligning LedgerDropped subtype context key specifically with the Table NodeType context key
2022-09-09 08:50:57 -07:00
Charles Gagnon
649c98c016 ServerInfoContextKey instead of MssqlNodeContextKey for OE items (#20563)
* ServerInfoContextKey instead of MssqlNodeContextKey for OE items

* add comment
2022-09-08 09:32:20 -07:00
Aasim Khan
7857e5946f New azdata graph layout (#20451)
* Updated contracts

* Adding latest azdataGraph update

* Updating graph lib
2022-08-24 12:09:17 -07:00
Cory Rivera
1a094ba6a9 Clear invalid taskbar actions when changing notebook providers. (#20446) 2022-08-24 12:01:41 -07:00
Lewis Sanchez
7de5ee0427 Adds functionality to open execution plans from DB tables and DMVs. (#20377)
* Adds functionality to open execution plans from DB tables and DMVs.

* Code review changes

* Renames method to getProviderFromUri
2022-08-17 19:24:23 -07:00
Cory Rivera
ff05a4e25d Use a "Text Size" label for heading dropdown. (#20319) 2022-08-12 14:17:40 -07:00
Alan Ren
c663493690 properly handle copy request (#20320) 2022-08-11 21:22:19 -07:00
Aasim Khan
a7a337f063 Adding properties grid enhancements in execution plan (#20208)
* init push

* Fixing properties in plan comparison

* Add long Text Cell viewer

* Disabling auto edit by default

* Removing text editor
2022-08-11 11:22:12 -07:00
Alan Ren
9ec68087ac allow database name to be empty (#20221)
* allow database to be empty

* test changes

* fix import

* fix test cases

* comment
2022-08-11 10:26:55 -07:00
Alan Ren
2d14665208 announce query execution events (#20285) 2022-08-09 20:23:17 -07:00
Alan Ren
4096037167 fix query results view issue (#20234) 2022-08-03 10:45:33 -07:00
Alan Ren
f72dbccc52 no-op is the object is disposed (#20236) 2022-08-03 10:45:11 -07:00
Cory Rivera
453f8e5525 Set cell preview mode when toggling edit mode. (#20220)
* Also fix leftover settings changes in markdown smoke test.
2022-08-03 09:36:24 -07:00
Alan Ren
4d1be1e288 fix menu item not showing up for non-English languages (#20224)
* new object type property

* vbump sts

* fix azure tree

* mark as optional

* Fix test errors
2022-08-02 13:39:20 -07:00
Alan Ren
6be1420220 do not run query in multi-selection mode (#20213)
* do not run query in multi-selection mode

* fix test

* fix more tests
2022-07-30 14:29:32 -07:00
Alan Ren
67ecd6d3d9 fix the grid goes blank issue (#20209) 2022-07-29 18:12:02 -07:00
Lewis Sanchez
9fc251259c Adds Ability to Search for Nodes in Compared Execution Plans (#20168)
* Adds find node button to comparison plans.

* Can search multiple nodes (improve widget UI and initialization)

* Adjusts how second plan is added to the node search widget

* Adds styling to the find node action bar

* Removes unused code

* Minor clean up

* Cleans up CSS redundancy

* Adjusts property names according to access specifiers

* Corrects find node behavior to match SSMS

* Dependency injects instantiation service

* Adds additional property to telemetry event.

* Adds undefined to getter return signatures for plans

* Adds checks around active execution plan properties

* Code review change

* Code review changes
2022-07-28 14:14:32 -07:00
Alan Ren
bb4b00a25a fix recent closed (#20188) 2022-07-27 18:44:08 -07:00
Aasim Khan
518bb33a2f Adding plan tree to execution plan (#20158)
* Adding plan tree

* Fixing localization keys

* Removed whitespace
2022-07-26 14:30:46 -07:00
Cory Rivera
c2be6447b5 Prevent cell's edit mode from being incorrectly cleared when a text component is initialized. (#20120) 2022-07-22 10:22:56 -07:00
Lewis Sanchez
43e7e35df5 Update azdataGraph version to 0.0.37 (#20140)
* Updates azdataGraph version to 0.0.37

* Enables collapse/expand node with highlight resize
2022-07-21 16:15:54 -07:00
Charles Gagnon
1367f29a8a Fix null ref in contributed tree views (#20138) 2022-07-21 12:26:22 -07:00
Maddy
7dd36ae7b4 fix: image disappear issue (#20039)
* check if base64 value is from image tag

* add test

* check image regex

* add comment

* update comment
2022-07-20 13:58:49 -07:00
Aasim Khan
67637a41f5 Making better ep highlights (#20055) 2022-07-15 15:31:01 -07:00
Charles Gagnon
ba1f4db745 Make createEditorInput async (#20038) 2022-07-14 19:39:52 -07:00
Cory Rivera
e58aa90ac0 Set dotnet_interactive cell metadata when converting cell into JSON. (#20044) 2022-07-14 16:47:14 -07:00
Lewis Sanchez
e5b0e0255c Updates azdataGraph version to 0.0.33 (#20028) 2022-07-13 18:59:22 -07:00
Lewis Sanchez
8f93fd9d09 Updates Actual Execution Plan button icon (#20018) 2022-07-12 17:14:49 -07:00
Chris LaFreniere
78b5e52bf7 re-enable notebook outputprocessor tests (#20000) 2022-07-12 10:11:35 -07:00
Aasim Khan
980a233aad Sorting top by cost initially (#19998) 2022-07-11 21:34:38 -07:00
Lewis Sanchez
e25a9574a7 Bump azdataGraph version to 0.0.32 (#19954)
* Update azdataGraph version to 0.0.31

* Adds icons

* Bumps azdataGraph version to 0.0.32

* Removes whitespace

* Uses icon that better adapts to color theme changes.

* Disables collapse for execution plans in plan comparison editor view
2022-07-11 21:26:34 -07:00
Aasim Khan
53a0388858 Deleting old query plan code (#19996) 2022-07-11 19:14:47 -07:00