Hide tabs on reexecute (#2624)

* add logic to hide tabs when a query rerun is executed

* remove double entry in the map

extensions/account-provider-azure/src/account-provider/azureAccountProviderService.ts

@@ -20,7 +20,7 @@ let localize = nls.loadMessageBundle();
 
 export class AzureAccountProviderService implements vscode.Disposable {
 	// CONSTANTS ///////////////////////////////////////////////////////////////
-	private static CommandClearTokenCache = 'accounts.clearTokenCache';
+	private static CommandClearTokenCache = 'accounts.azure.clearTokenCache';
 	private static ConfigurationSection = 'accounts.azure';
 	private static CredentialNamespace = 'azureAccountProviderCredentials';
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "sqlops",
-  "version": "0.33.7",
+  "version": "0.32.9",
   "distro": "8c3e97e3425cc9814496472ab73e076de2ba99ee",
   "author": {
     "name": "Microsoft Corporation"

src/sql/parts/jobManagement/views/jobManagementView.ts

@@ -70,7 +70,8 @@ export abstract class JobManagementView extends TabChild implements AfterContent
 	abstract onFirstVisible();
 
 	protected openContextMenu(event): void {
-		let rowIndex = event.cell.row;
+		let grid = this._table.grid;
+		let rowIndex = grid.getCellFromEvent(event).row;
 
 		let targetObject = this.getCurrentTableObject(rowIndex);
 		let actions = this.getTableActions();

src/sql/parts/modelComponents/markdown.css

@@ -100,11 +100,12 @@ modelview-dom-component img {
 	max-height: 100%;
 }
 
-modelview-dom-component a, modelview-dom-component a:link{
+modelview-dom-component a, a:link{
 	text-decoration: none;
+	color: rgb(0, 0, 238) !important;
 }
 
-modelview-dom-component a:hover, modelview-dom-component a:link {
+modelview-dom-component a:hover, a:link {
 	text-decoration: underline;
 }
 

src/sql/parts/query/editor/charting/chartView.ts

@@ -12,13 +12,12 @@ import { Insight } from './insights/insight';
 import QueryRunner from 'sql/parts/query/execution/queryRunner';
 import { IInsightData } from 'sql/parts/dashboard/widgets/insights/interfaces';
 import { ChartOptions, IChartOption, ControlType } from './chartOptions';
-import { Extensions, IInsightRegistry } from 'sql/platform/dashboard/common/insightRegistry';
 import { Checkbox } from 'sql/base/browser/ui/checkbox/checkbox';
 import { IInsightOptions } from './insights/interfaces';
 import { CopyAction, SaveImageAction, CreateInsightAction, IChartActionContext } from './actions';
 import { Taskbar } from 'sql/base/browser/ui/taskbar/taskbar';
 import { ChartType } from 'sql/parts/dashboard/widgets/insights/views/charts/interfaces';
-import { Registry } from 'vs/platform/registry/common/platform';
+
 import { Dimension, $, getContentHeight, getContentWidth } from 'vs/base/browser/dom';
 import { SelectBox } from 'vs/base/browser/ui/selectBox/selectBox';
 import { IContextViewService, IContextMenuService } from 'vs/platform/contextview/browser/contextView';
@@ -41,8 +40,6 @@ declare class Proxy {
 	constructor(object, handler);
 }
 
-const insightRegistry = Registry.as<IInsightRegistry>(Extensions.InsightContribution);
-
 export class ChartView implements IPanelView {
 	private insight: Insight;
 	private _queryRunner: QueryRunner;
@@ -126,7 +123,6 @@ export class ChartView implements IPanelView {
 			}
 		}) as IInsightOptions;
 
-		ChartOptions.general[0].options = insightRegistry.getAllIds();
 		ChartOptions.general.map(o => {
 			this.createOption(o, generalControls);
 		});
@@ -319,7 +315,7 @@ export class ChartView implements IPanelView {
 				});
 				setFunc = (val: string) => {
 					if (!isUndefinedOrNull(val)) {
-						numberInput.value = val;
+						input.value = val;
 					}
 				};
 				this.optionDisposables.push(attachInputBoxStyler(numberInput, this._themeService));
@@ -334,7 +330,7 @@ export class ChartView implements IPanelView {
 		this._state = val;
 		if (this.state.options) {
 			for (let key in this.state.options) {
-				if (this.state.options.hasOwnProperty(key) && this.optionMap[key]) {
+				if (this.state.options.hasOwnProperty(key)) {
 					this.options[key] = this.state.options[key];
 					this.optionMap[key].set(this.state.options[key]);
 				}

src/sql/parts/query/editor/messagePanel.ts

@@ -29,7 +29,6 @@ import { isArray, isUndefinedOrNull } from 'vs/base/common/types';
 import { IDisposable, dispose } from 'vs/base/common/lifecycle';
 import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 import { IEditor } from 'vs/editor/common/editorCommon';
-import { QueryInput } from 'sql/parts/query/common/queryInput';
 
 export interface IResultMessageIntern extends IResultMessage {
 	id?: string;
@@ -303,8 +302,14 @@ export class MessageController extends WorkbenchTreeController {
 		if (element.selection) {
 			let selection: ISelectionData = element.selection;
 			// this is a batch statement
-			let input = this.workbenchEditorService.activeEditor as QueryInput;
+			let control = this.workbenchEditorService.activeControl.getControl() as IEditor;
-			input.updateSelection(selection);
+			control.setSelection({
+				startColumn: selection.startColumn + 1,
+				endColumn: selection.endColumn + 1,
+				endLineNumber: selection.endLine + 1,
+				startLineNumber: selection.startLine + 1
+			});
+			control.focus();
 		}
 
 		return true;

src/sql/workbench/common/actions.contribution.ts

@@ -32,7 +32,7 @@ Registry.as<IConfigurationRegistry>(ConfigExtensions.Configuration).registerConf
 	'properties': {
 		'workbench.enablePreviewFeatures': {
 			'type': 'boolean',
-			'default': undefined,
+			'default': true,
 			'description': nls.localize('previewFeatures.configEnable', 'Enable unreleased preview features')
 		}
 	}

src/sql/workbench/electron-browser/enablePreviewFeatures.ts

@@ -27,44 +27,46 @@ export class EnablePreviewFeatures implements IWorkbenchContribution {
 		@ITelemetryService telemetryService: ITelemetryService,
 		@IConfigurationService configurationService: IConfigurationService
 	) {
-		let previewFeaturesEnabled = configurationService.getValue('workbench')['enablePreviewFeatures'];
+		return;
-		if (previewFeaturesEnabled || storageService.get(EnablePreviewFeatures.ENABLE_PREVIEW_FEATURES_SHOWN)) {
-			return;
-		}
-		Promise.all([
-			windowService.isFocused(),
-			windowsService.getWindowCount()
-		]).then(([focused, count]) => {
-			if (!focused && count > 1) {
-				return null;
-			}
-			configurationService.updateValue('workbench.enablePreviewFeatures', false);
 
-			const enablePreviewFeaturesNotice = localize('enablePreviewFeatures.notice', "Would you like to enable preview features?");
+		// let previewFeaturesEnabled = configurationService.getValue('workbench')['enablePreviewFeatures'];
-			notificationService.prompt(
+		// if (previewFeaturesEnabled || storageService.get(EnablePreviewFeatures.ENABLE_PREVIEW_FEATURES_SHOWN)) {
-				Severity.Info,
+		// 	return;
-				enablePreviewFeaturesNotice,
+		// }
-				[{
+		// Promise.all([
-					label: localize('enablePreviewFeatures.yes', "Yes"),
+		// 	windowService.isFocused(),
-					run: () => {
+		// 	windowsService.getWindowCount()
-						configurationService.updateValue('workbench.enablePreviewFeatures', true);
+		// ]).then(([focused, count]) => {
-						storageService.store(EnablePreviewFeatures.ENABLE_PREVIEW_FEATURES_SHOWN, true);
+		// 	if (!focused && count > 1) {
-					}
+		// 		return null;
-				}, {
+		// 	}
-					label: localize('enablePreviewFeatures.no', "No"),
+		// 	configurationService.updateValue('workbench.enablePreviewFeatures', false);
-					run: () => {
+
-						configurationService.updateValue('workbench.enablePreviewFeatures', false);
+		// 	const enablePreviewFeaturesNotice = localize('enablePreviewFeatures.notice', "Would you like to enable preview features?");
-					}
+		// 	notificationService.prompt(
-				}, {
+		// 		Severity.Info,
-					label: localize('enablePreviewFeatures.never', "No, don't show again"),
+		// 		enablePreviewFeaturesNotice,
-					run: () => {
+		// 		[{
-						configurationService.updateValue('workbench.enablePreviewFeatures', false);
+		// 			label: localize('enablePreviewFeatures.yes', "Yes"),
-						storageService.store(EnablePreviewFeatures.ENABLE_PREVIEW_FEATURES_SHOWN, true);
+		// 			run: () => {
-					},
+		// 				configurationService.updateValue('workbench.enablePreviewFeatures', true);
-					isSecondary: true
+		// 				storageService.store(EnablePreviewFeatures.ENABLE_PREVIEW_FEATURES_SHOWN, true);
-				}]
+		// 			}
-			);
+		// 		}, {
-		})
+		// 			label: localize('enablePreviewFeatures.no', "No"),
-			.then(null, onUnexpectedError);
+		// 			run: () => {
+		// 				configurationService.updateValue('workbench.enablePreviewFeatures', false);
+		// 			}
+		// 		}, {
+		// 			label: localize('enablePreviewFeatures.never', "No, don't show again"),
+		// 			run: () => {
+		// 				configurationService.updateValue('workbench.enablePreviewFeatures', false);
+		// 				storageService.store(EnablePreviewFeatures.ENABLE_PREVIEW_FEATURES_SHOWN, true);
+		// 			},
+		// 			isSecondary: true
+		// 		}]
+		// 	);
+		// })
+		// 	.then(null, onUnexpectedError);
 	}
 }