mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-19 17:22:48 -05:00
ebc208cacd
* Fixed #4181 and #4167 The problems are: - When change Kernel, setProviderIdForKernel switches Kernel first. So when we switch kernel across provider for exmple from PySpark3 to SQL. The Kernel is set SQL already in ClientSession.changeKernel. Then we lost oldKernel info. The fix is cache the old session in model before switch and use it to get the correct context - SQL Kenerl could make mulitple connects from "Add new connection". While we didn't track them, those connections didn't close properly when close the notebook The fix is saving the connections made from "Add new connection" in model. and close them and activeConnection when close notebook Problem is not solved yet in this PR: - Didn't shutdown Jupytper when swich kernel from spark kernel to SQL.