ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-12 02:58:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Alex/fixforretrysleeping (#1669)

Browse Source 
* added getResponseConnect function

* added WIP changes to getResponseConnect

* changed retry number to be smaller number

* added comments and changed max tries

* added changes

* added more changes

* added notification class

* made changes to fix

* added null fix
This commit is contained in:
Alex Ma
2022-09-06 13:42:43 -07:00
committed by GitHub
parent 8f26a20950
commit 00ad16e796
1 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
View File

@@ -35,6 +35,8 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
private const string SqlAzureEdition = "SQL Azure"; private const string SqlAzureEdition = "SQL Azure";
public const int MaxTolerance = 2 * 60; // two minutes - standard tolerance across ADS for AAD tokens public const int MaxTolerance = 2 * 60; // two minutes - standard tolerance across ADS for AAD tokens
public const int MaxServerlessReconnectTries = 5; // Max number of tries to wait for a serverless database to start up when its paused before giving up.
/// <summary> /// <summary>
/// Singleton service instance /// Singleton service instance
/// </summary> /// </summary>
@@ -377,7 +379,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
} }
// Try to open a connection with the given ConnectParams // Try to open a connection with the given ConnectParams
ConnectionCompleteParams response = await TryOpenConnection(connectionInfo, connectionParams); ConnectionCompleteParams? response = await this.TryOpenConnectionWithRetry(connectionInfo, connectionParams);
if (response != null) if (response != null)
{ {
return response; return response;
@@ -400,6 +402,33 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
return completeParams; return completeParams;
} }
private async Task<ConnectionCompleteParams?> TryOpenConnectionWithRetry(ConnectionInfo connectionInfo, ConnectParams connectionParams)
{
int counter = 0;
ConnectionCompleteParams? response = null;
while (counter <= MaxServerlessReconnectTries)
{
// The OpenAsync function used in TryOpenConnection does not retry when a database is sleeping.
// SqlClient will be implemented at a later time, which will have automatic retries.
response = await TryOpenConnection(connectionInfo, connectionParams);
// If a serverless database is sleeping, it will return this error number and will need to be retried.
// See here for details: https://docs.microsoft.com/en-us/azure/azure-sql/database/serverless-tier-overview?view=azuresql#connectivity
if (response?.ErrorNumber == 40613)
{
counter++;
if(counter != MaxServerlessReconnectTries) {
Logger.Information($"Database for connection {connectionInfo.OwnerUri} is paused, retrying connection. Attempt #{counter}");
}
}
else
{
// Every other response, we can stop.
break;
}
}
return response;
}
private void TryCloseConnectionTemporaryConnection(ConnectParams connectionParams, ConnectionInfo connectionInfo) private void TryCloseConnectionTemporaryConnection(ConnectParams connectionParams, ConnectionInfo connectionInfo)
{ {
try try