From 03a99e48dc72b60a9ed7b94f17ceb4d3ec310bc2 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com> Date: Thu, 6 Jul 2023 22:19:17 -0700 Subject: [PATCH] Close connection explicitly on rename (#2129) --- .../ObjectManagement/ObjectTypeHandler.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypeHandler.cs b/src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypeHandler.cs index acc94412..6dc254fc 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypeHandler.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypeHandler.cs @@ -74,6 +74,11 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement throw new Exception(SR.ObjectNotRenamable(objectUrn)); } } + // If connection is not instantiated in the using statement, it can be leaked here, therefore close explicitly. + if(serverConnection.SqlConnectionObject.State == System.Data.ConnectionState.Open) + { + serverConnection.SqlConnectionObject.Close(); + } return Task.CompletedTask; }