From 0fcc6dc5cfb2c7996b2f5483143bfd004b8b6610 Mon Sep 17 00:00:00 2001
From: Alan Ren <alanren@microsoft.com>
Date: Fri, 7 Jan 2022 10:57:16 -0800
Subject: [PATCH] rename the table designer requests (#1356)

* rename the table designer requests

* rename request
---
 ...ortRequest.cs => GeneratePreviewReportRequest.cs} |  6 +++---
 ...oRequest.cs => InitializeTableDesignerRequest.cs} |  0
 ...angesRequest.cs => PublishTableChangesRequest.cs} |  8 ++++----
 .../TableDesigner/TableDesignerService.cs            | 12 ++++++------
 4 files changed, 13 insertions(+), 13 deletions(-)
 rename src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/{GenerateReportRequest.cs => GeneratePreviewReportRequest.cs} (70%)
 rename src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/{GetTableDesignerInfoRequest.cs => InitializeTableDesignerRequest.cs} (100%)
 rename src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/{SaveTableChangesRequest.cs => PublishTableChangesRequest.cs} (58%)

diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GenerateReportRequest.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
similarity index 70%
rename from src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GenerateReportRequest.cs
rename to src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
index 0056abd2..977da090 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GenerateReportRequest.cs
+++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
@@ -9,13 +9,13 @@ using Microsoft.SqlTools.Utility;
 namespace Microsoft.SqlTools.ServiceLayer.TableDesigner.Contracts
 {
     /// <summary>
-    /// The service request to generate report for the changes.
+    /// The service request to generate preview report describing the changes.
     /// </summary>
-    public class GenerateReportRequest
+    public class GeneratePreviewReportRequest
     {
         /// <summary>
         /// Request definition
         /// </summary>
-        public static readonly RequestType<TableInfo, string> Type = RequestType<TableInfo, string>.Create("tabledesigner/report");
+        public static readonly RequestType<TableInfo, string> Type = RequestType<TableInfo, string>.Create("tabledesigner/generatepreviewreport");
     }
 }
diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GetTableDesignerInfoRequest.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/InitializeTableDesignerRequest.cs
similarity index 100%
rename from src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GetTableDesignerInfoRequest.cs
rename to src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/InitializeTableDesignerRequest.cs
diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/SaveTableChangesRequest.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/PublishTableChangesRequest.cs
similarity index 58%
rename from src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/SaveTableChangesRequest.cs
rename to src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/PublishTableChangesRequest.cs
index 3a77e52a..23c811c6 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/SaveTableChangesRequest.cs
+++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/PublishTableChangesRequest.cs
@@ -8,18 +8,18 @@ using Microsoft.SqlTools.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.TableDesigner.Contracts
 {
-    public class SaveTableChangesResponse
+    public class PublishTableChangesResponse
     {
     }
 
     /// <summary>
-    /// The service request to save the changes.
+    /// The service request to publish the changes.
     /// </summary>
-    public class SaveTableChangesRequest
+    public class PublishTableChangesRequest
     {
         /// <summary>
         /// Request definition
         /// </summary>
-        public static readonly RequestType<TableInfo, SaveTableChangesResponse> Type = RequestType<TableInfo, SaveTableChangesResponse>.Create("tabledesigner/save");
+        public static readonly RequestType<TableInfo, PublishTableChangesResponse> Type = RequestType<TableInfo, PublishTableChangesResponse>.Create("tabledesigner/publish");
     }
 }
diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
index 6f728101..7a43f410 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
+++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
@@ -53,9 +53,9 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
             this.ServiceHost = serviceHost;
             this.ServiceHost.SetRequestHandler(InitializeTableDesignerRequest.Type, HandleInitializeTableDesignerRequest);
             this.ServiceHost.SetRequestHandler(ProcessTableDesignerEditRequest.Type, HandleProcessTableDesignerEditRequest);
-            this.ServiceHost.SetRequestHandler(SaveTableChangesRequest.Type, HandleSaveTableChangesRequest);
+            this.ServiceHost.SetRequestHandler(PublishTableChangesRequest.Type, HandlePublishTableChangesRequest);
             this.ServiceHost.SetRequestHandler(GenerateScriptRequest.Type, HandleGenerateScriptRequest);
-            this.ServiceHost.SetRequestHandler(GenerateReportRequest.Type, HandleGenerateReportRequest);
+            this.ServiceHost.SetRequestHandler(GeneratePreviewReportRequest.Type, HandleGeneratePreviewReportRequest);
             this.ServiceHost.SetRequestHandler(DisposeTableDesignerRequest.Type, HandleDisposeTableDesignerRequest);
         }
         private Task HandleRequest<T>(RequestContext<T> requestContext, Func<Task> action)
@@ -124,13 +124,13 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
             });
         }
 
-        private Task HandleSaveTableChangesRequest(TableInfo tableInfo, RequestContext<SaveTableChangesResponse> requestContext)
+        private Task HandlePublishTableChangesRequest(TableInfo tableInfo, RequestContext<PublishTableChangesResponse> requestContext)
         {
-            return this.HandleRequest<SaveTableChangesResponse>(requestContext, async () =>
+            return this.HandleRequest<PublishTableChangesResponse>(requestContext, async () =>
             {
                 var tableDesigner = this.GetTableDesigner(tableInfo);
                 tableDesigner.CommitChanges();
-                await requestContext.SendResult(new SaveTableChangesResponse());
+                await requestContext.SendResult(new PublishTableChangesResponse());
             });
         }
 
@@ -144,7 +144,7 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
             });
         }
 
-        private Task HandleGenerateReportRequest(TableInfo tableInfo, RequestContext<string> requestContext)
+        private Task HandleGeneratePreviewReportRequest(TableInfo tableInfo, RequestContext<string> requestContext)
         {
             return this.HandleRequest<string>(requestContext, async () =>
             {