ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 18:47:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixing a notebook history bug in SQL Agent (#1199)

Browse Source 
* Added a leading 0 to notebook history runtimes

* Fixing comment

* Fix for getting run date and time for notebook jobs in a proper format - Try2

* Reverting back to previous query
This commit is contained in:
Aasim Khan
2021-04-28 16:52:24 -07:00
committed by GitHub
parent 6a45865f3a
commit 10c24aaeb3
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Microsoft.SqlTools.ServiceLayer/Agent/AgentService.cs
View File

@@ -1551,8 +1551,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent
DataTable materializedNotebookTable = await AgentNotebookHelper.GetAgentNotebookHistories(connInfo, jobId, targetDatabase); DataTable materializedNotebookTable = await AgentNotebookHelper.GetAgentNotebookHistories(connInfo, jobId, targetDatabase);
foreach (DataRow materializedNotebookRow in materializedNotebookTable.Rows) foreach (DataRow materializedNotebookRow in materializedNotebookTable.Rows)
{ {
string materializedRunDateTime = materializedNotebookRow["run_date"].ToString() + materializedNotebookRow["run_time"].ToString(); notebookHistoriesDict.Add(materializedNotebookRow["job_runtime"].ToString(), materializedNotebookRow);
notebookHistoriesDict.Add(materializedRunDateTime, materializedNotebookRow);
} }
// adding notebook information to job histories // adding notebook information to job histories

5
src/Microsoft.SqlTools.ServiceLayer/Agent/Jobs/AgentNotebookHelper.cs
View File

@@ -258,12 +258,11 @@ namespace Microsoft.SqlTools.ServiceLayer.Agent
@" @"
SELECT SELECT
materialized_id, materialized_id,
run_time,
run_date,
notebook_error, notebook_error,
pin, pin,
notebook_name, notebook_name,
is_deleted is_deleted,
FORMAT(msdb.dbo.agent_datetime(run_date, run_time), 'yyyyMMddHHmmss') as job_runtime
FROM FROM
notebooks.nb_materialized notebooks.nb_materialized
WHERE job_id = @jobId"; WHERE job_id = @jobId";