mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-18 01:25:41 -05:00
Isolate Shared Test Code (#252)
The goal of this make sure that test code is correctly organized to ensure that test suites aren't dependent on each other.
* UnitTests get their own project now (renaming Microsoft.SqlTools.ServiceLayer.Test to Microsoft.SqlTools.ServiceLayer.UnitTests) which is about 90% of the changes to the files.
* IntegrationTests no longer depends on UnitTests, only Test.Common
* Any shared components from TestObjects that spins up a "live" connection has been moved to IntegrationTests Utility/LiveConnectionHelper.cs
* The dictionary-based mock file stream factory has been moved to Test.Common since it is used by UnitTests and IntegrationTests
* Added a overload that doesn't take a dictionary for when we don't care about monitoring the storage (about 90% of the time)
* The RunIf* wrapper methods have been moved to Test.Common
* OwnerUri and StandardQuery constants have been moved to Test.Common Constants file
* Updating to latest SDK version available at https://www.microsoft.com/net/core#windowscmd
* Moving unit tests to unit test folder
* Changing namespaces to UnitTests
* Moving some constants and shared functionality into common project, making the UnitTests reference it
* Unit tests are working!
* Integration tests are working
* Updating automated test runs
* Fixing one last broken unit test
* Exposing internals for other projects
* Moving edit data tests to UnitTest project
* Applying refactor fixes to unit tests
* Fixing flaky test that wasn't awaiting completion
This commit is contained in:
@@ -0,0 +1,92 @@
|
||||
//
|
||||
// Copyright (c) Microsoft. All rights reserved.
|
||||
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
||||
//
|
||||
|
||||
using Microsoft.SqlTools.ServiceLayer.Hosting.Protocol;
|
||||
using Microsoft.SqlTools.ServiceLayer.QueryExecution;
|
||||
using Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts;
|
||||
using Microsoft.SqlTools.ServiceLayer.SqlContext;
|
||||
using Newtonsoft.Json.Linq;
|
||||
using Xunit;
|
||||
|
||||
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.QueryExecution
|
||||
{
|
||||
public class SettingsTests
|
||||
{
|
||||
[Fact]
|
||||
public void ValidateQueryExecuteDefaults()
|
||||
{
|
||||
// If: I create a new settings object
|
||||
var sqlToolsSettings = new SqlToolsSettings();
|
||||
|
||||
// Then: The default values should be as expected
|
||||
Assert.Equal("GO", sqlToolsSettings.QueryExecutionSettings.BatchSeparator);
|
||||
Assert.Equal(ushort.MaxValue, sqlToolsSettings.QueryExecutionSettings.MaxCharsToStore);
|
||||
Assert.Equal(2*1024*1024, sqlToolsSettings.QueryExecutionSettings.MaxXmlCharsToStore);
|
||||
Assert.False(sqlToolsSettings.QueryExecutionSettings.ExecutionPlanOptions.IncludeActualExecutionPlanXml);
|
||||
Assert.False(sqlToolsSettings.QueryExecutionSettings.ExecutionPlanOptions.IncludeEstimatedExecutionPlanXml);
|
||||
Assert.True(sqlToolsSettings.QueryExecutionSettings.DisplayBitAsNumber);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateSettingsParsedFromJson()
|
||||
{
|
||||
// NOTE: Only testing displayBitAsNumber for now because it is the only one piped through
|
||||
const string settingsJson = @"{"
|
||||
+ @"""params"": {"
|
||||
+ @"""mssql"": {"
|
||||
+ @"""query"": {"
|
||||
+ @"displayBitAsNumber: false"
|
||||
+ @"}"
|
||||
+ @"}"
|
||||
+ @"}"
|
||||
+ @"}";
|
||||
|
||||
// If: I parse the settings JSON object
|
||||
JObject message = JObject.Parse(settingsJson);
|
||||
JToken messageParams;
|
||||
Assert.True(message.TryGetValue("params", out messageParams));
|
||||
SqlToolsSettings sqlToolsSettings = messageParams.ToObject<SqlToolsSettings>();
|
||||
|
||||
// Then: The values defined in the JSON should propagate to the setting object
|
||||
Assert.False(sqlToolsSettings.QueryExecutionSettings.DisplayBitAsNumber);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ValidateSettingsObjectUpdates()
|
||||
{
|
||||
// If: I update a settings object with a new settings object
|
||||
var qes = new QueryExecutionService(null, null);
|
||||
SqlToolsSettings settings = new SqlToolsSettings()
|
||||
{
|
||||
SqlTools = new SqlToolsSettingsValues
|
||||
{
|
||||
QueryExecutionSettings = new QueryExecutionSettings
|
||||
{
|
||||
DisplayBitAsNumber = false,
|
||||
MaxXmlCharsToStore = 1,
|
||||
MaxCharsToStore = 1,
|
||||
ExecutionPlanOptions = new ExecutionPlanOptions
|
||||
{
|
||||
IncludeActualExecutionPlanXml = true,
|
||||
IncludeEstimatedExecutionPlanXml = true
|
||||
},
|
||||
BatchSeparator = "YO"
|
||||
}
|
||||
}
|
||||
|
||||
};
|
||||
qes.UpdateSettings(settings, null, new EventContext());
|
||||
|
||||
// Then: The settings object should match what it was updated to
|
||||
Assert.False(qes.Settings.QueryExecutionSettings.DisplayBitAsNumber);
|
||||
Assert.True(qes.Settings.QueryExecutionSettings.ExecutionPlanOptions.IncludeActualExecutionPlanXml);
|
||||
Assert.True(qes.Settings.QueryExecutionSettings.ExecutionPlanOptions.IncludeEstimatedExecutionPlanXml);
|
||||
Assert.Equal(1, qes.Settings.QueryExecutionSettings.MaxCharsToStore);
|
||||
Assert.Equal(1, qes.Settings.QueryExecutionSettings.MaxXmlCharsToStore);
|
||||
Assert.Equal("YO", qes.Settings.QueryExecutionSettings.BatchSeparator);
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user