mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-21 09:35:39 -05:00
Isolate Shared Test Code (#252)
The goal of this make sure that test code is correctly organized to ensure that test suites aren't dependent on each other.
* UnitTests get their own project now (renaming Microsoft.SqlTools.ServiceLayer.Test to Microsoft.SqlTools.ServiceLayer.UnitTests) which is about 90% of the changes to the files.
* IntegrationTests no longer depends on UnitTests, only Test.Common
* Any shared components from TestObjects that spins up a "live" connection has been moved to IntegrationTests Utility/LiveConnectionHelper.cs
* The dictionary-based mock file stream factory has been moved to Test.Common since it is used by UnitTests and IntegrationTests
* Added a overload that doesn't take a dictionary for when we don't care about monitoring the storage (about 90% of the time)
* The RunIf* wrapper methods have been moved to Test.Common
* OwnerUri and StandardQuery constants have been moved to Test.Common Constants file
* Updating to latest SDK version available at https://www.microsoft.com/net/core#windowscmd
* Moving unit tests to unit test folder
* Changing namespaces to UnitTests
* Moving some constants and shared functionality into common project, making the UnitTests reference it
* Unit tests are working!
* Integration tests are working
* Updating automated test runs
* Fixing one last broken unit test
* Exposing internals for other projects
* Moving edit data tests to UnitTest project
* Applying refactor fixes to unit tests
* Fixing flaky test that wasn't awaiting completion
This commit is contained in:
@@ -0,0 +1,144 @@
|
||||
//
|
||||
// Copyright (c) Microsoft. All rights reserved.
|
||||
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
||||
//
|
||||
|
||||
using Microsoft.SqlTools.ServiceLayer.Hosting.Protocol.Serializers;
|
||||
using Newtonsoft.Json.Linq;
|
||||
using Xunit;
|
||||
using HostingMessage = Microsoft.SqlTools.ServiceLayer.Hosting.Protocol.Contracts.Message;
|
||||
|
||||
namespace Microsoft.SqlTools.ServiceLayer.UnitTests.ServiceHost
|
||||
{
|
||||
public class TestMessageContents
|
||||
{
|
||||
public const string SomeFieldValue = "Some value";
|
||||
public const int NumberValue = 42;
|
||||
|
||||
public string SomeField { get; set; }
|
||||
|
||||
public int Number { get; set; }
|
||||
|
||||
public TestMessageContents()
|
||||
{
|
||||
this.SomeField = SomeFieldValue;
|
||||
this.Number = NumberValue;
|
||||
}
|
||||
}
|
||||
|
||||
public class JsonRpcMessageSerializerTests
|
||||
{
|
||||
private IMessageSerializer messageSerializer;
|
||||
|
||||
private const string MessageId = "42";
|
||||
private const string MethodName = "testMethod";
|
||||
private static readonly JToken MessageContent = JToken.FromObject(new TestMessageContents());
|
||||
|
||||
public JsonRpcMessageSerializerTests()
|
||||
{
|
||||
this.messageSerializer = new JsonRpcMessageSerializer();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SerializesRequestMessages()
|
||||
{
|
||||
var messageObj =
|
||||
this.messageSerializer.SerializeMessage(
|
||||
HostingMessage.Request(
|
||||
MessageId,
|
||||
MethodName,
|
||||
MessageContent));
|
||||
|
||||
AssertMessageFields(
|
||||
messageObj,
|
||||
checkId: true,
|
||||
checkMethod: true,
|
||||
checkParams: true);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SerializesEventMessages()
|
||||
{
|
||||
var messageObj =
|
||||
this.messageSerializer.SerializeMessage(
|
||||
HostingMessage.Event(
|
||||
MethodName,
|
||||
MessageContent));
|
||||
|
||||
AssertMessageFields(
|
||||
messageObj,
|
||||
checkMethod: true,
|
||||
checkParams: true);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SerializesResponseMessages()
|
||||
{
|
||||
var messageObj =
|
||||
this.messageSerializer.SerializeMessage(
|
||||
HostingMessage.Response(
|
||||
MessageId,
|
||||
null,
|
||||
MessageContent));
|
||||
|
||||
AssertMessageFields(
|
||||
messageObj,
|
||||
checkId: true,
|
||||
checkResult: true);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SerializesResponseWithErrorMessages()
|
||||
{
|
||||
var messageObj =
|
||||
this.messageSerializer.SerializeMessage(
|
||||
HostingMessage.ResponseError(
|
||||
MessageId,
|
||||
null,
|
||||
MessageContent));
|
||||
|
||||
AssertMessageFields(
|
||||
messageObj,
|
||||
checkId: true,
|
||||
checkError: true);
|
||||
}
|
||||
|
||||
private static void AssertMessageFields(
|
||||
JObject messageObj,
|
||||
bool checkId = false,
|
||||
bool checkMethod = false,
|
||||
bool checkParams = false,
|
||||
bool checkResult = false,
|
||||
bool checkError = false)
|
||||
{
|
||||
JToken token = null;
|
||||
|
||||
Assert.True(messageObj.TryGetValue("jsonrpc", out token));
|
||||
Assert.Equal("2.0", token.ToString());
|
||||
|
||||
if (checkId)
|
||||
{
|
||||
Assert.True(messageObj.TryGetValue("id", out token));
|
||||
Assert.Equal(MessageId, token.ToString());
|
||||
}
|
||||
|
||||
if (checkMethod)
|
||||
{
|
||||
Assert.True(messageObj.TryGetValue("method", out token));
|
||||
Assert.Equal(MethodName, token.ToString());
|
||||
}
|
||||
|
||||
if (checkError)
|
||||
{
|
||||
// TODO
|
||||
}
|
||||
else
|
||||
{
|
||||
string contentField = checkParams ? "params" : "result";
|
||||
Assert.True(messageObj.TryGetValue(contentField, out token));
|
||||
Assert.True(JToken.DeepEquals(token, MessageContent));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user