From 11fef3a5dbae3ff46f350b8cbb6d372edb6441ea Mon Sep 17 00:00:00 2001 From: Hai Cao Date: Fri, 23 Sep 2022 16:44:34 -0700 Subject: [PATCH] [Table Designer] Fix columnstore wording --- .../Localization/sr.resx | 20 +++++----- .../Localization/sr.strings | 20 +++++----- .../Localization/sr.xlf | 40 +++++++++---------- .../ViewModel/ColumnStoreIndexViewModel.cs | 2 +- .../TableDesigner/TableDesignerService.cs | 3 +- 5 files changed, 43 insertions(+), 42 deletions(-) diff --git a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx index e9f081a5..b4ec5e1a 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx +++ b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx @@ -4880,7 +4880,7 @@ The Query Processor estimates that implementing the following index could improv - Name of the column store index + Name of the columnstore index @@ -4888,11 +4888,11 @@ The Query Processor estimates that implementing the following index could improv - Description of the column store index + Description of the columnstore index - Whether the column store index is clustered. + Whether the columnstore index is clustered. @@ -4900,7 +4900,7 @@ The Query Processor estimates that implementing the following index could improv - Filter predicate of the column store index + Filter predicate of the columnstore index @@ -4908,7 +4908,7 @@ The Query Processor estimates that implementing the following index could improv - Columns in this column store index + Columns in this columnstore index @@ -4952,15 +4952,15 @@ The Query Processor estimates that implementing the following index could improv - Column Store Indexes + Columnstore Indexes - Column Store Index + Columnstore Index - New Column Store Index + New Columnstore Index @@ -5301,12 +5301,12 @@ The Query Processor estimates that implementing the following index could improv Parameters: 0 - indexName (string) - Column with name '{0}' has already been added to the non-clustered column store index '{1}'. Row number: {2}. + Column with name '{0}' has already been added to the non-clustered columnstore index '{1}'. Row number: {2}. . Parameters: 0 - columnName (string), 1 - indexName (string), 2 - rowNumber (int) - Non-clustered column store index '{0}' does not have any columns associated with it. + Non-clustered columnstore index '{0}' does not have any columns associated with it. . Parameters: 0 - indexName (string) diff --git a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings index 0945eaa0..fe6ccb2d 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings +++ b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings @@ -2305,14 +2305,14 @@ IndexBucketCountPropertyTitle = Bucket Count HashIndexGroupTitle = Hash Index TableDesignerColumnsDisplayValueTitle = Columns ColumnStoreIndexNamePropertyTitle = Name -ColumnStoreIndexNamePropertyDescription = Name of the column store index +ColumnStoreIndexNamePropertyDescription = Name of the columnstore index ColumnStoreIndexDescriptionPropertyTitle = Description -ColumnStoreIndexDescriptionPropertyDescription = Description of the column store index -ColumnStoreIndexIsClusteredPropertyDescription = Whether the column store index is clustered. +ColumnStoreIndexDescriptionPropertyDescription = Description of the columnstore index +ColumnStoreIndexIsClusteredPropertyDescription = Whether the columnstore index is clustered. ColumnStoreIndexIsClusteredPropertyTitle = Is Clustered -ColumnStoreIndexFilterPredicatePropertyDescription = Filter predicate of the column store index +ColumnStoreIndexFilterPredicatePropertyDescription = Filter predicate of the columnstore index ColumnStoreIndexFilterPredicatePropertyTitle = Filter Predicate -ColumnStoreIndexColumnsPropertyDescription = Columns in this column store index +ColumnStoreIndexColumnsPropertyDescription = Columns in this columnstore index ColumnStoreIndexColumnsGroupTitle = Columns ColumnStoreIndexAddColumn = Add Column ColumnStoreIndexColumnPropertyName = Column @@ -2323,9 +2323,9 @@ TableDesignerGraphTableTypeDescription = Specifies the table type. TableDesignerGraphTableTypeEdge = Edge TableDesignerGraphTableTypeNode = Node TableDesignerGraphTableTypeNone = None -TableDesignerColumnStoreIndexesTableTitle = Column Store Indexes -TableDesignerColumnStoreIndexObjectType = Column Store Index -AddNewColumnStoreIndexLabel = New Column Store Index +TableDesignerColumnStoreIndexesTableTitle = Columnstore Indexes +TableDesignerColumnStoreIndexObjectType = Columnstore Index +AddNewColumnStoreIndexLabel = New Columnstore Index TableDesignerEdgeConstraintsTabTitle = Edge Constraints TableDesignerEdgeConstraintObjectType = Edge Constraint TableDesignerEdgeConstraintNamePropertyDescription = Name of the constraint. @@ -2406,8 +2406,8 @@ ComputedColumnNeedToBePersistedAndNotNullInPrimaryKeyRuleDescription(string colu ComputedColumnNeedToBePersistedInForeignKeyRuleDescription(string columnName, string foreignKeyName) = The computed column with name '{0}' has to be persisted to be part of the foreign key '{1}'. HashIndexNotSupportedInNonMemoryOptimizedTableRuleDescription(string indexName) = Hash index with name '{0}' is not supported on a non memory-optimized table. HashIndexMustHaveBucketCountRuleDescription(string indexName) = Hash index '{0}' does not have a bucket count. -ColumnCanOnlyAppearOnceInNonClusteredColumnStoreIndexRuleDescription(string columnName, string indexName, int rowNumber) = Column with name '{0}' has already been added to the non-clustered column store index '{1}'. Row number: {2}. -NonClusteredColumnStoreIndexMustHaveColumnsRuleDescription(string indexName) = Non-clustered column store index '{0}' does not have any columns associated with it. +ColumnCanOnlyAppearOnceInNonClusteredColumnStoreIndexRuleDescription(string columnName, string indexName, int rowNumber) = Column with name '{0}' has already been added to the non-clustered columnstore index '{1}'. Row number: {2}. +NonClusteredColumnStoreIndexMustHaveColumnsRuleDescription(string indexName) = Non-clustered columnstore index '{0}' does not have any columns associated with it. TableDesignerConfirmationText = I have read the summary and understand the potential risks. ############################################################################ diff --git a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf index bfa26a65..898a0d12 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf +++ b/src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf @@ -6408,8 +6408,8 @@ The Query Processor estimates that implementing the following index could improv - Name of the column store index - Name of the column store index + Name of the columnstore index + Name of the columnstore index @@ -6418,13 +6418,13 @@ The Query Processor estimates that implementing the following index could improv - Description of the column store index - Description of the column store index + Description of the columnstore index + Description of the columnstore index - Whether the column store index is clustered. - Whether the column store index is clustered. + Whether the columnstore index is clustered. + Whether the columnstore index is clustered. @@ -6433,8 +6433,8 @@ The Query Processor estimates that implementing the following index could improv - Filter predicate of the column store index - Filter predicate of the column store index + Filter predicate of the columnstore index + Filter predicate of the columnstore index @@ -6443,8 +6443,8 @@ The Query Processor estimates that implementing the following index could improv - Columns in this column store index - Columns in this column store index + Columns in this columnstore index + Columns in this columnstore index @@ -6463,29 +6463,29 @@ The Query Processor estimates that implementing the following index could improv - Column with name '{0}' has already been added to the non-clustered column store index '{1}'. Row number: {2}. - Column with name '{0}' has already been added to the non-clustered column store index '{1}'. Row number: {2}. + Column with name '{0}' has already been added to the non-clustered columnstore index '{1}'. Row number: {2}. + Column with name '{0}' has already been added to the non-clustered columnstore index '{1}'. Row number: {2}. . Parameters: 0 - columnName (string), 1 - indexName (string), 2 - rowNumber (int) - Column Store Indexes - Column Store Indexes + Columnstore Indexes + Columnstore Indexes - Column Store Index - Column Store Index + Columnstore Index + Columnstore Index - New Column Store Index - New Column Store Index + New Columnstore Index + New Columnstore Index - Non-clustered column store index '{0}' does not have any columns associated with it. - Non-clustered column store index '{0}' does not have any columns associated with it. + Non-clustered columnstore index '{0}' does not have any columns associated with it. + Non-clustered columnstore index '{0}' does not have any columns associated with it. . Parameters: 0 - indexName (string) diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/ViewModel/ColumnStoreIndexViewModel.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/ViewModel/ColumnStoreIndexViewModel.cs index b5aff70a..7c16585d 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/ViewModel/ColumnStoreIndexViewModel.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/ViewModel/ColumnStoreIndexViewModel.cs @@ -6,7 +6,7 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner.Contracts { /// - /// The view model of column store index. + /// The view model of columnstore index. /// public class ColumnStoreIndexViewModel : ObjectViewModelBase { diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs index 250cb206..1ee283fe 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs @@ -1060,7 +1060,7 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner indexVM.Columns.CanAddRows = !index.IsClustered; indexVM.ColumnsDisplayValue.Enabled = false; - // avoid populating columns for CLUSTERED column store index + // avoid populating columns for CLUSTERED columnstore index if (!index.IsClustered) { indexVM.ColumnsDisplayValue.Value = index.ColumnsDisplayValue; @@ -1432,6 +1432,7 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner var columnStoreIndexesTableProperties = new TableComponentProperties() { Title = SR.TableDesignerColumnStoreIndexesTableTitle, + AriaLabel = SR.TableDesignerColumnStoreIndexesTableTitle, ObjectTypeDisplayName = SR.TableDesignerColumnStoreIndexObjectType, LabelForAddNewButton = SR.AddNewColumnStoreIndexLabel };