ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Enable Premium SSD V2 for SQL VM SKU recommendation (#2258)

Browse Source 
The SKU Recommendations include premium v2 disks for SQL VM
This commit is contained in:
Ram Uday Kumar
2023-10-02 01:57:23 +05:30
committed by GitHub
parent 411a5b17bb
commit 14f450c4c1
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Microsoft.SqlTools.Migration/Contracts/GetSkuRecommendationsRequest.cs
View File

@@ -67,6 +67,12 @@ namespace Microsoft.SqlTools.Migration.Contracts
/// List of databases to consider when generating recommendations /// List of databases to consider when generating recommendations
/// </summary> /// </summary>
public List<string> DatabaseAllowList { get; set; } public List<string> DatabaseAllowList { get; set; }
/// <summary>
/// Whether or not PremiumSSDV2 as a feature is enabled.
/// Defaults to false if not explicitly provided.
/// </summary>
public bool IsPremiumSSDV2Enabled { get; set; } = false;
} }
public class GetSkuRecommendationsResult public class GetSkuRecommendationsResult

3
src/Microsoft.SqlTools.Migration/MigrationService.cs
View File

@@ -526,7 +526,8 @@ namespace Microsoft.SqlTools.Migration
{ {
EligibleSkuCategories = null, // eligible SKU list will be adjusted with each recommendation type EligibleSkuCategories = null, // eligible SKU list will be adjusted with each recommendation type
ScalingFactor = parameters.ScalingFactor / 100.0, ScalingFactor = parameters.ScalingFactor / 100.0,
TargetEnvironment = TargetEnvironmentType.Production TargetEnvironment = TargetEnvironmentType.Production,
IsPremiumSSDV2Enabled = parameters.IsPremiumSSDV2Enabled,
}; };
// generate SQL DB recommendations, if applicable // generate SQL DB recommendations, if applicable

3
test/Microsoft.SqlTools.Migration.IntegrationTests/Migration/MigrationServiceTests.cs
View File

@@ -58,7 +58,8 @@ namespace Microsoft.SqlTools.Migration.IntegrationTests.Migration
EndTime = DateTime.UtcNow.ToString("yyyy-MM-dd HH:mm:ss"), EndTime = DateTime.UtcNow.ToString("yyyy-MM-dd HH:mm:ss"),
PerfQueryIntervalInSec = 30, PerfQueryIntervalInSec = 30,
ScalingFactor = 1, ScalingFactor = 1,
DatabaseAllowList = new List<string> { "test", "test1" } DatabaseAllowList = new List<string> { "test", "test1" },
IsPremiumSSDV2Enabled = true,
}; };
var requestContext = RequestContextMocks.Create<GetSkuRecommendationsResult>(r => result = r).AddErrorHandling(null); var requestContext = RequestContextMocks.Create<GetSkuRecommendationsResult>(r => result = r).AddErrorHandling(null);