mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-01-13 17:23:02 -05:00
Enable Premium SSD V2 for SQL VM SKU recommendation (#2258)
The SKU Recommendations include premium v2 disks for SQL VM
This commit is contained in:
@@ -67,6 +67,12 @@ namespace Microsoft.SqlTools.Migration.Contracts
|
||||
/// List of databases to consider when generating recommendations
|
||||
/// </summary>
|
||||
public List<string> DatabaseAllowList { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Whether or not PremiumSSDV2 as a feature is enabled.
|
||||
/// Defaults to false if not explicitly provided.
|
||||
/// </summary>
|
||||
public bool IsPremiumSSDV2Enabled { get; set; } = false;
|
||||
}
|
||||
|
||||
public class GetSkuRecommendationsResult
|
||||
|
||||
@@ -526,7 +526,8 @@ namespace Microsoft.SqlTools.Migration
|
||||
{
|
||||
EligibleSkuCategories = null, // eligible SKU list will be adjusted with each recommendation type
|
||||
ScalingFactor = parameters.ScalingFactor / 100.0,
|
||||
TargetEnvironment = TargetEnvironmentType.Production
|
||||
TargetEnvironment = TargetEnvironmentType.Production,
|
||||
IsPremiumSSDV2Enabled = parameters.IsPremiumSSDV2Enabled,
|
||||
};
|
||||
|
||||
// generate SQL DB recommendations, if applicable
|
||||
|
||||
@@ -58,7 +58,8 @@ namespace Microsoft.SqlTools.Migration.IntegrationTests.Migration
|
||||
EndTime = DateTime.UtcNow.ToString("yyyy-MM-dd HH:mm:ss"),
|
||||
PerfQueryIntervalInSec = 30,
|
||||
ScalingFactor = 1,
|
||||
DatabaseAllowList = new List<string> { "test", "test1" }
|
||||
DatabaseAllowList = new List<string> { "test", "test1" },
|
||||
IsPremiumSSDV2Enabled = true,
|
||||
};
|
||||
|
||||
var requestContext = RequestContextMocks.Create<GetSkuRecommendationsResult>(r => result = r).AddErrorHandling(null);
|
||||
|
||||
Reference in New Issue
Block a user