ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make ParallelMessageProcessingTest stable by loose the assertion (#1786)

Browse Source
This commit is contained in:
Hai Cao
2022-12-13 15:01:01 -08:00
committed by GitHub
parent 548229d547
commit 1559b7c387
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/Microsoft.SqlTools.ServiceLayer.UnitTests/Messaging/MessageDispatcherTests.cs
View File

@@ -93,11 +93,11 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.Messaging
int numOfRequests = 10; int numOfRequests = 10;
int msForEachRequest = 1000; int msForEachRequest = 1000;
// Without parallel processing, this should take around numOfRequests * msForEachRequest ms to finish. // Without parallel processing, this should take around numOfRequests * msForEachRequest ms to finish.
// With parallel process, this should take around 1 * msForEachRequest ms to finish. // With parallel process, this should take around 1 * msForEachRequest ms to finish in theory (with perfect parallelism).
// The diff should be around (numOfRequests - 1) * msForEachRequest ms. // The diff should in theory be around (numOfRequests - 1) * msForEachRequest ms.
// In order to make this test stable, we loose the assertion by checking the diff against // In order to make this test stable on machines with poor hardware / few logical cores,
// (numOfRequests / 2) * msForEachRequest ms, which should for sure pass. // we loose the assertion by only checking parallel process being faster than sequential processing.
Assert.IsTrue(GetTimeToHandleRequests(false, numOfRequests, msForEachRequest) - GetTimeToHandleRequests(true, numOfRequests, msForEachRequest) > msForEachRequest * (numOfRequests / 2)); Assert.IsTrue(GetTimeToHandleRequests(false, numOfRequests, msForEachRequest) > GetTimeToHandleRequests(true, numOfRequests, msForEachRequest));
} }