mirror of
https://github.com/ckaczor/sqltoolsservice.git
synced 2026-02-16 10:58:30 -05:00
[Feature] SKU recommendations in SQL migration extension (#1399)
* Initial check in for SQL migration SKU recommendation feature (#1362) Co-authored-by: Raymond Truong <ratruong@microsoft.com> * Integration test for Get SKU Recommendation. (#1377) * Integration test for Get SKU Recommendation. * Addressing comments - 1) Moving sample files to data folder. 2) Changed Assert for Positive Justification. Ideally for MI we are expecting ~6 justifications but this might change so sticking with 'recommendation should have atleast one positive justification'. * Implement start/stop perf data collection (#1369) * Add SqlInstanceRequirements to SKU recommendation output (#1378) * test for data collection start and stop (#1395) * improve error handling, add RefreshPerfDataCollection (#1393) * WIP - refresh data collection * Capture messages before logging * Update Microsoft.SqlServer.Migration.Assessment NuGet version (#1402) * Update NuGet version to 1.0.20220208.23, update assessment metadata * Update SKU recommendation metadata * Include preview SKUs * Clear message/error queue after refreshing * Clean up * Add 'IsCollecting' to RefreshPerfDataCollection (#1405) Co-authored-by: Neetu Singh <23.neetu@gmail.com>
This commit is contained in:
@@ -0,0 +1,99 @@
|
||||
//
|
||||
// Copyright (c) Microsoft. All rights reserved.
|
||||
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
||||
//
|
||||
|
||||
using Microsoft.SqlServer.Migration.SkuRecommendation.Contracts.Models;
|
||||
using Microsoft.SqlServer.Migration.SkuRecommendation.Models.Sql;
|
||||
using Microsoft.SqlTools.Hosting.Protocol.Contracts;
|
||||
using System.Collections.Generic;
|
||||
|
||||
namespace Microsoft.SqlTools.ServiceLayer.Migration.Contracts
|
||||
{
|
||||
public class GetSkuRecommendationsParams
|
||||
{
|
||||
/// <summary>
|
||||
/// Folder from which collected performance data will be read from
|
||||
/// </summary>
|
||||
public string DataFolder { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Interval at which collected performance data was originally queried at, in seconds
|
||||
/// </summary>
|
||||
public int PerfQueryIntervalInSec { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// List of target platforms to consider when generating recommendations
|
||||
/// </summary>
|
||||
public List<string> TargetPlatforms { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Name of the SQL instance to generate recommendations for
|
||||
/// </summary>
|
||||
public string TargetSqlInstance { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Target percentile to use when performing perf data aggregation
|
||||
/// </summary>
|
||||
public int TargetPercentile { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Scaling ("comfort") factor when evalulating performance requirements
|
||||
/// </summary>
|
||||
public int ScalingFactor { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Start time of collected data points to consider
|
||||
///
|
||||
/// TO-DO: do we really need this? it's pretty safe to assume that most users would want us to evaluate all the collected data and not just part of it
|
||||
/// </summary>
|
||||
public string StartTime { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// End time of collected data points to consider
|
||||
///
|
||||
/// TO-DO: do we really need this? it's pretty safe to assume that most users would want us to evaluate all the collected data and not just part of it
|
||||
/// </summary>
|
||||
public string EndTime { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Whether or not to consider preview SKUs when generating SKU recommendations
|
||||
/// </summary>
|
||||
public bool IncludePreviewSkus { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// List of databases to consider when generating recommendations
|
||||
/// </summary>
|
||||
public List<string> DatabaseAllowList { get; set; }
|
||||
}
|
||||
|
||||
public class GetSkuRecommendationsResult
|
||||
{
|
||||
/// <summary>
|
||||
/// List of SQL DB recommendation results, if applicable
|
||||
/// </summary>
|
||||
public List<SkuRecommendationResult> SqlDbRecommendationResults { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// List of SQL MI recommendation results, if applicable
|
||||
/// </summary>
|
||||
public List<SkuRecommendationResult> SqlMiRecommendationResults { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// List of SQL VM recommendation results, if applicable
|
||||
/// </summary>
|
||||
public List<SkuRecommendationResult> SqlVmRecommendationResults { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// SQL instance requirements, representing an aggregated view of the performance requirements of the source instance
|
||||
/// </summary>
|
||||
public SqlInstanceRequirements InstanceRequirements { get; set; }
|
||||
}
|
||||
|
||||
public class GetSkuRecommendationsRequest
|
||||
{
|
||||
public static readonly
|
||||
RequestType<GetSkuRecommendationsParams, GetSkuRecommendationsResult> Type =
|
||||
RequestType<GetSkuRecommendationsParams, GetSkuRecommendationsResult>.Create("migration/getskurecommendations");
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user