ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove SELECT * from edit/initialize Query (#288)

Browse Source 
* Major refactor of EditDataMetadata providers

* EditMetadataFactory generates "basic" EditTableMetadata objects based entirely on SMO metadata
* SmoEditTableMetadata no longer depends on SMO, making it unecessary to mock it
* Renamed SmoEditTableMetadata to EditTableMetadata
* EditTableMetadata can be extended with DbColumnWrappers

* Moving logic for extending a EditColumnMetadata into that class

* I *think* this will work for async execution of initialize tasks

* Fixing unit tests for new Edit(Table|Column)Metadata classes

* Async stuff that works! And passes unit tests

* Adding unit tests
Adding .idea to gitignore

* Adding message to the EditSessionReadyEvent

* Fixes from dev merge

* Fixing unit tests that Rider didn't catch as failing
May have been a bit heavy-handed with the async/await stuff

* Couple changes as per PR comments
This commit is contained in:
Benjamin Russell
2017-03-22 10:53:24 -07:00
committed by GitHub
parent d7ecfb1a87
commit 16b3874f28
30 changed files with 2325 additions and 1417 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
View File

@@ -561,6 +561,36 @@
<target state="new">NULL is not allowed for this column</target>
<note></note>
</trans-unit>
<trans-unit id="EditDataObjectNotFound">
<source>Table or view requested for edit could not be found</source>
<target state="new">Table or view requested to edit could not be found</target>
<note></note>
</trans-unit>
<trans-unit id="EditDataSessionAlreadyExists">
<source>Edit session already exists.</source>
<target state="new">Edit session already exists.</target>
<note></note>
</trans-unit>
<trans-unit id="EditDataSessionNotInitialized">
<source>Edit session has not been initialized</source>
<target state="new">Edit session has not been initialized</target>
<note></note>
</trans-unit>
<trans-unit id="EditDataSessionAlreadyInitialized">
<source>Edit session has already been initialized</source>
<target state="new">Edit session has already been initialized</target>
<note></note>
</trans-unit>
<trans-unit id="EditDataSessionAlreadyInitializing">
<source>Edit session has already been initialized or is in the process of initializing</source>
<target state="new">Edit session has already been initialized or is in the process of initializing</target>
<note></note>
</trans-unit>
<trans-unit id="EditDataQueryFailed">
<source>Query execution failed, see messages for details</source>
<target state="new">Query execution failed, see messages for details</target>
<note></note>
</trans-unit>
</body>
</file>
</xliff>