ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-24 17:24:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Important bug fixes for edit/commit (extended property check) (#294)

Browse Source 
* Ensures that metadata is "extended" before creating a new row edit object
* Adds the commit handler to edit data service initialization calls
* Unit tests for the associated changes
This commit is contained in:
Benjamin Russell
2017-03-24 15:11:27 -07:00
committed by GitHub
parent d81fa347e5
commit 1909310a92
8 changed files with 46 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Microsoft.SqlTools.ServiceLayer/EditData/EditDataService.cs
View File

@@ -82,6 +82,7 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData
serviceHost.SetRequestHandler(EditRevertRowRequest.Type, HandleRevertRowRequest);
serviceHost.SetRequestHandler(EditSubsetRequest.Type, HandleSubsetRequest);
serviceHost.SetRequestHandler(EditUpdateCellRequest.Type, HandleUpdateCellRequest);
serviceHost.SetRequestHandler(EditCommitRequest.Type, HandleCommitRequest);
}
#region Request Handlers

1
src/Microsoft.SqlTools.ServiceLayer/EditData/EditSession.cs
View File

@@ -440,6 +440,7 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData
NextRowId = associatedResultSet.RowCount;
EditCache = new ConcurrentDictionary<long, RowEditBase>();
IsInitialized = true;
objectMetadata.Extend(associatedResultSet.Columns);
// Step 4) Return our success
await successHandler();

5
src/Microsoft.SqlTools.ServiceLayer/EditData/UpdateManagement/RowEdit.cs
View File

@@ -38,6 +38,11 @@ namespace Microsoft.SqlTools.ServiceLayer.EditData.UpdateManagement
/// <param name="associatedMetadata">Metadata provider for the object to edit</param>
protected RowEditBase(long rowId, ResultSet associatedResultSet, EditTableMetadata associatedMetadata)
{
if (!associatedMetadata.HasExtendedProperties)
{
throw new ArgumentException(SR.EditDataMetadataNotExtended);
}
RowId = rowId;
AssociatedResultSet = associatedResultSet;
AssociatedObjectMetadata = associatedMetadata;