From 767f689c422b65c30f3fffc89aad4aa2a85b6618 Mon Sep 17 00:00:00 2001 From: Aditya Bist Date: Thu, 9 Feb 2017 16:23:49 -0800 Subject: [PATCH 1/2] temp tables not escaped any more --- .../LanguageServices/Completion/SqlCompletionItem.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.SqlTools.ServiceLayer/LanguageServices/Completion/SqlCompletionItem.cs b/src/Microsoft.SqlTools.ServiceLayer/LanguageServices/Completion/SqlCompletionItem.cs index 59a25c05..621400d1 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/LanguageServices/Completion/SqlCompletionItem.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/LanguageServices/Completion/SqlCompletionItem.cs @@ -18,7 +18,7 @@ namespace Microsoft.SqlTools.ServiceLayer.LanguageServices.Completion /// public class SqlCompletionItem { - private static Regex ValidSqlNameRegex = new Regex(@"^[\p{L}_@][\p{L}\p{N}@$#_]{0,127}$"); + private static Regex ValidSqlNameRegex = new Regex(@"^[\p{L}_@#][\p{L}\p{N}@$#_]{0,127}$"); private static DelimitedIdentifier BracketedIdentifiers = new DelimitedIdentifier { Start = "[", End = "]"}; private static DelimitedIdentifier[] DelimitedIdentifiers = new DelimitedIdentifier[] { BracketedIdentifiers, new DelimitedIdentifier {Start = "\"", End = "\"" } }; From c9513890b2562e39c5681ab88dfec31a31ac022a Mon Sep 17 00:00:00 2001 From: Aditya Bist Date: Thu, 9 Feb 2017 18:20:05 -0800 Subject: [PATCH 2/2] added unit test for temp tables --- .../LanguageServer/SqlCompletionItemTests.cs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/test/Microsoft.SqlTools.ServiceLayer.Test/LanguageServer/SqlCompletionItemTests.cs b/test/Microsoft.SqlTools.ServiceLayer.Test/LanguageServer/SqlCompletionItemTests.cs index f5f3486e..1679ca27 100644 --- a/test/Microsoft.SqlTools.ServiceLayer.Test/LanguageServer/SqlCompletionItemTests.cs +++ b/test/Microsoft.SqlTools.ServiceLayer.Test/LanguageServer/SqlCompletionItemTests.cs @@ -524,6 +524,21 @@ namespace Microsoft.SqlTools.ServiceLayer.Test.LanguageServer Assert.Equal(completionItem.Detail, expected); } + [Fact] + public void TempTablesShouldNotBeEscaped() + { + string declarationTitle = "#TestTable"; + string expected = declarationTitle; + DeclarationType declarationType = DeclarationType.Table; + string tokenText = ""; + SqlCompletionItem item = new SqlCompletionItem(declarationTitle, declarationType, tokenText); + CompletionItem completionItem = item.CreateCompletionItem(0, 1, 2); + + Assert.Equal(completionItem.Label, expected); + Assert.Equal(completionItem.InsertText, expected); + Assert.Equal(completionItem.Detail, expected); + } + [Fact] public void KindShouldBeModuleGivenSchemaDeclarationType() {