ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-19 17:23:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

[Table Designer] Add validators for computed col in PK and FK (#1653)

Browse Source
This commit is contained in:
Hai Cao
2022-08-25 16:30:47 -07:00
committed by GitHub
parent 21a261bf69
commit 23072250b7
5 changed files with 95 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerValidator.cs
View File

@@ -37,7 +37,9 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
new ClusteredIndexCannotHaveFilterPredicate(),
new ClusteredIndexCannotHaveIncludedColumnsRule(),
new ColumnCanOnlyAppearOnceInIndexIncludedColumnsRule(),
new ColumnCannotDuplicateWitIndexKeyColumnsRule()
new ColumnCannotDuplicateWitIndexKeyColumnsRule(),
new ComputedColumnNeedToBePersistedAndNotNullInPrimaryKeyRule(),
new ComputedColumnNeedToBePersistedInForeignKeyRule()
};
/// <summary>
@@ -664,6 +666,57 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
}
}
public class ComputedColumnNeedToBePersistedAndNotNullInPrimaryKeyRule : ITableDesignerValidationRule
{
public List<TableDesignerIssue> Run(Dac.TableDesigner designer)
{
var table = designer.TableViewModel;
var errors = new List<TableDesignerIssue>();
if (table.PrimaryKey != null)
{
for (int i = 0; i < table.PrimaryKey.Columns.Count; i++)
{
var columnSpec = table.PrimaryKey.Columns[i];
var col = table.Columns.Items.First(item => item.Name == columnSpec.Column);
if (col != null && col.IsComputed && !(col.IsComputedPersisted == true && col.IsComputedPersistedNullable == false))
{
errors.Add(new TableDesignerIssue()
{
Description = SR.ComputedColumnNeedToBePersistedAndNotNullInPrimaryKeyRuleDescription(col.Name),
PropertyPath = new object[] { TablePropertyNames.PrimaryKeyColumns, i, IndexColumnSpecificationPropertyNames.Column }
});
}
}
}
return errors;
}
}
public class ComputedColumnNeedToBePersistedInForeignKeyRule : ITableDesignerValidationRule
{
public List<TableDesignerIssue> Run(Dac.TableDesigner designer)
{
var table = designer.TableViewModel;
var errors = new List<TableDesignerIssue>();
for (int i = 0; i < table.ForeignKeys.Items.Count; i++)
{
for (int j = 0; j < table.ForeignKeys.Items[i].Columns.Count; j++)
{
var col = table.Columns.Items.First(item => item.Name == table.ForeignKeys.Items[i].Columns[j]);
if (col != null && col.IsComputed && col.IsComputedPersisted != true)
{
errors.Add(new TableDesignerIssue()
{
Description = SR.ComputedColumnNeedToBePersistedInForeignKeyRuleDescription(col.Name, table.ForeignKeys.Items[i].SystemName),
PropertyPath = new object[] { TablePropertyNames.ForeignKeys, i, ForeignKeyPropertyNames.ColumnMapping, j, ForeignKeyColumnMappingPropertyNames.Column }
});
}
}
}
return errors;
}
}
public class MemoryOptimizedCannotBeEnabledWhenNotSupportedRule : ITableDesignerValidationRule
{
public List<TableDesignerIssue> Run(Dac.TableDesigner designer)