ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-16 01:25:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix VerifyAllSqlObjects test (#1485)

Browse Source 
* Fix VerifyAllSqlObjects test

* comment
This commit is contained in:
Charles Gagnon
2022-05-06 23:13:11 -07:00
committed by GitHub
parent 048988e5d3
commit 2540068998
1 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/ObjectExplorer/ObjectExplorerServiceTests.cs
View File

@@ -4,6 +4,7 @@
//
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Linq;
@@ -427,21 +428,34 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.ObjectExplorer
return null;
}
private void VerifyMetadata(NodeInfo node)
{
// These are node types for which the label doesn't include a schema
// (usually because the objects themselves aren't schema-bound)
var schemalessLabelNodeTypes = new List<string> () {
"Column",
"Key",
"Constraint",
"Index",
"Statistic",
"Trigger",
"StoredProcedureParameter",
"TableValuedFunctionParameter",
"ScalarValuedFunctionParameter",
"UserDefinedTableTypeColumn"
};
if (node.NodeType != "Folder")
{
Assert.NotNull(node.NodeType);
Assert.That(node.NodeType, Is.Not.Empty.Or.Null, "NodeType should not be empty or null");
if (node.Metadata != null && !string.IsNullOrEmpty(node.Metadata.MetadataTypeName))
{
if (!string.IsNullOrEmpty(node.Metadata.Schema))
if (!string.IsNullOrEmpty(node.Metadata.Schema) && !schemalessLabelNodeTypes.Any(t => t == node.NodeType))
{
Assert.True(node.Label.Contains($"{node.Metadata.Schema}.{node.Metadata.Name}"));
Assert.That(node.Label, Does.Contain($"{node.Metadata.Schema}.{node.Metadata.Name}"), "Node label does not contain expected text");
}
else
{
Assert.NotNull(node.Label);
Assert.That(node.Label, Does.Contain(node.Metadata.Name), "Node label does not contain expected text");
}
}
}