Splitting out default DacFx options for Publish and Schema Compare (#1126)

* Splitting out schema comp and publish defaults

* Added test

* Correcting comments, changing scope

* Moving DeploymentOptions to DacFx folder due to dependency hierarchy between DacFx and SchemaCompare
This commit is contained in:
Benjin Dubishar
2020-11-25 14:44:34 -08:00
committed by GitHub
parent 4f42b17226
commit 25c542319e
10 changed files with 130 additions and 38 deletions

View File

@@ -725,13 +725,12 @@ FROM MissingEdgeHubInputStream'";
[Test]
public async Task GetOptionsFromProfile()
{
DeploymentOptions expectedResults = new DeploymentOptions()
{
ExcludeObjectTypes = null,
IncludeCompositeObjects = true,
BlockOnPossibleDataLoss = true,
AllowIncompatiblePlatform = true
};
DeploymentOptions expectedResults = DeploymentOptions.GetDefaultPublishOptions();
expectedResults.ExcludeObjectTypes = null;
expectedResults.IncludeCompositeObjects = true;
expectedResults.BlockOnPossibleDataLoss = true;
expectedResults.AllowIncompatiblePlatform = true;
var dacfxRequestContext = new Mock<RequestContext<DacFxOptionsResult>>();
dacfxRequestContext.Setup((RequestContext<DacFxOptionsResult> x) => x.SendResult(It.Is<DacFxOptionsResult>((result) => ValidateOptions(expectedResults, result.DeploymentOptions) == true))).Returns(Task.FromResult(new object()));
@@ -754,7 +753,7 @@ FROM MissingEdgeHubInputStream'";
[Test]
public async Task GetOptionsFromProfileWithoutOptions()
{
DeploymentOptions expectedResults = new DeploymentOptions();
DeploymentOptions expectedResults = DeploymentOptions.GetDefaultPublishOptions();
expectedResults.ExcludeObjectTypes = null;
var dacfxRequestContext = new Mock<RequestContext<DacFxOptionsResult>>();
@@ -772,6 +771,23 @@ FROM MissingEdgeHubInputStream'";
dacfxRequestContext.VerifyAll();
}
/// <summary>
/// Verify the default dacFx options for publishing
/// </summary>
[Test]
public async Task ValidateGetDefaultPublishOptionsCallFromService()
{
DeploymentOptions expectedResults = DeploymentOptions.GetDefaultPublishOptions();
var dacfxRequestContext = new Mock<RequestContext<DacFxOptionsResult>>();
dacfxRequestContext.Setup((RequestContext<DacFxOptionsResult> x) => x.SendResult(It.Is<DacFxOptionsResult>((result) => ValidateOptions(expectedResults, result.DeploymentOptions) == true))).Returns(Task.FromResult(new object()));
GetDefaultPublishOptionsParams p = new GetDefaultPublishOptionsParams();
DacFxService service = new DacFxService();
await service.HandleGetDefaultPublishOptionsRequest(p, dacfxRequestContext.Object);
}
/// <summary>
/// Verify that streaming job
/// </summary>