ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix copying result header behavior #2125 (#2125)

Browse Source
This commit is contained in:
Hai Cao
2023-06-28 09:52:55 -07:00
committed by GitHub
parent 33b5cb98cd
commit 2a30a648f7
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Microsoft.SqlTools.ServiceLayer/QueryExecution/Contracts/CopyResultsRequest.cs
View File

@@ -22,6 +22,11 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution.Contracts
/// </summary> /// </summary>
public class CopyResultsRequestParams : SubsetParams public class CopyResultsRequestParams : SubsetParams
{ {
/// <summary>
/// Whether to include the column headers.
/// </summary>
public bool IncludeHeaders { get; set; }
/// <summary> /// <summary>
/// The selections. /// The selections.
/// </summary> /// </summary>

4
src/Microsoft.SqlTools.ServiceLayer/QueryExecution/QueryExecutionService.cs
View File

@@ -729,7 +729,9 @@ namespace Microsoft.SqlTools.ServiceLayer.QueryExecution
var lastRowIndex = rowRanges.Last().End; var lastRowIndex = rowRanges.Last().End;
var builder = new StringBuilder(); var builder = new StringBuilder();
var pageSize = 200; var pageSize = 200;
if (Settings.QueryEditorSettings.Results.CopyIncludeHeaders)
// We need to respect IncludeHeaders from parameters instead of getting the config value as ADS can explicitly ask for headers
if (requestParams.IncludeHeaders)
{ {
Validate.IsNotNullOrEmptyString(nameof(requestParams.OwnerUri), requestParams.OwnerUri); Validate.IsNotNullOrEmptyString(nameof(requestParams.OwnerUri), requestParams.OwnerUri);
Query query; Query query;