ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-17 02:51:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

SqlAssessment update to 1.1.9 (#1593)

Browse Source 
* Sql Assessment version update to 1.1.9

* Unit test fix

* integration test fix
This commit is contained in:
Vladimir Chernov
2022-07-20 01:19:39 +03:00
committed by GitHub
parent 693bb0480a
commit 2ae0d99900
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Packages.props
View File

@@ -25,7 +25,7 @@
<PackageReference Update="Microsoft.SqlServer.DACFx" Version="160.6227.0-preview" GeneratePathProperty="true" /> <PackageReference Update="Microsoft.SqlServer.DACFx" Version="160.6227.0-preview" GeneratePathProperty="true" />
<PackageReference Update="Microsoft.Azure.Kusto.Data" Version="9.0.4" /> <PackageReference Update="Microsoft.Azure.Kusto.Data" Version="9.0.4" />
<PackageReference Update="Microsoft.Azure.Kusto.Language" Version="9.0.4" /> <PackageReference Update="Microsoft.Azure.Kusto.Language" Version="9.0.4" />
<PackageReference Update="Microsoft.SqlServer.Assessment" Version="[1.0.305]" /> <PackageReference Update="Microsoft.SqlServer.Assessment" Version="[1.1.9]" />
<PackageReference Update="Microsoft.SqlServer.Migration.Assessment" Version="1.0.20220527.33" /> <PackageReference Update="Microsoft.SqlServer.Migration.Assessment" Version="1.0.20220527.33" />
<PackageReference Update="Microsoft.SqlServer.Management.SqlParser" Version="160.22506.0" /> <PackageReference Update="Microsoft.SqlServer.Management.SqlParser" Version="160.22506.0" />
<PackageReference Update="Microsoft.Azure.OperationalInsights" Version="1.0.0" /> <PackageReference Update="Microsoft.Azure.OperationalInsights" Version="1.0.0" />

2
src/Microsoft.SqlTools.ServiceLayer/SqlAssessment/Contracts/AssessmentRequest.cs
View File

@@ -81,7 +81,7 @@ namespace Microsoft.SqlTools.ServiceLayer.SqlAssessment.Contracts
/// <summary> /// <summary>
/// Gets or sets a <see cref="string"/> indicating /// Gets or sets a <see cref="string"/> indicating
/// severity level assigned to this items. /// severity level assigned to this items.
/// Values are: "Information", "Warning", "Critical". /// Values are: "Information", "Low", "Medium", "High".
/// </summary> /// </summary>
public string Level { get; set; } public string Level { get; set; }
} }

2
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/SqlAssessment/SqlAssessmentServiceTests.cs
View File

@@ -27,7 +27,7 @@ namespace Microsoft.SqlTools.ServiceLayer.IntegrationTests.SqlAssessment
{ {
private delegate Task<List<TResult>> AssessmentMethod<TResult>(SqlObjectLocator locator); private delegate Task<List<TResult>> AssessmentMethod<TResult>(SqlObjectLocator locator);
private static readonly string[] AllowedSeverityLevels = { string.Empty, "Information", "Warning", "Critical" }; private static readonly string[] AllowedSeverityLevels = { string.Empty, "Information", "Low", "Medium", "High" };
[Test] [Test]
public async Task InvokeSqlAssessmentServerTest() public async Task InvokeSqlAssessmentServerTest()

12
test/Microsoft.SqlTools.ServiceLayer.UnitTests/SqlAssessment/GenerateScriptOperationTests.cs
View File

@@ -43,7 +43,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.SqlAssessment
DisplayName = "D N2", DisplayName = "D N2",
HelpLink = "http://HL2", HelpLink = "http://HL2",
Kind = AssessmentResultItemKind.Warning, Kind = AssessmentResultItemKind.Warning,
Level = "Warning", Level = "Medium",
Message = "Msg'1", Message = "Msg'1",
TargetName = "proj[*]_devW", TargetName = "proj[*]_devW",
TargetType = SqlObjectType.Database, TargetType = SqlObjectType.Database,
@@ -58,7 +58,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.SqlAssessment
DisplayName = "D'N1", DisplayName = "D'N1",
HelpLink = "HL'1", HelpLink = "HL'1",
Kind = AssessmentResultItemKind.Error, Kind = AssessmentResultItemKind.Error,
Level = "Critical", Level = "High",
Message = "Msg'1", Message = "Msg'1",
TargetName = "proj[*]_devE", TargetName = "proj[*]_devE",
TargetType = SqlObjectType.Server, TargetType = SqlObjectType.Server,
@@ -73,7 +73,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.SqlAssessment
DisplayName = "D N2", DisplayName = "D N2",
HelpLink = "http://HL2", HelpLink = "http://HL2",
Kind = AssessmentResultItemKind.Note, Kind = AssessmentResultItemKind.Note,
Level = "Warning", Level = "Medium",
Message = "Msg'1", Message = "Msg'1",
TargetName = "proj[*]_dev", TargetName = "proj[*]_dev",
TargetType = SqlObjectType.Database, TargetType = SqlObjectType.Database,
@@ -88,7 +88,7 @@ namespace Microsoft.SqlTools.ServiceLayer.UnitTests.SqlAssessment
DisplayName = "D'N1", DisplayName = "D'N1",
HelpLink = "HL'1", HelpLink = "HL'1",
Kind = AssessmentResultItemKind.Note, Kind = AssessmentResultItemKind.Note,
Level = "Critical", Level = "High",
Message = "Msg'1", Message = "Msg'1",
TargetName = "proj[*]_dev", TargetName = "proj[*]_dev",
TargetType = SqlObjectType.Server, TargetType = SqlObjectType.Server,
@@ -120,8 +120,8 @@ INSERT INTO [dbo].[AssessmentResult] ([CheckName],[CheckId],[RulesetName],[Rules
SELECT rpt.[CheckName],rpt.[CheckId],rpt.[RulesetName],rpt.[RulesetVersion],rpt.[Severity],rpt.[Message],rpt.[TargetPath],rpt.[TargetType],rpt.[HelpLink],rpt.[Timestamp] SELECT rpt.[CheckName],rpt.[CheckId],rpt.[RulesetName],rpt.[RulesetVersion],rpt.[Severity],rpt.[Message],rpt.[TargetPath],rpt.[TargetType],rpt.[HelpLink],rpt.[Timestamp]
FROM (VALUES FROM (VALUES
('DN1','C1','Microsoft Ruleset','1.3','Information','Msg''1','proj[*]_dev','Server','HL1','2001-05-25 01:42:00.000 +00:00'), ('DN1','C1','Microsoft Ruleset','1.3','Information','Msg''1','proj[*]_dev','Server','HL1','2001-05-25 01:42:00.000 +00:00'),
('D N2','C-2','Microsoft Ruleset','1.3','Warning','Msg''1','proj[*]_dev','Database','http://HL2','2001-05-25 01:42:00.000 +03:00'), ('D N2','C-2','Microsoft Ruleset','1.3','Medium','Msg''1','proj[*]_dev','Database','http://HL2','2001-05-25 01:42:00.000 +03:00'),
('D''N1','C''3','Microsoft Ruleset','1.3','Critical','Msg''1','proj[*]_dev','Server','HL''1','2001-05-25 01:42:00.000 -01:30') ('D''N1','C''3','Microsoft Ruleset','1.3','High','Msg''1','proj[*]_dev','Server','HL''1','2001-05-25 01:42:00.000 -01:30')
) rpt([CheckName],[CheckId],[RulesetName],[RulesetVersion],[Severity],[Message],[TargetPath],[TargetType],[HelpLink],[Timestamp])"; ) rpt([CheckName],[CheckId],[RulesetName],[RulesetVersion],[Severity],[Message],[TargetPath],[TargetType],[HelpLink],[Timestamp])";
[Test] [Test]