ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-09 09:42:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix Sql Auth for Migration Assessments (#1182)

Browse Source 
* pass connection string to dma engine

* cleanup

* remove optional parameter

* modified query
This commit is contained in:
Christopher Suh
2021-03-26 15:59:07 -07:00
committed by GitHub
parent 5a8cfab8fa
commit 2badd8e728
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs
View File

@@ -119,7 +119,6 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
await ConnectionService.Connect(connectParams);
var connection = await ConnectionService.Instance.GetOrOpenConnection(randomUri, ConnectionType.Default);
var serverInfo = ReliableConnectionHelper.GetServerVersion(connection);
var hostInfo = ReliableConnectionHelper.GetServerHostInfo(connection);
@@ -136,8 +135,8 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
};
var db = SqlAssessmentService.GetDatabaseLocator(server, connection.Database);
var results = await GetAssessmentItems(server);
var connectionString = ConnectionService.BuildConnectionString(connInfo.ConnectionDetails);
var results = await GetAssessmentItems(server, connectionString);
var result = new MigrationAssessmentResult();
result.Items.AddRange(results);
await requestContext.SendResult(result);
@@ -179,9 +178,9 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration
}
}
internal async Task<List<MigrationAssessmentInfo>> GetAssessmentItems(SqlObjectLocator target)
internal async Task<List<MigrationAssessmentInfo>> GetAssessmentItems(SqlObjectLocator target, string connectionString)
{
DmaEngine engine = new DmaEngine(target);
DmaEngine engine = new DmaEngine(connectionString);
var assessmentResults = await engine.GetTargetAssessmentResultsList();
var result = new List<MigrationAssessmentInfo>();