ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

temporary fix to make oe tables expanding faster (#343)

Browse Source
This commit is contained in:
Leila Lali
2017-05-12 09:31:23 -07:00
committed by GitHub
parent ed978fe5b7
commit 327f0a5edd
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/SmoModel/SmoTableCustomNode.cs
View File

@@ -14,11 +14,13 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectExplorer.SmoModel
{ {
public override string GetNodeCustomName(object smoObject, SmoQueryContext smoContext) public override string GetNodeCustomName(object smoObject, SmoQueryContext smoContext)
{ {
Table table = smoObject as Table; // TODO: this code makes expanding the tables slow because of loading the IsSystemVersioned property for each table.
if (table != null && table.IsSystemVersioned) // Have to uncomment this after optimizing the way properties are loaded for SMO objects
{ //Table table = smoObject as Table;
return $"{table.Schema}.{table.Name} ({SR.SystemVersioned_LabelPart})"; //if (table != null && table.IsSystemVersioned)
} //{
// return $"{table.Schema}.{table.Name} ({SR.SystemVersioned_LabelPart})";
//}
return string.Empty; return string.Empty;
} }

2
test/Microsoft.SqlTools.ServiceLayer.Test.Common/TestData/ObjectExplorer/Baselines/AllSqlObjects.txt
View File

@@ -29,7 +29,7 @@ NodeType: Constraint Label: CK_Employee_VacationHours SubType: Status:
NodeType: Index Label: NonClusteredIndex-Login (Non-Unique, Non-Clustered) SubType: Status: NodeType: Index Label: NonClusteredIndex-Login (Non-Unique, Non-Clustered) SubType: Status:
NodeType: Statistic Label: NonClusteredIndex-Login SubType: Status: NodeType: Statistic Label: NonClusteredIndex-Login SubType: Status:
NodeType: Statistic Label: PK_Employee_BusinessEntityID SubType: Status: NodeType: Statistic Label: PK_Employee_BusinessEntityID SubType: Status:
NodeType: Table Label: HumanResources.Employee_Temporal (System-Versioned) SubType: Status: NodeType: Table Label: HumanResources.Employee_Temporal SubType: Status:
NodeType: Column Label: BusinessEntityID (PK, int, not null) SubType: Status: NodeType: Column Label: BusinessEntityID (PK, int, not null) SubType: Status:
NodeType: Column Label: NationalIDNumber (nvarchar(15), not null) SubType: Status: NodeType: Column Label: NationalIDNumber (nvarchar(15), not null) SubType: Status:
NodeType: Column Label: LoginID (nvarchar(256), not null) SubType: Status: NodeType: Column Label: LoginID (nvarchar(256), not null) SubType: Status: