From 32d7a63d7cba2ac695a45f65c8e49bdda5c91e6a Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Mon, 16 Nov 2020 13:48:30 -0800 Subject: [PATCH] Send error result if parse error occurs during convert (#1121) --- .../NotebookConvert/NotebookConvertService.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Microsoft.SqlTools.ServiceLayer/NotebookConvert/NotebookConvertService.cs b/src/Microsoft.SqlTools.ServiceLayer/NotebookConvert/NotebookConvertService.cs index fb86a72c..1f64248d 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/NotebookConvert/NotebookConvertService.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/NotebookConvert/NotebookConvertService.cs @@ -144,6 +144,10 @@ namespace Microsoft.SqlTools.ServiceLayer.NotebookConvert var parser = new TSql150Parser(false); IList errors = new List(); var parseResult = parser.Parse(new StringReader(sql), out errors); + if (errors.Count > 0) + { + throw new Exception(string.Join(Environment.NewLine, errors.Select(error => error.Message))); + } var batches = (parseResult as TSqlScript).Batches; var tokens = parseResult.ScriptTokenStream;