From 33636efa87b8250257d409d116d05488e26dc013 Mon Sep 17 00:00:00 2001 From: Hai Cao Date: Wed, 1 Jun 2022 15:00:01 -0700 Subject: [PATCH] [Table Designer] Fix a few computed col issues (#1518) --- .../TableDesigner/TableDesignerService.cs | 2 +- .../TableDesigner/TableDesignerValidator.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs index 6d8bce25..e936bf75 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs @@ -825,7 +825,7 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner columnViewModel.IsPrimaryKey.Enabled = true; // To be consistent with SSDT, any column can be a primary key. columnViewModel.Type.Value = column.DataType; columnViewModel.Type.Enabled = column.CanEditDataType; - columnViewModel.Type.Values = tableDesigner.DataTypes.ToList(); + columnViewModel.Type.Values = column.DataTypes.ToList(); columnViewModel.AdvancedType.Value = column.AdvancedDataType; columnViewModel.AdvancedType.Enabled = column.CanEditDataType; columnViewModel.AdvancedType.Values = column.AdvancedDataTypes.ToList(); diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerValidator.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerValidator.cs index 363359c6..5e221724 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerValidator.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerValidator.cs @@ -473,11 +473,11 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner { var table = designer.TableViewModel; var errors = new List(); - if (!table.IsEdge && table.Columns.Items.Count == 0) + if (!table.IsEdge && table.Columns.Items.Where(c => !c.IsComputed).Count() == 0) { errors.Add(new TableDesignerIssue() { - Description = "A table must have at least one column defined." + Description = "A table must have at least one non-computed column defined." }); } return errors;