ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-07 01:25:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update STS changes to be backward compatible with scmpOpen (#2031)

Browse Source 
* Update STS changes to be backward compatible with scmpOpen

* Update cleanup code

* Fix test.
This commit is contained in:
Sakshi Sharma
2023-04-24 16:58:06 -07:00
committed by GitHub
parent 175f530403
commit 3e0135b907
4 changed files with 1090 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/SchemaCompareOpenScmpOperation.cs
View File

@@ -173,9 +173,19 @@ namespace Microsoft.SqlTools.ServiceLayer.SchemaCompare
if (fs != null)
{
DacExtractTarget extractTarget;
if (Enum.TryParse<DacExtractTarget>(fs.FirstOrDefault().Value, out extractTarget))
if(fs.FirstOrDefault() != null) // it is possible that this value is not set
{
endpointInfo.ExtractTarget = extractTarget;
if (Enum.TryParse<DacExtractTarget>(fs.FirstOrDefault().Value, out extractTarget))
{
endpointInfo.ExtractTarget = extractTarget;
} else
{
endpointInfo.ExtractTarget = DacExtractTarget.SchemaObjectType; // set default but log an error
Logger.Write(TraceEventType.Error, string.Format("Schema compare open scmp operation failed during xml parsing with unknown ExtractTarget"));
}
} else
{
endpointInfo.ExtractTarget = DacExtractTarget.SchemaObjectType; // set the default if this value doesn't already exist in the scmp file
}
}