From 3e5bf00cc5c8db1bce0d5fa33a9a410648dc7751 Mon Sep 17 00:00:00 2001
From: Aditya Bist <adbist@microsoft.com>
Date: Tue, 8 Mar 2022 14:07:30 -0800
Subject: [PATCH] Change preview report type (#1418)

* change report type

* PR comments

* fix doc for report

* rename format to mimetype

* nitpicks

* edit comments

* default to plain text
---
 .../Requests/GeneratePreviewReportRequest.cs  | 19 ++++++++++++++++++-
 .../TableDesigner/TableDesignerService.cs     | 10 +++++++---
 2 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
index 00cadf35..b65a876b 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
+++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/Contracts/Requests/GeneratePreviewReportRequest.cs
@@ -7,6 +7,23 @@ using Microsoft.SqlTools.Hosting.Protocol.Contracts;
 
 namespace Microsoft.SqlTools.ServiceLayer.TableDesigner.Contracts
 {
+    /// <summary>
+    /// The service request to generate preview report describing the changes.
+    /// </summary>
+
+    public class GeneratePreviewReportResult 
+    {
+        /// <summary>
+        /// The report generated for publish preview
+        /// </summary>
+        public string Report;
+
+        /// <summary>
+        /// format (mimetype) of the string
+        /// </summary>
+        public string MimeType;
+    }
+    
     /// <summary>
     /// The service request to generate preview report describing the changes.
     /// </summary>
@@ -15,6 +32,6 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner.Contracts
         /// <summary>
         /// Request definition
         /// </summary>
-        public static readonly RequestType<TableInfo, string> Type = RequestType<TableInfo, string>.Create("tabledesigner/generatepreviewreport");
+        public static readonly RequestType<TableInfo, GeneratePreviewReportResult> Type = RequestType<TableInfo, GeneratePreviewReportResult>.Create("tabledesigner/generatepreviewreport");
     }
 }
diff --git a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
index f038dc36..c5a6991e 100644
--- a/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
+++ b/src/Microsoft.SqlTools.ServiceLayer/TableDesigner/TableDesignerService.cs
@@ -161,13 +161,17 @@ namespace Microsoft.SqlTools.ServiceLayer.TableDesigner
             });
         }
 
-        private Task HandleGeneratePreviewReportRequest(TableInfo tableInfo, RequestContext<string> requestContext)
+        private Task HandleGeneratePreviewReportRequest(TableInfo tableInfo, RequestContext<GeneratePreviewReportResult> requestContext)
         {
-            return this.HandleRequest<string>(requestContext, async () =>
+            return this.HandleRequest<GeneratePreviewReportResult>(requestContext, async () =>
             {
                 var table = this.GetTableDesigner(tableInfo);
                 var report = table.GenerateReport();
-                await requestContext.SendResult(report);
+                var generatePreviewReportResult = new GeneratePreviewReportResult();
+                // TODO - set report type by caohai
+                generatePreviewReportResult.Report = report;
+                generatePreviewReportResult.MimeType = "text/plain";
+                await requestContext.SendResult(generatePreviewReportResult);
             });
         }