Adding sr.strings file and removing hard-coded strings (#52)

* Strings sweep for connection service

* String sweep for credentials service

* String sweep for hosting

* String sweep for query execution service

* String sweep for Workspace service

* Renaming utility namespace to match standards

Renaming Microsoft.SqlTools.EditorServices.Utility to
Microsoft.SqlTools.ServiceLayer.Utility to match the naming changes done a
while back. Also renaming them on the files that use them

* Namespace change on reliable connection

* Adding the new resx and designer files

* Final bug fixes for srgen

Fixing flakey moq package name

* Removing todo as per @kevcunnane

* Adding using statements as per @llali's comment

* Fixing issues from broken unit tests

Note: This feature contains changes that will break the contract for
saving as CSV and JSON. On success, null is returned as a message instead
of "Success". Changes will be made to the vscode component to handle this
change.

src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs

@@ -9,11 +9,11 @@ using System.Data;
 using System.Data.Common;
 using System.Data.SqlClient;
 using System.Threading.Tasks;
-using Microsoft.SqlTools.EditorServices.Utility;
 using Microsoft.SqlTools.ServiceLayer.Connection.Contracts;
 using Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection;
 using Microsoft.SqlTools.ServiceLayer.Hosting.Protocol;
 using Microsoft.SqlTools.ServiceLayer.SqlContext;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 using Microsoft.SqlTools.ServiceLayer.Workspace;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection
@@ -125,14 +125,14 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
             string paramValidationErrorMessage;
             if (connectionParams == null)
             {
-                return new ConnectResponse()
+                return new ConnectResponse
                 {
-                    Messages = "Error: Connection parameters cannot be null."
+                    Messages = SR.ConnectionServiceConnectErrorNullParams
                 };
             }
-            else if (!connectionParams.IsValid(out paramValidationErrorMessage))
+            if (!connectionParams.IsValid(out paramValidationErrorMessage))
             {
-                return new ConnectResponse()
+                return new ConnectResponse
                 {
                     Messages = paramValidationErrorMessage
                 };
@@ -257,14 +257,14 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
             var owner = listDatabasesParams.OwnerUri;
             if (string.IsNullOrEmpty(owner))
             {
-                throw new ArgumentException("OwnerUri cannot be null or empty");
+                throw new ArgumentException(SR.ConnectionServiceListDbErrorNullOwnerUri);
             }
 
             // Use the existing connection as a base for the search
             ConnectionInfo info;
             if (!TryFindConnection(owner, out info))
             {
-                throw new Exception("Specified OwnerUri \"" + owner + "\" does not have an existing connection");
+                throw new Exception(SR.ConnectionServiceListDbErrorNotConnected(owner));
             }
             ConnectionDetails connectionDetails = info.ConnectionDetails.Clone();
 
@@ -422,7 +422,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
                     case "SqlLogin":
                         break;
                     default:
-                        throw new ArgumentException(string.Format("Invalid value \"{0}\" for AuthenticationType. Valid values are \"Integrated\" and \"SqlLogin\".", connectionDetails.AuthenticationType));
+                        throw new ArgumentException(SR.ConnectionServiceConnStringInvalidAuthType(connectionDetails.AuthenticationType));
                 }
             }
             if (connectionDetails.Encrypt.HasValue)
@@ -469,7 +469,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
                         intent = ApplicationIntent.ReadWrite;
                         break;
                     default:
-                        throw new ArgumentException(string.Format("Invalid value \"{0}\" for ApplicationIntent. Valid values are \"ReadWrite\" and \"ReadOnly\".", connectionDetails.ApplicationIntent));
+                        throw new ArgumentException(SR.ConnectionServiceConnStringInvalidIntent(connectionDetails.ApplicationIntent));
                 }
                 connectionBuilder.ApplicationIntent = intent;
             }
@@ -553,7 +553,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
                 catch (Exception e)
                 {
                     Logger.Write(
-                        LogLevel.Error, 
+                        LogLevel.Error,
                         string.Format(
                             "Exception caught while trying to change database context to [{0}] for OwnerUri [{1}]. Exception:{2}", 
                             newDatabaseName, 

src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectParamsExtensions.cs

@@ -18,37 +18,30 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection.Contracts
             errorMessage = string.Empty;
             if (string.IsNullOrEmpty(parameters.OwnerUri))
             {
-                errorMessage = "Error: OwnerUri cannot be null or empty."; 
+                errorMessage = SR.ConnectionParamsValidateNullOwnerUri; 
             }
             else if (parameters.Connection == null)
             {
-                errorMessage = "Error: Connection details object cannot be null.";
+                errorMessage = SR.ConnectionParamsValidateNullConnection;
             }
             else if (string.IsNullOrEmpty(parameters.Connection.ServerName))
             {
-                errorMessage = "Error: ServerName cannot be null or empty.";
+                errorMessage = SR.ConnectionParamsValidateNullServerName;
             }
             else if (string.IsNullOrEmpty(parameters.Connection.AuthenticationType) || parameters.Connection.AuthenticationType == "SqlLogin")
             {
                 // For SqlLogin, username/password cannot be empty
                 if (string.IsNullOrEmpty(parameters.Connection.UserName))
                 {
-                    errorMessage = "Error: UserName cannot be null or empty when using SqlLogin authentication.";
+                    errorMessage = SR.ConnectionParamsValidateNullSqlAuth("UserName");
                 }
                 else if( string.IsNullOrEmpty(parameters.Connection.Password))
                 {
-                    errorMessage = "Error: Password cannot be null or empty when using SqlLogin authentication.";
+                    errorMessage = SR.ConnectionParamsValidateNullSqlAuth("Password");
                 }
             }
 
-            if (string.IsNullOrEmpty(errorMessage))
-            {
-                return true;
-            }
-            else
-            {
-                return false;
-            }
+            return string.IsNullOrEmpty(errorMessage);
         }
     }
 }

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/AmbientSettings.cs

@@ -6,7 +6,7 @@
 using System;
 using System.Collections.Generic;
 using System.Reflection;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/CachedServerInfo.cs

@@ -8,7 +8,7 @@ using System.Collections.Concurrent;
 using System.Data;
 using System.Data.SqlClient;
 using System.Linq;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/DbCommandWrapper.cs

@@ -6,7 +6,7 @@
 using System;
 using System.Data;
 using System.Data.SqlClient;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/DbConnectionWrapper.cs

@@ -6,7 +6,7 @@
 using System;
 using System.Data;
 using System.Data.SqlClient;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/ReliableConnectionHelper.cs

@@ -11,7 +11,7 @@ using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Security;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/ReliableSqlConnection.cs

@@ -31,7 +31,7 @@ using System.Data.SqlClient;
 using System.Diagnostics;
 using System.Globalization;
 using System.Text;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.DataTransferDetectionErrorStrategy.cs

@@ -4,7 +4,7 @@
 //
 
 using System.Data.SqlClient;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicy.cs

@@ -29,7 +29,7 @@ using System.Diagnostics;
 using System.Diagnostics.Contracts;
 using System.Globalization;
 using System.Threading;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicyFactory.cs

@@ -6,7 +6,7 @@
 using System;
 using System.Diagnostics;
 using System.Globalization;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {

src/Microsoft.SqlTools.ServiceLayer/Connection/ReliableConnection/RetryPolicyUtils.cs

@@ -6,7 +6,7 @@
 using System;
 using System.Collections.Generic;
 using System.Data.SqlClient;
-using Microsoft.SqlTools.EditorServices.Utility;
+using Microsoft.SqlTools.ServiceLayer.Utility;
 
 namespace Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection
 {