From 45cb5f28fde4f4dc27a43c38b19f8ec807f24a4d Mon Sep 17 00:00:00 2001
From: Charles Gagnon <chgagnon@microsoft.com>
Date: Thu, 26 May 2022 14:41:50 -0700
Subject: [PATCH] Enable nullable (#1515)

---
 Directory.Build.props                         |  1 +
 .../Microsoft.SqlTools.CoreServices.csproj    |  1 +
 .../Microsoft.InsightsGenerator.csproj        |  3 +-
 .../Microsoft.SqlTools.Hosting.csproj         |  3 +-
 ...soft.SqlTools.ResourceProvider.Core.csproj |  1 +
 ...lTools.ResourceProvider.DefaultImpl.csproj | 59 ++++++++++---------
 6 files changed, 37 insertions(+), 31 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 7a474b3d..a8b019b7 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -13,5 +13,6 @@
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <!-- This is required for IDE0005 to fail the build https://github.com/dotnet/roslyn/issues/41640 -->
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 </Project>
diff --git a/external/Microsoft.SqlTools.CoreServices/Microsoft.SqlTools.CoreServices.csproj b/external/Microsoft.SqlTools.CoreServices/Microsoft.SqlTools.CoreServices.csproj
index 1cb617a0..3281bdfd 100644
--- a/external/Microsoft.SqlTools.CoreServices/Microsoft.SqlTools.CoreServices.csproj
+++ b/external/Microsoft.SqlTools.CoreServices/Microsoft.SqlTools.CoreServices.csproj
@@ -2,6 +2,7 @@
 	<PropertyGroup>
 		<OutputType>Library</OutputType>
 		<TargetFramework>netstandard2.0</TargetFramework>
+		<Nullable>disable</Nullable>
 		<PackageId>Microsoft.SqlTools.CoreServices</PackageId>
 		<AssemblyName>Microsoft.SqlTools.CoreServices</AssemblyName>
 		<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
diff --git a/src/Microsoft.InsightsGenerator/Microsoft.InsightsGenerator.csproj b/src/Microsoft.InsightsGenerator/Microsoft.InsightsGenerator.csproj
index 6776c9e9..b9f0eca6 100644
--- a/src/Microsoft.InsightsGenerator/Microsoft.InsightsGenerator.csproj
+++ b/src/Microsoft.InsightsGenerator/Microsoft.InsightsGenerator.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFramework>netstandard2.0</TargetFramework>
+		<Nullable>disable</Nullable>
 		<EnableDefaultItems>false</EnableDefaultItems>
 		<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
 		<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
@@ -15,7 +16,7 @@
 	</ItemGroup>
 	<ItemGroup>
 	  <Content Include="Templates\Templates.txt">
-	    <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+		<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
 	  </Content>
 	</ItemGroup>
 </Project>
diff --git a/src/Microsoft.SqlTools.Hosting/Microsoft.SqlTools.Hosting.csproj b/src/Microsoft.SqlTools.Hosting/Microsoft.SqlTools.Hosting.csproj
index 695831b7..00835664 100644
--- a/src/Microsoft.SqlTools.Hosting/Microsoft.SqlTools.Hosting.csproj
+++ b/src/Microsoft.SqlTools.Hosting/Microsoft.SqlTools.Hosting.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFramework>netstandard2.0</TargetFramework>
+		<Nullable>disable</Nullable>
 		<EnableDefaultItems>false</EnableDefaultItems>
 		<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
 		<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
@@ -25,4 +26,4 @@
 		<EmbeddedResource Include="Localization\*.resx" />
 		<None Include="Localization\sr.strings" />
 	</ItemGroup>
-</Project>
+</Project>
\ No newline at end of file
diff --git a/src/Microsoft.SqlTools.ResourceProvider.Core/Microsoft.SqlTools.ResourceProvider.Core.csproj b/src/Microsoft.SqlTools.ResourceProvider.Core/Microsoft.SqlTools.ResourceProvider.Core.csproj
index e688aeaf..bd8270b9 100644
--- a/src/Microsoft.SqlTools.ResourceProvider.Core/Microsoft.SqlTools.ResourceProvider.Core.csproj
+++ b/src/Microsoft.SqlTools.ResourceProvider.Core/Microsoft.SqlTools.ResourceProvider.Core.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFramework>netstandard2.0</TargetFramework>
+		<Nullable>disable</Nullable>
 		<PackageId>Microsoft.SqlTools.ResourceProvider.Core</PackageId>
 		<AssemblyName>Microsoft.SqlTools.ResourceProvider.Core</AssemblyName>
 		<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
diff --git a/src/Microsoft.SqlTools.ResourceProvider.DefaultImpl/Microsoft.SqlTools.ResourceProvider.DefaultImpl.csproj b/src/Microsoft.SqlTools.ResourceProvider.DefaultImpl/Microsoft.SqlTools.ResourceProvider.DefaultImpl.csproj
index 16c7e0e7..f8c45048 100644
--- a/src/Microsoft.SqlTools.ResourceProvider.DefaultImpl/Microsoft.SqlTools.ResourceProvider.DefaultImpl.csproj
+++ b/src/Microsoft.SqlTools.ResourceProvider.DefaultImpl/Microsoft.SqlTools.ResourceProvider.DefaultImpl.csproj
@@ -1,31 +1,32 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
-    <PackageId>Microsoft.SqlTools.ResourceProvider.DefaultImpl</PackageId>
-    <AssemblyName>Microsoft.SqlTools.ResourceProvider.DefaultImpl</AssemblyName>
-    <EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
-    <EmbeddedResourceUseDependentUponConvention>false</EmbeddedResourceUseDependentUponConvention>
-    <ApplicationIcon />
-    <OutputType>Library</OutputType>
-    <StartupObject />
-    <Description>Provides the default  for SqlTools applications.</Description>
-    <Copyright>� Microsoft Corporation. All rights reserved.</Copyright>
-  </PropertyGroup>
-  <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.ResourceManager" />
-    <PackageReference Include="Microsoft.Rest.ClientRuntime" />
-    <PackageReference Include="Microsoft.Rest.ClientRuntime.Azure" />
-    <PackageReference Include="Microsoft.Extensions.DependencyModel" />
-    <PackageReference Include="System.Runtime.Loader" />
-    <PackageReference Include="System.Composition"/>
-    <PackageReference Include="Microsoft.Azure.Management.Sql"/>
-  </ItemGroup>
-  <ItemGroup>
-    <ProjectReference Include="..\Microsoft.SqlTools.ResourceProvider.Core\Microsoft.SqlTools.ResourceProvider.Core.csproj" />
-    <ProjectReference Include="..\Microsoft.SqlTools.Hosting\Microsoft.SqlTools.Hosting.csproj" />
-  </ItemGroup>
-  <ItemGroup>
-    <EmbeddedResource Include="Localization\*.resx" />
-    <None Include="Localization\sr.strings" />
-  </ItemGroup>
+	<PropertyGroup>
+		<TargetFramework>netstandard2.0</TargetFramework>
+		<Nullable>disable</Nullable>
+		<PackageId>Microsoft.SqlTools.ResourceProvider.DefaultImpl</PackageId>
+		<AssemblyName>Microsoft.SqlTools.ResourceProvider.DefaultImpl</AssemblyName>
+		<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
+		<EmbeddedResourceUseDependentUponConvention>false</EmbeddedResourceUseDependentUponConvention>
+		<ApplicationIcon />
+		<OutputType>Library</OutputType>
+		<StartupObject />
+		<Description>Provides the default  for SqlTools applications.</Description>
+		<Copyright>� Microsoft Corporation. All rights reserved.</Copyright>
+	</PropertyGroup>
+	<ItemGroup>
+		<PackageReference Include="Microsoft.Azure.Management.ResourceManager" />
+		<PackageReference Include="Microsoft.Rest.ClientRuntime" />
+		<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure" />
+		<PackageReference Include="Microsoft.Extensions.DependencyModel" />
+		<PackageReference Include="System.Runtime.Loader" />
+		<PackageReference Include="System.Composition" />
+		<PackageReference Include="Microsoft.Azure.Management.Sql" />
+	</ItemGroup>
+	<ItemGroup>
+		<ProjectReference Include="..\Microsoft.SqlTools.ResourceProvider.Core\Microsoft.SqlTools.ResourceProvider.Core.csproj" />
+		<ProjectReference Include="..\Microsoft.SqlTools.Hosting\Microsoft.SqlTools.Hosting.csproj" />
+	</ItemGroup>
+	<ItemGroup>
+		<EmbeddedResource Include="Localization\*.resx" />
+		<None Include="Localization\sr.strings" />
+	</ItemGroup>
 </Project>
\ No newline at end of file