Revert "Scripting should await result of requestcontext.sendresult in case it errors" (#526)

* Revert "Add rowcount check so that no results error is sent for a query where no rows are returned (#525)"

This reverts commit 3392f93a2e.

* Revert "Add unknown status for DB Nodes whose status is not known (#524)"

This reverts commit 3d7b87eca2.

* Revert "Should await result of requestcontext.sendresult in case it errors (#520)"

This reverts commit caf196ea31.
This commit is contained in:
Karl Burtram
2017-10-25 13:34:45 -07:00
committed by GitHub
parent 3392f93a2e
commit 4d04bff810
6 changed files with 43 additions and 130 deletions

View File

@@ -2405,14 +2405,6 @@ namespace Microsoft.SqlTools.ServiceLayer
}
}
public static string ScriptingUnexpectedError
{
get
{
return Keys.GetString(Keys.ScriptingUnexpectedError);
}
}
public static string unavailable
{
get
@@ -4608,9 +4600,6 @@ namespace Microsoft.SqlTools.ServiceLayer
public const string ScriptingListObjectsCompleteParams_ConnectionString_Property_Invalid = "ScriptingListObjectsCompleteParams_ConnectionString_Property_Invalid";
public const string ScriptingUnexpectedError = "ScriptingUnexpectedError";
public const string unavailable = "unavailable";

View File

@@ -1380,10 +1380,6 @@
<value>Error parsing ScriptingListObjectsCompleteParams.ConnectionString property.</value>
<comment></comment>
</data>
<data name="ScriptingUnexpectedError" xml:space="preserve">
<value>Unexpected error while scripting: no result returned from script operation.</value>
<comment></comment>
</data>
<data name="unavailable" xml:space="preserve">
<value>Unavailable</value>
<comment></comment>

View File

@@ -690,8 +690,6 @@ ScriptingParams_FilePath_Property_Invalid = Invalid directory specified by the S
ScriptingListObjectsCompleteParams_ConnectionString_Property_Invalid = Error parsing ScriptingListObjectsCompleteParams.ConnectionString property.
ScriptingUnexpectedError = Unexpected error while scripting: no result returned from script operation.

View File

@@ -2311,11 +2311,6 @@
<note>.
Parameters: 0 - value (string), 1 - columnType (string) </note>
</trans-unit>
<trans-unit id="ScriptingUnexpectedError">
<source>Unexpected error while scripting: no result returned from script operation.</source>
<target state="new">Unexpected error while scripting: no result returned from script operation.</target>
<note></note>
</trans-unit>
</body>
</file>
</xliff>