edit/commit Command (#262)

The main goal of this feature is to enable a command that will
1) Generate a parameterized command for each edit that is in the session
2) Execute that command against the server
3) Update the cached results of the table/view that's being edited with the committed changes (including computed/identity columns)

There's some secret sauce in here where I cheated around worrying about gaps in the updated results. This was accomplished by implementing an IComparable for row edit objects that ensures deletes are the *last* actions to occur and that they occur from the bottom of the list up (highest row ID to lowest). Thus, all other actions that are dependent on the row ID are performed first, then the largest row ID is deleted, then next largest, etc. Nevertheless, by the end of a commit the associated ResultSet is still the source of truth. It is expected that the results grid will need updating once changes are committed.

Also worth noting, although this pull request supports a "many edits, one commit" approach, it will work just fine for a "one edit, one commit" approach.

* WIP

* Adding basic commit support. Deletions work!

* Nailing down the commit logic, insert commits work!

* Updates work!

* Fixing bug in DbColumnWrapper IsReadOnly setting

* Comments

* ResultSet unit tests, fixing issue with seeking in mock writers

* Unit tests for RowCreate commands

* Unit tests for RowDelete

* RowUpdate unit tests

* Session and edit base tests

* Fixing broken unit tests

* Moving constants to constants file

* Addressing code review feedback

* Fixes from merge issues, string consts

* Removing ad-hoc code

* fixing as per @abist requests

* Fixing a couple more issues

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.es.resx

@@ -1,18 +1,96 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
+  <!-- 
+    Microsoft ResX Schema 
+    
+    Version 2.0
+    
+    The primary goals of this format is to allow a simple XML format 
+    that is mostly human readable. The generation and parsing of the 
+    various data types are done through the TypeConverter classes 
+    associated with the data types.
+    
+    Example:
+    
+    ... ado.net/XML headers & schema ...
+    <resheader name="resmimetype">text/microsoft-resx</resheader>
+    <resheader name="version">2.0</resheader>
+    <resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
+    <resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
+    <data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
+    <data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
+    <data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
+        <value>[base64 mime encoded serialized .NET Framework object]</value>
+    </data>
+    <data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
+        <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
+        <comment>This is a comment</comment>
+    </data>
+                
+    There are any number of "resheader" rows that contain simple 
+    name/value pairs.
+    
+    Each data row contains a name, and value. The row also contains a 
+    type or mimetype. Type corresponds to a .NET class that support 
+    text/value conversion through the TypeConverter architecture. 
+    Classes that don't support this are serialized and stored with the 
+    mimetype set.
+    
+    The mimetype is used for serialized objects, and tells the 
+    ResXResourceReader how to depersist the object. This is currently not 
+    extensible. For a given mimetype the value must be set accordingly:
+    
+    Note - application/x-microsoft.net.object.binary.base64 is the format 
+    that the ResXResourceWriter will generate, however the reader can 
+    read any of the formats listed below.
+    
+    mimetype: application/x-microsoft.net.object.binary.base64
+    value   : The object must be serialized with 
+            : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
+            : and then encoded with base64 encoding.
+    
+    mimetype: application/x-microsoft.net.object.soap.base64
+    value   : The object must be serialized with 
+            : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
+            : and then encoded with base64 encoding.
+
+    mimetype: application/x-microsoft.net.object.bytearray.base64
+    value   : The object must be serialized into a byte array 
+            : using a System.ComponentModel.TypeConverter
+            : and then encoded with base64 encoding.
+    -->
   <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
+    <xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
     <xsd:element name="root" msdata:IsDataSet="true">
       <xsd:complexType>
         <xsd:choice maxOccurs="unbounded">
+          <xsd:element name="metadata">
+            <xsd:complexType>
+              <xsd:sequence>
+                <xsd:element name="value" type="xsd:string" minOccurs="0" />
+              </xsd:sequence>
+              <xsd:attribute name="name" use="required" type="xsd:string" />
+              <xsd:attribute name="type" type="xsd:string" />
+              <xsd:attribute name="mimetype" type="xsd:string" />
+              <xsd:attribute ref="xml:space" />
+            </xsd:complexType>
+          </xsd:element>
+          <xsd:element name="assembly">
+            <xsd:complexType>
+              <xsd:attribute name="alias" type="xsd:string" />
+              <xsd:attribute name="name" type="xsd:string" />
+            </xsd:complexType>
+          </xsd:element>
           <xsd:element name="data">
             <xsd:complexType>
               <xsd:sequence>
                 <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
                 <xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
               </xsd:sequence>
-              <xsd:attribute name="name" type="xsd:string" msdata:Ordinal="1" />
+              <xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
               <xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
               <xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
+              <xsd:attribute ref="xml:space" />
             </xsd:complexType>
           </xsd:element>
           <xsd:element name="resheader">
@@ -27,5 +105,19 @@
       </xsd:complexType>
     </xsd:element>
   </xsd:schema>
-<resheader name="resmimetype"><value>text/microsoft-resx</value></resheader><resheader name="version"><value>1.3</value></resheader><resheader name="reader"><value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value></resheader><resheader name="writer"><value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value></resheader><data name="TestLocalizationConstant"><value>ES_LOCALIZATION</value></data>
-  </root>
+  <resheader name="resmimetype">
+    <value>text/microsoft-resx</value>
+  </resheader>
+  <resheader name="version">
+    <value>2.0</value>
+  </resheader>
+  <resheader name="reader">
+    <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </resheader>
+  <resheader name="writer">
+    <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </resheader>
+  <data name="TestLocalizationConstant" xml:space="preserve">
+    <value>ES_LOCALIZATION</value>
+  </data>
+</root>

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx

@@ -120,423 +120,431 @@
   <data name="ConnectionServiceConnectErrorNullParams" xml:space="preserve">
     <value>Connection parameters cannot be null</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ConnectionServiceListDbErrorNullOwnerUri" xml:space="preserve">
     <value>OwnerUri cannot be null or empty</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ConnectionServiceListDbErrorNotConnected" xml:space="preserve">
     <value>SpecifiedUri '{0}' does not have existing connection</value>
     <comment>.
  Parameters: 0 - uri (string) </comment>
-  </data>
+  </data>
   <data name="ConnectionServiceDbErrorDefaultNotConnected" xml:space="preserve">
     <value>Specified URI '{0}' does not have a default connection</value>
     <comment>.
  Parameters: 0 - uri (string) </comment>
-  </data>
+  </data>
   <data name="ConnectionServiceConnStringInvalidAuthType" xml:space="preserve">
     <value>Invalid value '{0}' for AuthenticationType.  Valid values are 'Integrated' and 'SqlLogin'.</value>
     <comment>.
  Parameters: 0 - authType (string) </comment>
-  </data>
+  </data>
   <data name="ConnectionServiceConnStringInvalidIntent" xml:space="preserve">
     <value>Invalid value '{0}' for ApplicationIntent. Valid values are 'ReadWrite' and 'ReadOnly'.</value>
     <comment>.
  Parameters: 0 - intent (string) </comment>
-  </data>
+  </data>
   <data name="ConnectionServiceConnectionCanceled" xml:space="preserve">
     <value>Connection canceled</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ConnectionParamsValidateNullOwnerUri" xml:space="preserve">
     <value>OwnerUri cannot be null or empty</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ConnectionParamsValidateNullConnection" xml:space="preserve">
     <value>Connection details object cannot be null</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ConnectionParamsValidateNullServerName" xml:space="preserve">
     <value>ServerName cannot be null or empty</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ConnectionParamsValidateNullSqlAuth" xml:space="preserve">
     <value>{0} cannot be null or empty when using SqlLogin authentication</value>
     <comment>.
  Parameters: 0 - component (string) </comment>
-  </data>
+  </data>
   <data name="ErrorUnexpectedCodeObjectType" xml:space="preserve">
     <value>Cannot convert SqlCodeObject Type {0} to Type {1}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceCancelAlreadyCompleted" xml:space="preserve">
     <value>The query has already completed, it cannot be cancelled</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceCancelDisposeFailed" xml:space="preserve">
     <value>Query successfully cancelled, failed to dispose query. Owner URI not found.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceQueryCancelled" xml:space="preserve">
     <value>Query was canceled by user</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSubsetBatchNotCompleted" xml:space="preserve">
     <value>The batch has not completed, yet</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSubsetBatchOutOfRange" xml:space="preserve">
     <value>Batch index cannot be less than 0 or greater than the number of batches</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSubsetResultSetOutOfRange" xml:space="preserve">
     <value>Result set index cannot be less than 0 or greater than the number of result sets</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceDataReaderByteCountInvalid" xml:space="preserve">
     <value>Maximum number of bytes to return must be greater than zero</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceDataReaderCharCountInvalid" xml:space="preserve">
     <value>Maximum number of chars to return must be greater than zero</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceDataReaderXmlCountInvalid" xml:space="preserve">
     <value>Maximum number of XML bytes to return must be greater than zero</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceFileWrapperWriteOnly" xml:space="preserve">
     <value>Access method cannot be write-only</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceFileWrapperNotInitialized" xml:space="preserve">
     <value>FileStreamWrapper must be initialized before performing operations</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceFileWrapperReadOnly" xml:space="preserve">
     <value>This FileStreamWrapper cannot be used for writing</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceAffectedOneRow" xml:space="preserve">
     <value>(1 row affected)</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceAffectedRows" xml:space="preserve">
     <value>({0} rows affected)</value>
     <comment>.
  Parameters: 0 - rows (long) </comment>
-  </data>
+  </data>
   <data name="QueryServiceCompletedSuccessfully" xml:space="preserve">
     <value>Commands completed successfully.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceErrorFormat" xml:space="preserve">
     <value>Msg {0}, Level {1}, State {2}, Line {3}{4}{5}</value>
     <comment>.
  Parameters: 0 - msg (int), 1 - lvl (int), 2 - state (int), 3 - line (int), 4 - newLine (string), 5 - message (string) </comment>
-  </data>
+  </data>
   <data name="QueryServiceQueryFailed" xml:space="preserve">
     <value>Query failed: {0}</value>
     <comment>.
  Parameters: 0 - message (string) </comment>
-  </data>
+  </data>
   <data name="QueryServiceColumnNull" xml:space="preserve">
     <value>(No column name)</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceRequestsNoQuery" xml:space="preserve">
     <value>The requested query does not exist</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceQueryInvalidOwnerUri" xml:space="preserve">
     <value>This editor is not connected to a database</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceQueryInProgress" xml:space="preserve">
     <value>A query is already in progress for this editor session. Please cancel this query or wait for its completion.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceMessageSenderNotSql" xml:space="preserve">
     <value>Sender for OnInfoMessage event must be a SqlConnection</value>
     <comment></comment>
-  </data>
-  <data name="QueryServiceResultSetReaderNull" xml:space="preserve">
-    <value>Reader cannot be null</value>
+  </data>
+  <data name="QueryServiceResultSetAddNoRows" xml:space="preserve">
+    <value>Cannot add row to result buffer, data reader does not contain rows</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSaveAsResultSetNotComplete" xml:space="preserve">
     <value>Result cannot be saved until query execution has completed</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSaveAsMiscStartingError" xml:space="preserve">
     <value>Internal error occurred while starting save task</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSaveAsInProgress" xml:space="preserve">
     <value>A save request to the same path is in progress</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceSaveAsFail" xml:space="preserve">
     <value>Failed to save {0}: {1}</value>
     <comment>.
  Parameters: 0 - fileName (string), 1 - message (string) </comment>
-  </data>
+  </data>
   <data name="QueryServiceResultSetNotRead" xml:space="preserve">
     <value>Cannot read subset unless the results have been read from the server</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceResultSetStartRowOutOfRange" xml:space="preserve">
     <value>Start row cannot be less than 0 or greater than the number of rows in the result set</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceResultSetRowCountOutOfRange" xml:space="preserve">
     <value>Row count must be a positive integer</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceResultSetNoColumnSchema" xml:space="preserve">
     <value>Could not retrieve column schema for result set</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="QueryServiceExecutionPlanNotFound" xml:space="preserve">
     <value>Could not retrieve an execution plan from the result set </value>
     <comment></comment>
-  </data>
+  </data>
   <data name="PeekDefinitionAzureError" xml:space="preserve">
     <value>This feature is currently not supported on Azure SQL DB and Data Warehouse: {0}</value>
     <comment>.
  Parameters: 0 - errorMessage (string) </comment>
-  </data>
+  </data>
   <data name="PeekDefinitionError" xml:space="preserve">
     <value>An unexpected error occurred during Peek Definition execution: {0}</value>
     <comment>.
  Parameters: 0 - errorMessage (string) </comment>
-  </data>
+  </data>
   <data name="PeekDefinitionNoResultsError" xml:space="preserve">
     <value>No results were found.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="PeekDefinitionDatabaseError" xml:space="preserve">
     <value>No database object was retrieved.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="PeekDefinitionNotConnectedError" xml:space="preserve">
     <value>Please connect to a server.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="PeekDefinitionTimedoutError" xml:space="preserve">
     <value>Operation timed out.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="PeekDefinitionTypeNotSupportedError" xml:space="preserve">
     <value>This object type is currently not supported by this feature.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="ErrorEmptyStringReplacement" xml:space="preserve">
     <value>Replacement of an empty string by an empty string.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="WorkspaceServicePositionLineOutOfRange" xml:space="preserve">
     <value>Position is outside of file line range</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="WorkspaceServicePositionColumnOutOfRange" xml:space="preserve">
     <value>Position is outside of column range for line {0}</value>
     <comment>.
  Parameters: 0 - line (int) </comment>
-  </data>
+  </data>
   <data name="WorkspaceServiceBufferPositionOutOfOrder" xml:space="preserve">
     <value>Start position ({0}, {1}) must come before or be equal to the end position ({2}, {3})</value>
     <comment>.
  Parameters: 0 - sLine (int), 1 - sCol (int), 2 - eLine (int), 3 - eCol (int) </comment>
-  </data>
+  </data>
   <data name="EditDataSessionNotFound" xml:space="preserve">
     <value>Edit session does not exist.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataUnsupportedObjectType" xml:space="preserve">
     <value>Database object {0} cannot be used for editing.</value>
     <comment>.
  Parameters: 0 - typeName (string) </comment>
-  </data>
+  </data>
   <data name="EditDataQueryNotCompleted" xml:space="preserve">
     <value>Query has not completed execution</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataQueryImproperResultSets" xml:space="preserve">
     <value>Query did not generate exactly one result set</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataFailedAddRow" xml:space="preserve">
     <value>Failed to add new row to update cache</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataRowOutOfRange" xml:space="preserve">
     <value>Given row ID is outside the range of rows in the edit cache</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataUpdatePending" xml:space="preserve">
     <value>An update is already pending for this row and must be reverted first</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataUpdateNotPending" xml:space="preserve">
     <value>Given row ID does not have pending updated</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataObjectMetadataNotFound" xml:space="preserve">
     <value>Table or view metadata could not be found</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataInvalidFormatBinary" xml:space="preserve">
     <value>Invalid format for binary column</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataInvalidFormatBoolean" xml:space="preserve">
     <value>Allowed values for boolean columns are 0, 1, "true", or "false"</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataCreateScriptMissingValue" xml:space="preserve">
     <value>A required cell value is missing</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataDeleteSetCell" xml:space="preserve">
     <value>A delete is pending for this row, a cell update cannot be applied.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataColumnIdOutOfRange" xml:space="preserve">
     <value>Column ID must be in the range of columns for the query</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataColumnCannotBeEdited" xml:space="preserve">
     <value>Column cannot be edited</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataColumnNoKeyColumns" xml:space="preserve">
     <value>No key columns were found</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EditDataScriptFilePathNull" xml:space="preserve">
     <value>An output filename must be provided</value>
     <comment></comment>
-  </data>
+  </data>
+  <data name="EditDataCommitInProgress" xml:space="preserve">
+    <value>A commit task is in progress. Please wait for completion.</value>
+    <comment></comment>
+  </data>
   <data name="EE_BatchSqlMessageNoProcedureInfo" xml:space="preserve">
     <value>Msg {0}, Level {1}, State {2}, Line {3}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_BatchSqlMessageWithProcedureInfo" xml:space="preserve">
     <value>Msg {0}, Level {1}, State {2}, Procedure {3}, Line {4}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_BatchSqlMessageNoLineInfo" xml:space="preserve">
     <value>Msg {0}, Level {1}, State {2}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_BatchError_Exception" xml:space="preserve">
     <value>An error occurred while the batch was being processed. The error message is: {0}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_BatchExecutionInfo_RowsAffected" xml:space="preserve">
     <value>({0} row(s) affected)</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ExecutionNotYetCompleteError" xml:space="preserve">
     <value>The previous execution is not yet complete.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ScriptError_Error" xml:space="preserve">
     <value>A scripting error occurred.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ScriptError_ParsingSyntax" xml:space="preserve">
     <value>Incorrect syntax was encountered while {0} was being parsed.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ScriptError_FatalError" xml:space="preserve">
     <value>A fatal error occurred.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ExecutionInfo_FinalizingLoop" xml:space="preserve">
     <value>Execution completed {0} times...</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ExecutionInfo_QueryCancelledbyUser" xml:space="preserve">
     <value>You cancelled the query.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_BatchExecutionError_Halting" xml:space="preserve">
     <value>An error occurred while the batch was being executed.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_BatchExecutionError_Ignoring" xml:space="preserve">
     <value>An error occurred while the batch was being executed, but the error has been ignored.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ExecutionInfo_InitilizingLoop" xml:space="preserve">
     <value>Starting execution loop of {0} times...</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ExecutionError_CommandNotSupported" xml:space="preserve">
     <value>Command {0} is not supported.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ExecutionError_VariableNotFound" xml:space="preserve">
     <value>The variable {0} could not be found.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParserWrapperExecutionEngineError" xml:space="preserve">
     <value>SQL Execution error: {0}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParserWrapperExecutionError" xml:space="preserve">
     <value>Batch parser wrapper execution: {0} found... at line {1}: {2}    Description: {3}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParserWrapperExecutionEngineBatchMessage" xml:space="preserve">
     <value>Batch parser wrapper execution engine batch message received:  Message: {0}    Detailed message: {1}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParserWrapperExecutionEngineBatchResultSetProcessing" xml:space="preserve">
     <value>Batch parser wrapper execution engine batch ResultSet processing: DataReader.FieldCount: {0}  DataReader.RecordsAffected: {1}</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParserWrapperExecutionEngineBatchResultSetFinished" xml:space="preserve">
     <value>Batch parser wrapper execution engine batch ResultSet finished.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParserWrapperExecutionEngineBatchCancelling" xml:space="preserve">
     <value>Canceling batch parser wrapper batch execution.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="EE_ScriptError_Warning" xml:space="preserve">
     <value>Scripting warning.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="TroubleshootingAssistanceMessage" xml:space="preserve">
     <value>For more information about this error, see the troubleshooting topics in the product documentation.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParser_CircularReference" xml:space="preserve">
     <value>File '{0}' recursively included.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParser_CommentNotTerminated" xml:space="preserve">
     <value>Missing end comment mark '*/'.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParser_StringNotTerminated" xml:space="preserve">
     <value>Unclosed quotation mark after the character string.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParser_IncorrectSyntax" xml:space="preserve">
     <value>Incorrect syntax was encountered while parsing '{0}'.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="BatchParser_VariableNotDefined" xml:space="preserve">
     <value>Variable {0} is not defined.</value>
     <comment></comment>
-  </data>
+  </data>
   <data name="TestLocalizationConstant" xml:space="preserve">
     <value>EN_LOCALIZATION</value>
     <comment></comment>
-  </data>
-</root>
+  </data>
+  <data name="SqlScriptFormatterDecimalMissingPrecision" xml:space="preserve">
+    <value>Decimal column is missing numeric precision or numeric scale</value>
+    <comment></comment>
+  </data>
+</root>

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings

@@ -37,7 +37,6 @@ ConnectionServiceConnStringInvalidIntent(string intent) = Invalid value '{0}' fo
 
 ConnectionServiceConnectionCanceled = Connection canceled
 
-######
 ### Connection Params Validation Errors
 
 ConnectionParamsValidateNullOwnerUri = OwnerUri cannot be null or empty
@@ -110,7 +109,7 @@ QueryServiceQueryInProgress = A query is already in progress for this editor ses
 
 QueryServiceMessageSenderNotSql = Sender for OnInfoMessage event must be a SqlConnection
 
-QueryServiceResultSetReaderNull = Reader cannot be null
+QueryServiceResultSetAddNoRows = Cannot add row to result buffer, data reader does not contain rows
 
 ### Save As Requests
 
@@ -199,6 +198,8 @@ EditDataColumnNoKeyColumns = No key columns were found
 
 EditDataScriptFilePathNull = An output filename must be provided
 
+EditDataCommitInProgress = A commit task is in progress. Please wait for completion.
+
 ############################################################################
 # DacFx Resources
 
@@ -264,3 +265,8 @@ BatchParser_VariableNotDefined = Variable {0} is not defined.
 # Workspace Service
 
 TestLocalizationConstant = EN_LOCALIZATION
+
+############################################################################
+# Utilities
+
+SqlScriptFormatterDecimalMissingPrecision = Decimal column is missing numeric precision or numeric scale

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf

@@ -169,11 +169,6 @@
         <target state="new">Sender for OnInfoMessage event must be a SqlConnection</target>
         <note></note>
       </trans-unit>
-      <trans-unit id="QueryServiceResultSetReaderNull">
-        <source>Reader cannot be null</source>
-        <target state="new">Reader cannot be null</target>
-        <note></note>
-      </trans-unit>
       <trans-unit id="QueryServiceSaveAsResultSetNotComplete">
         <source>Result cannot be saved until query execution has completed</source>
         <target state="new">Result cannot be saved until query execution has completed</target>
@@ -526,6 +521,21 @@
         <note>.
  Parameters: 0 - uri (string) </note>
       </trans-unit>
+      <trans-unit id="EditDataCommitInProgress">
+        <source>A commit task is in progress. Please wait for completion.</source>
+        <target state="new">A commit task is in progress. Please wait for completion.</target>
+        <note></note>
+      </trans-unit>
+      <trans-unit id="SqlScriptFormatterDecimalMissingPrecision">
+        <source>Decimal column is missing numeric precision or numeric scale</source>
+        <target state="new">Decimal column is missing numeric precision or numeric scale</target>
+        <note></note>
+      </trans-unit>
+      <trans-unit id="QueryServiceResultSetAddNoRows">
+        <source>Cannot add row to result buffer, data reader does not contain rows</source>
+        <target state="new">Cannot add row to result buffer, data reader does not contain rows</target>
+        <note></note>
+      </trans-unit>
     </body>
   </file>
 </xliff>