ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 18:47:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Catch exception when querying sys.logins without permissions (#1984)

Browse Source
This commit is contained in:
Karl Burtram
2023-04-03 19:27:05 -07:00
committed by GitHub
parent 0b2eb26d45
commit 539ad243c1
1 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Microsoft.SqlTools.ServiceLayer/Utility/DatabaseUtils.cs
View File

@@ -293,6 +293,8 @@ namespace Microsoft.SqlTools.ServiceLayer.Utility
} }
public static string[] LoadItems(ServerConnection serverConnection, string urn) public static string[] LoadItems(ServerConnection serverConnection, string urn)
{
try
{ {
List<string> items = new List<string>(); List<string> items = new List<string>();
Request req = new Request(); Request req = new Request();
@@ -317,5 +319,14 @@ namespace Microsoft.SqlTools.ServiceLayer.Utility
items.Sort(); items.Sort();
return items.ToArray(); return items.ToArray();
} }
catch (Microsoft.SqlServer.Management.Sdk.Sfc.EnumeratorException)
{
// reading Logins can fail when trying to create a contained/SQL DB user
// when the current session does not have permissions to master
// we can return an empty existing login list in this scenario
// no need to log here since this is an expected non-blocking exception that is recoverable
return new string[0];
}
}
} }
} }