ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

handle invalid uri (#1918)

Browse Source
This commit is contained in:
Hai Cao
2023-03-08 13:16:14 -08:00
committed by GitHub
parent 4450767525
commit 58477c35dc
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Microsoft.SqlTools.ServiceLayer/Security/SecurityService.cs
View File

@@ -121,7 +121,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Security
if (connInfo == null) if (connInfo == null)
{ {
// raise error here throw new ArgumentException("Invalid ConnectionUri");
} }
CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true); CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true);
@@ -168,10 +168,10 @@ namespace Microsoft.SqlTools.ServiceLayer.Security
{ {
ConnectionInfo connInfo; ConnectionInfo connInfo;
ConnectionServiceInstance.TryFindConnection(parameters.ConnectionUri, out connInfo); ConnectionServiceInstance.TryFindConnection(parameters.ConnectionUri, out connInfo);
// if (connInfo == null) if (connInfo == null)
// { {
// // raise an error throw new ArgumentException("Invalid ConnectionUri");
// } }
CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true); CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true);
Login login = dataContainer.Server?.Logins[parameters.Name]; Login login = dataContainer.Server?.Logins[parameters.Name];
@@ -194,7 +194,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Security
ConnectionServiceInstance.TryFindConnection(ownerUri, out connInfo); ConnectionServiceInstance.TryFindConnection(ownerUri, out connInfo);
if (connInfo == null) if (connInfo == null)
{ {
// raise error here throw new ArgumentException("Invalid ConnectionUri");
} }
CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true); CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true);
@@ -261,7 +261,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Security
ConnectionServiceInstance.TryFindConnection(parameters.ConnectionUri, out connInfo); ConnectionServiceInstance.TryFindConnection(parameters.ConnectionUri, out connInfo);
if (connInfo == null) if (connInfo == null)
{ {
// raise an error throw new ArgumentException("Invalid ConnectionUri");
} }
CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true); CDataContainer dataContainer = CDataContainer.CreateDataContainer(connInfo, databaseExists: true);
LoginViewInfo loginViewInfo = new LoginViewInfo(); LoginViewInfo loginViewInfo = new LoginViewInfo();