ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Query logins on system database for Azure connections (#2038)

Browse Source 
* Query logins on system database for Azure connections

* Fix name of connection variable
This commit is contained in:
Karl Burtram
2023-05-02 12:46:18 -07:00
committed by GitHub
parent 8d48ff735b
commit 5954bdc65c
1 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypes/User/UserHandler.cs
View File

@@ -177,6 +177,30 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
}
supportedUserTypes.Add(DatabaseUserType.NoLoginAccess);
string[] logins = DatabaseUtils.LoadSqlLogins(dataContainer.ServerConnection);
// If we couldn't load logins on current connection and this is a SQL DB connection
// not to master then try to connect to master. The "sys.sql_logins" DMV is not visible to user databases.
if (logins.Length == 0 && isSqlAzure
&& string.Compare(parameters.Database, "master", true) != 0)
{
ServerConnection masterServerConnection = null;
try
{
originalConnInfo.ConnectionDetails.DatabaseName = "master";
masterServerConnection = ConnectionService.OpenServerConnection(originalConnInfo, "MasterDataContainer");
logins = DatabaseUtils.LoadSqlLogins(masterServerConnection);
}
finally
{
originalConnInfo.ConnectionDetails.DatabaseName = originalDatabaseName;
if (masterServerConnection != null)
{
masterServerConnection.Disconnect();
}
}
}
UserViewInfo userViewInfo = new UserViewInfo()
{
ObjectInfo = new UserInfo()
@@ -193,7 +217,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
UserTypes = supportedUserTypes.ToArray(),
Languages = languageOptionsList.ToArray(),
Schemas = currentUserPrototype.SchemaNames.ToArray(),
Logins = DatabaseUtils.LoadSqlLogins(dataContainer.ServerConnection),
Logins = logins,
DatabaseRoles = currentUserPrototype.DatabaseRoleNames.ToArray()
};
var context = new UserViewContext(parameters, dataContainer.ServerConnection, currentUserPrototype.CurrentState);