From 5d805bd678058c23f9983d416ba8ccf59e1fb4e8 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Mon, 28 Mar 2022 12:20:51 -0700 Subject: [PATCH] remove SchemaComparePublishChangesRequest (#1446) --- .../SchemaComparePublishChangesRequest.cs | 45 ------------------- .../SchemaCompare/SchemaCompareService.cs | 35 --------------- 2 files changed, 80 deletions(-) delete mode 100644 src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/Contracts/SchemaComparePublishChangesRequest.cs diff --git a/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/Contracts/SchemaComparePublishChangesRequest.cs b/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/Contracts/SchemaComparePublishChangesRequest.cs deleted file mode 100644 index 0da9211a..00000000 --- a/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/Contracts/SchemaComparePublishChangesRequest.cs +++ /dev/null @@ -1,45 +0,0 @@ -// -// Copyright (c) Microsoft. All rights reserved. -// Licensed under the MIT license. See LICENSE file in the project root for full license information. -// -using Microsoft.SqlTools.Hosting.Protocol.Contracts; -using Microsoft.SqlTools.ServiceLayer.TaskServices; -using Microsoft.SqlTools.ServiceLayer.Utility; - -namespace Microsoft.SqlTools.ServiceLayer.SchemaCompare.Contracts -{ - /// - /// Parameters for a schema compare publish changes request. - /// - public class SchemaComparePublishChangesParams - { - /// - /// Operation id of the schema compare operation - /// - public string OperationId { get; set; } - - /// - /// Name of target server - /// - public string TargetServerName { get; set; } - - /// - /// Name of target database - /// - public string TargetDatabaseName { get; set; } - - /// - /// Execution mode for the operation. Default is execution - /// - public TaskExecutionMode TaskExecutionMode { get; set; } - } - - /// - /// Defines the Schema Compare publish changes request type - /// - class SchemaComparePublishChangesRequest - { - public static readonly RequestType Type = - RequestType.Create("schemaCompare/publish"); - } -} \ No newline at end of file diff --git a/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/SchemaCompareService.cs b/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/SchemaCompareService.cs index a9e0989b..33bc4470 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/SchemaCompareService.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/SchemaCompareService.cs @@ -51,7 +51,6 @@ namespace Microsoft.SqlTools.ServiceLayer.SchemaCompare serviceHost.SetRequestHandler(SchemaCompareRequest.Type, this.HandleSchemaCompareRequest); serviceHost.SetRequestHandler(SchemaCompareCancellationRequest.Type, this.HandleSchemaCompareCancelRequest); serviceHost.SetRequestHandler(SchemaCompareGenerateScriptRequest.Type, this.HandleSchemaCompareGenerateScriptRequest); - serviceHost.SetRequestHandler(SchemaComparePublishChangesRequest.Type, this.HandleSchemaComparePublishChangesRequest); serviceHost.SetRequestHandler(SchemaComparePublishDatabaseChangesRequest.Type, this.HandleSchemaComparePublishDatabaseChangesRequest); serviceHost.SetRequestHandler(SchemaComparePublishProjectChangesRequest.Type, this.HandleSchemaComparePublishProjectChangesRequest); serviceHost.SetRequestHandler(SchemaCompareIncludeExcludeNodeRequest.Type, this.HandleSchemaCompareIncludeExcludeNodeRequest); @@ -196,40 +195,6 @@ namespace Microsoft.SqlTools.ServiceLayer.SchemaCompare } } - /// - /// Handles request for schema compare publish changes script - /// - /// - public async Task HandleSchemaComparePublishChangesRequest(SchemaComparePublishDatabaseChangesParams parameters, RequestContext requestContext) - { - SchemaComparePublishDatabaseChangesOperation operation = null; - try - { - SchemaComparisonResult compareResult = schemaCompareResults.Value[parameters.OperationId]; - operation = new SchemaComparePublishDatabaseChangesOperation(parameters, compareResult); - TaskMetadata metadata = new TaskMetadata(); - metadata.TaskOperation = operation; - metadata.ServerName = parameters.TargetServerName; - metadata.DatabaseName = parameters.TargetDatabaseName; - metadata.Name = SR.PublishChangesTaskName; - SqlTask sqlTask = SqlTaskManagerInstance.CreateAndRun(metadata); - await requestContext.SendResult(new ResultStatus() - { - Success = true, - ErrorMessage = operation.ErrorMessage - }); - } - catch (Exception e) - { - Logger.Write(TraceEventType.Error, "Failed to publish schema compare changes. Error: " + e); - await requestContext.SendResult(new ResultStatus() - { - Success = false, - ErrorMessage = operation == null ? e.Message : operation.ErrorMessage, - }); - } - } - /// /// Handles request for schema compare publish database changes script ///