ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 18:47:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Enable local logging for login migrations (#1846)

Browse Source 
This change allows the login migration nuget to log changes locally..
This commit is contained in:
AkshayMata
2023-02-08 07:10:56 -08:00
committed by GitHub
parent 19935552b1
commit 608f75e761
1 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/Microsoft.SqlTools.Migration/MigrationService.cs
View File

@@ -26,6 +26,9 @@ using Microsoft.SqlServer.Migration.Assessment.Common.Models;
using Microsoft.SqlServer.Migration.Assessment.Common.Utils; using Microsoft.SqlServer.Migration.Assessment.Common.Utils;
using Microsoft.SqlServer.Migration.Logins; using Microsoft.SqlServer.Migration.Logins;
using Microsoft.SqlServer.Migration.Logins.Contracts; using Microsoft.SqlServer.Migration.Logins.Contracts;
using Microsoft.SqlServer.Migration.Logins.Contracts.ErrorHandling;
using Microsoft.SqlServer.Migration.Logins.ErrorHandling;
using Microsoft.SqlServer.Migration.Logins.Helpers;
using Microsoft.SqlServer.Migration.SkuRecommendation; using Microsoft.SqlServer.Migration.SkuRecommendation;
using Microsoft.SqlServer.Migration.SkuRecommendation.Aggregation; using Microsoft.SqlServer.Migration.SkuRecommendation.Aggregation;
using Microsoft.SqlServer.Migration.SkuRecommendation.Billing; using Microsoft.SqlServer.Migration.SkuRecommendation.Billing;
@@ -287,8 +290,9 @@ namespace Microsoft.SqlTools.Migration
{ {
try try
{ {
ILoginsMigrationLogger logger = this.GetLoginsMigrationLogger();
ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString, ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString,
null, parameters.LoginList, parameters.AADDomainName); null, parameters.LoginList, parameters.AADDomainName, logger);
IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>(); IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>();
@@ -319,8 +323,9 @@ namespace Microsoft.SqlTools.Migration
{ {
try try
{ {
ILoginsMigrationLogger logger = this.GetLoginsMigrationLogger();
ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString, ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString,
null, parameters.LoginList, parameters.AADDomainName); null, parameters.LoginList, parameters.AADDomainName, logger);
IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>(); IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>();
Stopwatch stopWatch = new Stopwatch(); Stopwatch stopWatch = new Stopwatch();
@@ -351,8 +356,9 @@ namespace Microsoft.SqlTools.Migration
{ {
try try
{ {
ILoginsMigrationLogger logger = this.GetLoginsMigrationLogger();
ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString, ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString,
null, parameters.LoginList, parameters.AADDomainName); null, parameters.LoginList, parameters.AADDomainName, logger);
IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>(); IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>();
Stopwatch stopWatch = new Stopwatch(); Stopwatch stopWatch = new Stopwatch();
@@ -383,8 +389,9 @@ namespace Microsoft.SqlTools.Migration
{ {
try try
{ {
ILoginsMigrationLogger logger = this.GetLoginsMigrationLogger();
ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString, ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString,
null, parameters.LoginList, parameters.AADDomainName); null, parameters.LoginList, parameters.AADDomainName, logger);
IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>(); IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>();
@@ -416,8 +423,9 @@ namespace Microsoft.SqlTools.Migration
{ {
try try
{ {
ILoginsMigrationLogger logger = this.GetLoginsMigrationLogger();
ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString, ILoginsMigration loginMigration = new LoginsMigration(parameters.SourceConnectionString, parameters.TargetConnectionString,
null, parameters.LoginList, parameters.AADDomainName); null, parameters.LoginList, parameters.AADDomainName, logger);
IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>(); IDictionary<string, IEnumerable<ReportableException>> exceptionMap = new Dictionary<string, IEnumerable<ReportableException>>();
Stopwatch stopWatch = new Stopwatch(); Stopwatch stopWatch = new Stopwatch();
@@ -994,6 +1002,14 @@ namespace Microsoft.SqlTools.Migration
} }
} }
private ILoginsMigrationLogger GetLoginsMigrationLogger()
{
SqlLoginMigrationConfiguration.AllowTelemetry = true;
SqlLoginMigrationConfiguration.EnableLocalLogging = true;
SqlLoginMigrationConfiguration.LogsRootFolderPath = Path.GetDirectoryName(Logger.LogFileFullPath);
return new DefaultLoginsMigrationLogger();
}
/// <summary> /// <summary>
/// Disposes the Migration Service /// Disposes the Migration Service
/// </summary> /// </summary>