Edit Data: Better Formatting Errors (#562)

* Refactoring sql script formatting helpers into To and From helpers

* Updates to make error messages for formatting errors more useful

* Fixing dumb breaks in unit tests

* Addressing comments from PR

* Updates to the SR files...

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings

@@ -208,6 +208,8 @@ EditDataUpdateNotPending = Given row ID does not have pending update
 
 EditDataObjectMetadataNotFound = Table or view metadata could not be found
 
+EditDataInvalidFormat(string colName, string colType) = Invalid format for column '{0}', column is defined as {1}
+
 EditDataInvalidFormatBinary = Invalid format for binary column
 
 EditDataInvalidFormatBoolean = Allowed values for boolean columns are 0, 1, "true", or "false"
@@ -303,7 +305,11 @@ TestLocalizationConstant = test
 ############################################################################
 # Utilities
 
-SqlScriptFormatterDecimalMissingPrecision = Decimal column is missing numeric precision or numeric scale
+SqlScriptFormatterDecimalMissingPrecision = Exact numeric column is missing numeric precision or numeric scale
+
+SqlScriptFormatterLengthTypeMissingSize = Column with length is missing size
+
+SqlScriptFormatterScalarTypeMissingScale = Scalar column missing scale
 
 ############################################################################
 # Object Explorer Service

src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf

@@ -523,7 +523,7 @@
         <note></note>
       </trans-unit>
       <trans-unit id="SqlScriptFormatterDecimalMissingPrecision">
-        <source>Decimal column is missing numeric precision or numeric scale</source>
+        <source>Exact numeric column is missing numeric precision or numeric scale</source>
         <target state="new">Decimal column is missing numeric precision or numeric scale</target>
         <note></note>
       </trans-unit>
@@ -2312,6 +2312,22 @@
         <note>.
  Parameters: 0 - value (string), 1 - columnType (string) </note>
       </trans-unit>
+      <trans-unit id="EditDataInvalidFormat">
+        <source>Invalid format for column '{0}', column is defined as {1}</source>
+        <target state="new">Invalid format for column '{0}', column is defined as {1}</target>
+        <note>.
+ Parameters: 0 - colName (string), 1 - colType (string) </note>
+      </trans-unit>
+      <trans-unit id="SqlScriptFormatterLengthTypeMissingSize">
+        <source>Column with length is missing size</source>
+        <target state="new">Column with length is missing size</target>
+        <note></note>
+      </trans-unit>
+      <trans-unit id="SqlScriptFormatterScalarTypeMissingScale">
+        <source>Scalar column missing scale</source>
+        <target state="new">Scalar column missing scale</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="StoredProcedureScriptParameterComment">
         <source>-- TODO: Set parameter values here.</source>
         <target state="new">-- TODO: Set parameter values here.</target>
@@ -2319,7 +2335,7 @@
       </trans-unit>
       <trans-unit id="ScriptingGeneralError">
         <source>An error occurred while scripting the objects.</source>
-        <target state="new">An error occurred while scripting the objects</target>
+        <target state="new">An error occurred while scripting the objects.</target>
         <note></note>
       </trans-unit>
       <trans-unit id="ScriptingExecuteNotSupportedError">