ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-06 17:24:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding External Streaming Job I/O validation to DacFxService (#1106)

Browse Source 
* checkpoint

* Not having cake, nor eating it

* Working

* Swapping external dll for nupkg

* Extracting statement out of full TSQL

* Improving error message

* Fixing filename capitalization

* Reverting csproj changes

* Adding updated sr.cs file

* VS lost tracking on strings file?

* PR feedback

* resx additions

* More updated string files

* Swapped nuget for dll

* Revert "Swapped nuget for dll"

This reverts commit 6013f3fadf58ebc7e3590a46811d9fd9fc3eaa4a.

* Bumped netcore version to pull in support for extern aliasing nugets
This commit is contained in:
Benjin Dubishar
2020-11-02 12:03:14 -08:00
committed by GitHub
parent d94e691b07
commit 65c4fc01aa
14 changed files with 431 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.cs
View File

@@ -2949,6 +2949,14 @@ namespace Microsoft.SqlTools.ServiceLayer
}
}
public static string ValidateStreamingJobTaskName
{
get
{
return Keys.GetString(Keys.ValidateStreamingJobTaskName);
}
}
public static string ExtractInvalidVersion
{
get
@@ -2957,6 +2965,38 @@ namespace Microsoft.SqlTools.ServiceLayer
}
}
public static string Input
{
get
{
return Keys.GetString(Keys.Input);
}
}
public static string Output
{
get
{
return Keys.GetString(Keys.Output);
}
}
public static string FragmentShouldHaveOnlyOneBatch
{
get
{
return Keys.GetString(Keys.FragmentShouldHaveOnlyOneBatch);
}
}
public static string NoCreateStreamingJobStatementFound
{
get
{
return Keys.GetString(Keys.NoCreateStreamingJobStatementFound);
}
}
public static string PublishChangesTaskName
{
get
@@ -3223,6 +3263,16 @@ namespace Microsoft.SqlTools.ServiceLayer
return Keys.GetString(Keys.ScheduleNameAlreadyExists, scheduleName);
}
public static string StreamNotFoundInModel(string streamType, string missingStreamName)
{
return Keys.GetString(Keys.StreamNotFoundInModel, streamType, missingStreamName);
}
public static string StreamingJobValidationFailed(string jobName)
{
return Keys.GetString(Keys.StreamingJobValidationFailed, jobName);
}
public static string SqlAssessmentUnsuppoertedEdition(int editionCode)
{
return Keys.GetString(Keys.SqlAssessmentUnsuppoertedEdition, editionCode);
@@ -4457,9 +4507,30 @@ namespace Microsoft.SqlTools.ServiceLayer
public const string ProjectExtractTaskName = "ProjectExtractTaskName";
public const string ValidateStreamingJobTaskName = "ValidateStreamingJobTaskName";
public const string ExtractInvalidVersion = "ExtractInvalidVersion";
public const string StreamNotFoundInModel = "StreamNotFoundInModel";
public const string Input = "Input";
public const string Output = "Output";
public const string StreamingJobValidationFailed = "StreamingJobValidationFailed";
public const string FragmentShouldHaveOnlyOneBatch = "FragmentShouldHaveOnlyOneBatch";
public const string NoCreateStreamingJobStatementFound = "NoCreateStreamingJobStatementFound";
public const string PublishChangesTaskName = "PublishChangesTaskName";

30
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.resx
View File

@@ -1787,10 +1787,40 @@
<value>Extract project files</value>
<comment></comment>
</data>
<data name="ValidateStreamingJobTaskName" xml:space="preserve">
<value>Validate streaming job</value>
<comment></comment>
</data>
<data name="ExtractInvalidVersion" xml:space="preserve">
<value>Invalid version &apos;{0}&apos; passed. Version must be in the format x.x.x.x where x is a number.</value>
<comment></comment>
</data>
<data name="StreamNotFoundInModel" xml:space="preserve">
<value>Streaming query statement contains a reference to missing {0} stream &apos;{1}&apos;. You must add it to the database model.</value>
<comment>.
Parameters: 0 - streamType (string), 1 - missingStreamName (string) </comment>
</data>
<data name="Input" xml:space="preserve">
<value>input</value>
<comment></comment>
</data>
<data name="Output" xml:space="preserve">
<value>output</value>
<comment></comment>
</data>
<data name="StreamingJobValidationFailed" xml:space="preserve">
<value>Validation for external streaming job &apos;{0}&apos; failed:</value>
<comment>.
Parameters: 0 - jobName (string) </comment>
</data>
<data name="FragmentShouldHaveOnlyOneBatch" xml:space="preserve">
<value>TSQL fragment should contain exactly one batch.</value>
<comment></comment>
</data>
<data name="NoCreateStreamingJobStatementFound" xml:space="preserve">
<value>No External Streaming Job creation TSQL found (EXEC sp_create_streaming_job statement).</value>
<comment></comment>
</data>
<data name="PublishChangesTaskName" xml:space="preserve">
<value>Apply schema compare changes</value>
<comment></comment>

7
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.strings
View File

@@ -826,7 +826,14 @@ ExtractDacpacTaskName = Extract dacpac
DeployDacpacTaskName = Deploy dacpac
GenerateScriptTaskName = Generate script
ProjectExtractTaskName = Extract project files
ValidateStreamingJobTaskName = Validate streaming job
ExtractInvalidVersion = Invalid version '{0}' passed. Version must be in the format x.x.x.x where x is a number.
StreamNotFoundInModel(string streamType, string missingStreamName) = Streaming query statement contains a reference to missing {0} stream '{1}'. You must add it to the database model.
Input = input
Output = output
StreamingJobValidationFailed(string jobName) = Validation for external streaming job '{0}' failed:
FragmentShouldHaveOnlyOneBatch = TSQL fragment should contain exactly one batch.
NoCreateStreamingJobStatementFound = No External Streaming Job creation TSQL found (EXEC sp_create_streaming_job statement).
############################################################################
# Schema Compare

37
src/Microsoft.SqlTools.ServiceLayer/Localization/sr.xlf
View File

@@ -2124,6 +2124,43 @@
<target state="new">Extract project files</target>
<note></note>
</trans-unit>
<trans-unit id="ValidateStreamingJobTaskName">
<source>Validate streaming job</source>
<target state="new">Validate streaming job</target>
<note></note>
</trans-unit>
<trans-unit id="StreamNotFoundInModel">
<source>Streaming query statement contains a reference to missing {0} stream '{1}'. You must add it to the database model.</source>
<target state="new">Streaming query statement contains a reference to missing {0} stream '{1}'. You must add it to the database model.</target>
<note>.
Parameters: 0 - streamType (string), 1 - missingStreamName (string) </note>
</trans-unit>
<trans-unit id="Input">
<source>input</source>
<target state="new">input</target>
<note></note>
</trans-unit>
<trans-unit id="Output">
<source>output</source>
<target state="new">output</target>
<note></note>
</trans-unit>
<trans-unit id="StreamingJobValidationFailed">
<source>Validation for external streaming job '{0}' failed:</source>
<target state="new">Validation for external streaming job '{0}' failed:</target>
<note>.
Parameters: 0 - jobName (string) </note>
</trans-unit>
<trans-unit id="FragmentShouldHaveOnlyOneBatch">
<source>TSQL fragment should contain exactly one batch.</source>
<target state="new">TSQL fragment should contain exactly one batch.</target>
<note></note>
</trans-unit>
<trans-unit id="NoCreateStreamingJobStatementFound">
<source>No External Streaming Job creation TSQL found (EXEC sp_create_streaming_job statement).</source>
<target state="new">No External Streaming Job creation TSQL found (EXEC sp_create_streaming_job statement).</target>
<note></note>
</trans-unit>
</body>
</file>
</xliff>