ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-01-13 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

queryStore WaitStatistics options should be a dropdown #24372 (#2228)

Browse Source
This commit is contained in:
Sai Avishkar Sreerama
2023-09-11 12:56:31 -05:00
committed by GitHub
parent 18559ba721
commit 6873b42a6b
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypes/Database/DatabaseHandler.cs
View File

@@ -59,7 +59,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
internal static readonly string[] AzureEditionNames; internal static readonly string[] AzureEditionNames;
internal static readonly string[] AzureBackupLevels; internal static readonly string[] AzureBackupLevels;
internal static readonly string[] DscOnOffOptions; internal static readonly string[] PropertiesOnOffOptions;
internal static readonly string[] DscElevateOptions; internal static readonly string[] DscElevateOptions;
internal static readonly string[] DscEnableDisableOptions; internal static readonly string[] DscEnableDisableOptions;
internal static readonly AzureEditionDetails[] AzureMaxSizes; internal static readonly AzureEditionDetails[] AzureMaxSizes;
@@ -125,13 +125,13 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
displaySizeBasedCleanupMode.TryAdd(QueryStoreSizeBasedCleanupMode.Off, SR.queryStoreSizeBasedCleanupMode_Off); displaySizeBasedCleanupMode.TryAdd(QueryStoreSizeBasedCleanupMode.Off, SR.queryStoreSizeBasedCleanupMode_Off);
displaySizeBasedCleanupMode.TryAdd(QueryStoreSizeBasedCleanupMode.Auto, SR.queryStoreSizeBasedCleanupMode_Auto); displaySizeBasedCleanupMode.TryAdd(QueryStoreSizeBasedCleanupMode.Auto, SR.queryStoreSizeBasedCleanupMode_Auto);
DscOnOffOptions = new[]{ PropertiesOnOffOptions = new[]{
CommonConstants.DatabaseScopedConfigurations_Value_On, CommonConstants.PropertiesDropdown_Value_On,
CommonConstants.DatabaseScopedConfigurations_Value_Off CommonConstants.PropertiesDropdown_Value_Off
}; };
DscElevateOptions = new[]{ DscElevateOptions = new[]{
CommonConstants.DatabaseScopedConfigurations_Value_Off, CommonConstants.PropertiesDropdown_Value_Off,
CommonConstants.DatabaseScopedConfigurations_Value_When_supported, CommonConstants.DatabaseScopedConfigurations_Value_When_supported,
CommonConstants.DatabaseScopedConfigurations_Value_Fail_Unsupported CommonConstants.DatabaseScopedConfigurations_Value_Fail_Unsupported
}; };
@@ -270,7 +270,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
}; };
if (prototype is DatabasePrototype140) if (prototype is DatabasePrototype140)
{ {
((DatabaseInfo)databaseViewInfo.ObjectInfo).QueryStoreOptions!.WaitStatisticsCaptureMode = smoDatabase.QueryStoreOptions.WaitStatsCaptureMode == QueryStoreWaitStatsCaptureMode.On; ((DatabaseInfo)databaseViewInfo.ObjectInfo).QueryStoreOptions!.WaitStatisticsCaptureMode = smoDatabase.QueryStoreOptions.WaitStatsCaptureMode.ToString();
}; };
if (prototype is DatabasePrototype150) if (prototype is DatabasePrototype150)
{ {
@@ -310,7 +310,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
databaseScopedConfigurationsCollection = smoDatabase.IsSupportedObject<DatabaseScopedConfiguration>() ? smoDatabase.DatabaseScopedConfigurations : null; databaseScopedConfigurationsCollection = smoDatabase.IsSupportedObject<DatabaseScopedConfiguration>() ? smoDatabase.DatabaseScopedConfigurations : null;
databaseViewInfo.FileTypesOptions = displayFileTypes.Values.ToArray(); databaseViewInfo.FileTypesOptions = displayFileTypes.Values.ToArray();
} }
databaseViewInfo.DscOnOffOptions = DscOnOffOptions; databaseViewInfo.PropertiesOnOffOptions = PropertiesOnOffOptions;
databaseViewInfo.DscElevateOptions = DscElevateOptions; databaseViewInfo.DscElevateOptions = DscElevateOptions;
databaseViewInfo.DscEnableDisableOptions = DscEnableDisableOptions; databaseViewInfo.DscEnableDisableOptions = DscEnableDisableOptions;
databaseViewInfo.OperationModeOptions = displayOperationModeOptions.Values.ToArray(); databaseViewInfo.OperationModeOptions = displayOperationModeOptions.Values.ToArray();
@@ -804,7 +804,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
db130.QueryStoreOptions.StaleQueryThresholdInDays = database.QueryStoreOptions.StaleQueryThresholdInDays; db130.QueryStoreOptions.StaleQueryThresholdInDays = database.QueryStoreOptions.StaleQueryThresholdInDays;
if (prototype is DatabasePrototype140 db140 && database.QueryStoreOptions.WaitStatisticsCaptureMode != null) if (prototype is DatabasePrototype140 db140 && database.QueryStoreOptions.WaitStatisticsCaptureMode != null)
{ {
db140.QueryStoreOptions.WaitStatsCaptureMode = (bool)database.QueryStoreOptions.WaitStatisticsCaptureMode ? QueryStoreWaitStatsCaptureMode.On : QueryStoreWaitStatsCaptureMode.Off; db140.QueryStoreOptions.WaitStatsCaptureMode = database.QueryStoreOptions.WaitStatisticsCaptureMode == CommonConstants.PropertiesDropdown_Value_On ? QueryStoreWaitStatsCaptureMode.On : QueryStoreWaitStatsCaptureMode.Off;
} }
if (prototype is DatabasePrototype150 db150 && database.QueryStoreOptions.QueryStoreCaptureMode == SR.querystorecapturemode_custom if (prototype is DatabasePrototype150 db150 && database.QueryStoreOptions.QueryStoreCaptureMode == SR.querystorecapturemode_custom

2
src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypes/Database/DatabaseInfo.cs
View File

@@ -91,7 +91,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
public string QueryStoreCaptureMode { get; set; } public string QueryStoreCaptureMode { get; set; }
public string SizeBasedCleanupMode { get; set; } public string SizeBasedCleanupMode { get; set; }
public long StaleQueryThresholdInDays { get; set; } public long StaleQueryThresholdInDays { get; set; }
public bool? WaitStatisticsCaptureMode { get; set; } public string? WaitStatisticsCaptureMode { get; set; }
public QueryStoreCapturePolicyOptions? CapturePolicyOptions { get; set; } public QueryStoreCapturePolicyOptions? CapturePolicyOptions { get; set; }
public long CurrentStorageSizeInMB { get; set; } public long CurrentStorageSizeInMB { get; set; }
} }

2
src/Microsoft.SqlTools.ServiceLayer/ObjectManagement/ObjectTypes/Database/DatabaseViewInfo.cs
View File

@@ -24,7 +24,7 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectManagement
public AzureEditionDetails[] AzureMaxSizes { get; set; } public AzureEditionDetails[] AzureMaxSizes { get; set; }
public string[] PageVerifyOptions { get; set; } public string[] PageVerifyOptions { get; set; }
public string[] RestrictAccessOptions { get; set; } public string[] RestrictAccessOptions { get; set; }
public string[] DscOnOffOptions { get; set; } public string[] PropertiesOnOffOptions { get; set; }
public string[] DscElevateOptions { get; set; } public string[] DscElevateOptions { get; set; }
public string[] DscEnableDisableOptions { get; set; } public string[] DscEnableDisableOptions { get; set; }
public string[] FileTypesOptions { get; set; } public string[] FileTypesOptions { get; set; }

4
src/Microsoft.SqlTools.SqlCore/Utility/CommonConstants.cs
View File

@@ -18,8 +18,8 @@ namespace Microsoft.SqlTools.SqlCore.Utility
public const string DefaultBatchSeperator = "GO"; public const string DefaultBatchSeperator = "GO";
// Database scoped configurations property values // Database scoped configurations property values
public const string DatabaseScopedConfigurations_Value_On = "ON"; public const string PropertiesDropdown_Value_On = "ON";
public const string DatabaseScopedConfigurations_Value_Off = "OFF"; public const string PropertiesDropdown_Value_Off = "OFF";
public const string DatabaseScopedConfigurations_Value_Primary = "PRIMARY"; public const string DatabaseScopedConfigurations_Value_Primary = "PRIMARY";
public const string DatabaseScopedConfigurations_Value_When_supported = "WHEN_SUPPORTED"; public const string DatabaseScopedConfigurations_Value_When_supported = "WHEN_SUPPORTED";
public const string DatabaseScopedConfigurations_Value_Fail_Unsupported = "FAIL_UNSUPPORTED"; public const string DatabaseScopedConfigurations_Value_Fail_Unsupported = "FAIL_UNSUPPORTED";