From 6bafed10eb38bcd44ee714942b9ad478006dcc8f Mon Sep 17 00:00:00 2001 From: Christopher Suh Date: Thu, 15 Apr 2021 12:02:32 -0700 Subject: [PATCH] added rule id (#1190) --- .../Migration/Contracts/MigrationAssessmentInfo.cs | 5 +++++ .../Migration/MigrationService.cs | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.SqlTools.ServiceLayer/Migration/Contracts/MigrationAssessmentInfo.cs b/src/Microsoft.SqlTools.ServiceLayer/Migration/Contracts/MigrationAssessmentInfo.cs index 48032a19..33d8fbbe 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Migration/Contracts/MigrationAssessmentInfo.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Migration/Contracts/MigrationAssessmentInfo.cs @@ -22,6 +22,11 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration.Contracts /// public string RulesetName { get; set; } + /// + /// Gets or sets assessment ruleset name + /// + public string RuleId { get; set; } + /// /// Gets or sets assessed target's type. /// Supported values: 1 - server, 2 - database. diff --git a/src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs b/src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs index 20a7beba..9e340650 100644 --- a/src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs +++ b/src/Microsoft.SqlTools.ServiceLayer/Migration/MigrationService.cs @@ -194,7 +194,8 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration var targetName = !string.IsNullOrWhiteSpace(migrationResult.DatabaseName) ? $"{target.ServerName}:{migrationResult.DatabaseName}" - : target.Name; + : target.Name; + var ruleId = migrationResult.FeatureId.ToString(); var item = new MigrationAssessmentInfo() { @@ -210,6 +211,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Migration TargetType = target.Type, RulesetName = Engine.Configuration.DefaultRuleset.Name, RulesetVersion = Engine.Configuration.DefaultRuleset.Version.ToString(), + RuleId = ruleId, Message = r.Message, AppliesToMigrationTargetPlatform = migrationResult.AppliesToMigrationTargetPlatform.ToString(), IssueCategory = "Category_Unknown"