ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-17 02:51:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

Catch parser errors to prevent crashing (#617)

Browse Source
This commit is contained in:
Matt Irvine
2018-05-15 09:48:17 -07:00
committed by GitHub
parent 8f04a38858
commit 6f2c33c41c
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Microsoft.SqlTools.ServiceLayer/LanguageServices/LanguageService.cs
View File

@@ -765,13 +765,21 @@ namespace Microsoft.SqlTools.ServiceLayer.LanguageServices
// parse on separate thread so stack size can be increased // parse on separate thread so stack size can be increased
var parseThread = new Thread(() => var parseThread = new Thread(() =>
{ {
// parse current SQL file contents to retrieve a list of errors try
ParseResult parseResult = Parser.IncrementalParse( {
scriptFile.Contents, // parse current SQL file contents to retrieve a list of errors
parseInfo.ParseResult, ParseResult parseResult = Parser.IncrementalParse(
this.DefaultParseOptions); scriptFile.Contents,
parseInfo.ParseResult,
this.DefaultParseOptions);
parseInfo.ParseResult = parseResult; parseInfo.ParseResult = parseResult;
}
catch (Exception e)
{
// Log the exception but don't rethrow it to prevent parsing errors from crashing SQL Tools Service
Logger.Write(LogLevel.Error, string.Format("An unexpected error occured while parsing: {0}", e.ToString()));
}
}, ConnectedBindingQueue.QueueThreadStackSize); }, ConnectedBindingQueue.QueueThreadStackSize);
parseThread.Start(); parseThread.Start();
parseThread.Join(); parseThread.Join();