ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 18:47:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

fixed the bug with view triggers in object explorer (#639)

Browse Source
This commit is contained in:
Leila Lali
2018-06-18 11:36:24 -07:00
committed by GitHub
parent 29fb715ad5
commit 7322854c7b
4 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/SmoModel/SmoQueryModel.cs
View File

@@ -551,6 +551,16 @@ namespace Microsoft.SqlTools.ServiceLayer.ObjectExplorer.SmoModel
return new SmoCollectionWrapper<Trigger>(retValue).Where(c => PassesFinalFilters(parentTable, c)); return new SmoCollectionWrapper<Trigger>(retValue).Where(c => PassesFinalFilters(parentTable, c));
} }
} }
View parentView = context.Parent as View;
if (parentView != null)
{
var retValue = parentView.Triggers;
if (retValue != null)
{
retValue.ClearAndInitialize(filter, extraProperties);
return new SmoCollectionWrapper<Trigger>(retValue).Where(c => PassesFinalFilters(parentView, c));
}
}
return Enumerable.Empty<SqlSmoObject>(); return Enumerable.Empty<SqlSmoObject>();
} }
} }

5
src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/SmoModel/SmoQueryModelDefinition.xml
View File

@@ -57,7 +57,10 @@
<NavigationPath Parent="Table" Field="Columns" SubField="DefaultConstraint" FieldType="Column" /> <NavigationPath Parent="Table" Field="Columns" SubField="DefaultConstraint" FieldType="Column" />
<NavigationPath Parent="UserDefinedTableType" Field="Columns" SubField="DefaultConstraint" FieldType="Column" /> <NavigationPath Parent="UserDefinedTableType" Field="Columns" SubField="DefaultConstraint" FieldType="Column" />
</Node> </Node>
<Node Name="SqlDmlTrigger" Type="Trigger" Parent="Table" ValidFor="NotSqlDw" /> <Node Name="SqlDmlTrigger" Type="Trigger" ValidFor="NotSqlDw">
<Parent>Table</Parent>
<Parent>View</Parent>
</Node>
<Node Name="SqlFullTextIndex" Parent="Table" Collection="False" ValidFor="NotSqlDw" /> <Node Name="SqlFullTextIndex" Parent="Table" Collection="False" ValidFor="NotSqlDw" />
<Node Name="SqlStatistic" Parent="TableViewBase"/> <Node Name="SqlStatistic" Parent="TableViewBase"/>

1
test/Microsoft.SqlTools.ServiceLayer.Test.Common/TestData/ObjectExplorer/Baselines/AllSqlObjects.txt
View File

@@ -116,6 +116,7 @@ NodeType: Column Label: LastName (Name(nvarchar), not null) SubType: Status:
NodeType: Column Label: Suffix (nvarchar(10), null) SubType: Status: NodeType: Column Label: Suffix (nvarchar(10), null) SubType: Status:
NodeType: Column Label: JobTitle (nvarchar(50), not null) SubType: Status: NodeType: Column Label: JobTitle (nvarchar(50), not null) SubType: Status:
NodeType: Column Label: AdditionalContactInfo (AdditionalContactInfoSchemaCollection, null) SubType: Status: NodeType: Column Label: AdditionalContactInfo (AdditionalContactInfoSchemaCollection, null) SubType: Status:
NodeType: Trigger Label: ViewTrigger SubType: Status:
NodeType: Synonym Label: dbo.MyProduct SubType: Status: NodeType: Synonym Label: dbo.MyProduct SubType: Status:
NodeType: StoredProcedure Label: dbo.uspGetList SubType: Status: NodeType: StoredProcedure Label: dbo.uspGetList SubType: Status:
NodeType: StoredProcedureParameter Label: @Product (varchar, Input, No default) SubType:Input Status: NodeType: StoredProcedureParameter Label: @Product (varchar, Input, No default) SubType:Input Status:

10
test/Microsoft.SqlTools.ServiceLayer.Test.Common/TestData/ObjectExplorer/TestScripts/AllSqlObjects.sql
View File

@@ -241,6 +241,16 @@
GO GO
CREATE TRIGGER ViewTrigger on [HumanResources].[vEmployee]
INSTEAD OF INSERT
AS
BEGIN
Update [HumanResources].[Employee]
set JobTitle = 'Test1'
Where JobTitle = 'Test'
END
GO
CREATE TABLE [dbo].[tableWithAllDataTypes]( CREATE TABLE [dbo].[tableWithAllDataTypes](
[cDecimal] [decimal](18, 5) NULL, [cDecimal] [decimal](18, 5) NULL,
[cNumeric] [numeric](18, 2) NULL, [cNumeric] [numeric](18, 2) NULL,