ckaczor/sqltoolsservice
1
0
Fork 0
mirror of https://github.com/ckaczor/sqltoolsservice.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #37 from Microsoft/bug/integratedSecurityDefault

Browse Source 
Removed cases where we set integrated security by default
This commit is contained in:
Mitchell Sternke
2016-09-06 17:14:23 -07:00
committed by GitHub
parent 9c61f6d827 4b35d77214
commit 76e7ea041c
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
View File

@@ -371,7 +371,6 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
{ {
SqlConnectionStringBuilder connectionBuilder = new SqlConnectionStringBuilder(); SqlConnectionStringBuilder connectionBuilder = new SqlConnectionStringBuilder();
connectionBuilder["Data Source"] = connectionDetails.ServerName; connectionBuilder["Data Source"] = connectionDetails.ServerName;
connectionBuilder["Integrated Security"] = false;
connectionBuilder["User Id"] = connectionDetails.UserName; connectionBuilder["User Id"] = connectionDetails.UserName;
connectionBuilder["Password"] = connectionDetails.Password; connectionBuilder["Password"] = connectionDetails.Password;
@@ -388,7 +387,6 @@ namespace Microsoft.SqlTools.ServiceLayer.Connection
connectionBuilder.IntegratedSecurity = true; connectionBuilder.IntegratedSecurity = true;
break; break;
case "SqlLogin": case "SqlLogin":
connectionBuilder.IntegratedSecurity = false;
break; break;
default: default:
throw new ArgumentException(string.Format("Invalid value \"{0}\" for AuthenticationType. Valid values are \"Integrated\" and \"SqlLogin\".", connectionDetails.AuthenticationType)); throw new ArgumentException(string.Format("Invalid value \"{0}\" for AuthenticationType. Valid values are \"Integrated\" and \"SqlLogin\".", connectionDetails.AuthenticationType));

2
test/Microsoft.SqlTools.ServiceLayer.Test/Connection/ConnectionServiceTests.cs
View File

@@ -242,7 +242,7 @@ namespace Microsoft.SqlTools.ServiceLayer.Test.Connection
/// </summary> /// </summary>
[Theory] [Theory]
[InlineData("AuthenticationType", "Integrated", "Integrated Security")] [InlineData("AuthenticationType", "Integrated", "Integrated Security")]
[InlineData("AuthenticationType", "SqlLogin", "Integrated Security")] [InlineData("AuthenticationType", "SqlLogin", "")]
[InlineData("Encrypt", true, "Encrypt")] [InlineData("Encrypt", true, "Encrypt")]
[InlineData("Encrypt", false, "Encrypt")] [InlineData("Encrypt", false, "Encrypt")]
[InlineData("TrustServerCertificate", true, "TrustServerCertificate")] [InlineData("TrustServerCertificate", true, "TrustServerCertificate")]